Code analysis fixes

RamseyK · RamseyK · commit ba10597ed37f · 2025-01-31T23:27:55.000-05:00
diff --git a/src/ByteBuffer.cpp b/src/ByteBuffer.cpp
@@ -258,13 +258,13 @@ void ByteBuffer::put(uint8_t b, uint32_t index) {
     insert<uint8_t>(b, index);
 }
 
-void ByteBuffer::putBytes(const uint8_t* b, uint32_t len) {
+void ByteBuffer::putBytes(const uint8_t* const b, uint32_t len) {
     // Insert the data one byte at a time into the internal buffer at position i+starting index
     for (uint32_t i = 0; i < len; i++)
         append<uint8_t>(b[i]);
 }
 
-void ByteBuffer::putBytes(const uint8_t* b, uint32_t len, uint32_t index) {
+void ByteBuffer::putBytes(const uint8_t* const b, uint32_t len, uint32_t index) {
     wpos = index;
 
     // Insert the data one byte at a time into the internal buffer at position i+starting index
diff --git a/src/ByteBuffer.h b/src/ByteBuffer.h
@@ -95,8 +95,8 @@ class ByteBuffer {
     void put(const ByteBuffer* src); // Relative write of the entire contents of another ByteBuffer (src)
     void put(uint8_t b); // Relative write
     void put(uint8_t b, uint32_t index); // Absolute write at index
-    void putBytes(const uint8_t* b, uint32_t len); // Relative write
-    void putBytes(const uint8_t* b, uint32_t len, uint32_t index); // Absolute write starting at index
+    void putBytes(const uint8_t* const b, uint32_t len); // Relative write
+    void putBytes(const uint8_t* const b, uint32_t len, uint32_t index); // Absolute write starting at index
     void putChar(char value); // Relative
     void putChar(char value, uint32_t index); // Absolute
     void putDouble(double value);
diff --git a/src/Client.h b/src/Client.h
@@ -34,6 +34,9 @@ class Client {
 public:
     Client(int fd, sockaddr_in addr);
     ~Client();
+    Client& operator=(Client const&) = delete;  // Copy assignment
+    Client(Client &&) = delete;  // Move
+    Client& operator=(Client &&) = delete;  // Move assignment
 
     sockaddr_in getClientAddr() const {
         return clientAddr;
diff --git a/src/HTTPMessage.cpp b/src/HTTPMessage.cpp
@@ -27,7 +27,7 @@ HTTPMessage::HTTPMessage() : ByteBuffer(4096) {
 }
 
 HTTPMessage::HTTPMessage(std::string const& sData) : ByteBuffer(sData.size() + 1) {
-    putBytes((uint8_t*)sData.c_str(), sData.size() + 1);
+    putBytes((const uint8_t* const)sData.c_str(), sData.size() + 1);
 }
 
 HTTPMessage::HTTPMessage(const uint8_t* pData, uint32_t len) : ByteBuffer(pData, len) {
@@ -46,7 +46,7 @@ void HTTPMessage::putLine(std::string str, bool crlf_end) {
         str += "\r\n";
 
     // Put the entire contents of str into the buffer
-    putBytes((uint8_t*)str.c_str(), str.size());
+    putBytes((const uint8_t* const)str.c_str(), str.size());
 }
 
 /**
diff --git a/src/SendQueueItem.h b/src/SendQueueItem.h
@@ -39,8 +39,11 @@ class SendQueueItem {
     SendQueueItem(std::unique_ptr<uint8_t[]> data, uint32_t size, bool dc) : sendData(std::move(data)), sendSize(size), disconnect(dc) {
     }
 
-    ~SendQueueItem() {
-    }
+    ~SendQueueItem() = default;
+    SendQueueItem(SendQueueItem const&) = delete;  // Copy constructor
+    SendQueueItem& operator=(SendQueueItem const&) = delete;  // Copy assignment
+    SendQueueItem(SendQueueItem &&) = delete;  // Move
+    SendQueueItem& operator=(SendQueueItem &&) = delete;  // Move assignment
 
     void setOffset(uint32_t off) {
         sendOffset = off;

Original file line number	Diff line number	Diff line change
`@@ -258,13 +258,13 @@ void ByteBuffer::put(uint8_t b, uint32_t index) {`
`258`	`258`	`insert<uint8_t>(b, index);`
`259`	`259`	`}`
`260`	`260`
`261`		`-void ByteBuffer::putBytes(const uint8_t* b, uint32_t len) {`
	`261`	`+void ByteBuffer::putBytes(const uint8_t* const b, uint32_t len) {`
`262`	`262`	`// Insert the data one byte at a time into the internal buffer at position i+starting index`
`263`	`263`	`for (uint32_t i = 0; i < len; i++)`
`264`	`264`	`append<uint8_t>(b[i]);`
`265`	`265`	`}`
`266`	`266`
`267`		`-void ByteBuffer::putBytes(const uint8_t* b, uint32_t len, uint32_t index) {`
	`267`	`+void ByteBuffer::putBytes(const uint8_t* const b, uint32_t len, uint32_t index) {`
`268`	`268`	`wpos = index;`
`269`	`269`
`270`	`270`	`// Insert the data one byte at a time into the internal buffer at position i+starting index`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ HTTPMessage::HTTPMessage() : ByteBuffer(4096) {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`HTTPMessage::HTTPMessage(std::string const& sData) : ByteBuffer(sData.size() + 1) {`
`30`		`- putBytes((uint8_t*)sData.c_str(), sData.size() + 1);`
	`30`	`+ putBytes((const uint8_t* const)sData.c_str(), sData.size() + 1);`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`HTTPMessage::HTTPMessage(const uint8_t* pData, uint32_t len) : ByteBuffer(pData, len) {`
`@@ -46,7 +46,7 @@ void HTTPMessage::putLine(std::string str, bool crlf_end) {`
`46`	`46`	`str += "\r\n";`
`47`	`47`
`48`	`48`	`// Put the entire contents of str into the buffer`
`49`		`- putBytes((uint8_t*)str.c_str(), str.size());`
	`49`	`+ putBytes((const uint8_t* const)str.c_str(), str.size());`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`/**`