Added cap on maximum simultaneous clients to prevent file descriptor exhaustion

RamseyK · RamseyK · commit 77d2b1c2403e · 2026-04-07T19:52:03.000-04:00
diff --git a/src/HTTPMessage.h b/src/HTTPMessage.h
@@ -75,6 +75,7 @@ enum Status {
 
     // 4xx Client Error
     BAD_REQUEST = 400,
+    METHOD_NOT_ALLOWED = 405,
     NOT_FOUND = 404,
 
     // 5xx Server Error
diff --git a/src/HTTPResponse.cpp b/src/HTTPResponse.cpp
@@ -45,6 +45,8 @@ void HTTPResponse::determineStatusCode() {
         status = Status(OK);
     } else if (reason.contains("Bad Request")) {
         status = Status(BAD_REQUEST);
+    } else if (reason.contains("Method Not Allowed")) {
+        status = Status(METHOD_NOT_ALLOWED);
     } else if (reason.contains("Not Found")) {
         status = Status(NOT_FOUND);
     } else if (reason.contains("Server Error")) {
@@ -70,6 +72,9 @@ void HTTPResponse::determineReasonStr() {
     case Status(BAD_REQUEST):
         reason = "Bad Request";
         break;
+    case Status(METHOD_NOT_ALLOWED):
+        reason = "Method Not Allowed";
+        break;
     case Status(NOT_FOUND):
         reason = "Not Found";
         break;
diff --git a/src/HTTPServer.cpp b/src/HTTPServer.cpp
@@ -289,6 +289,12 @@ void HTTPServer::acceptConnection() {
     if (clfd == INVALID_SOCKET)
         return;
 
+    // Reject the connection if the client limit has been reached to prevent file descriptor exhaustion
+    if (clientMap.size() >= MAX_CLIENTS) {
+        close(clfd);
+        return;
+    }
+
     // Set socket as non-blocking; close and reject the connection if this fails
     if (fcntl(clfd, F_SETFL, O_NONBLOCK) == -1) {
         std::print("Failed to set client socket non-blocking, rejecting connection\n");
diff --git a/src/HTTPServer.h b/src/HTTPServer.h
@@ -40,6 +40,7 @@
 
 constexpr int32_t INVALID_SOCKET = -1;
 constexpr uint32_t QUEUE_SIZE = 1024;
+constexpr uint32_t MAX_CLIENTS = 1024;
 
 class HTTPServer {
     // Server Socket
