Reverse logics

tvdijen · tvdijen · commit b3386c7c5d3b · 2022-02-21T09:50:01.000+01:00
diff --git a/config-templates/config.php b/config-templates/config.php
@@ -461,7 +461,7 @@
      * In example when you are setting up a federation bridge.
      */
     'enable.saml20-idp' => false,
-    'enable.saml20-unsolicited' => false,
+    'enable.saml20-unsolicited' => true,
     'enable.adfs-idp' => false,
 
 
diff --git a/docs/simplesamlphp-upgrade-notes-2.0.md b/docs/simplesamlphp-upgrade-notes-2.0.md
@@ -30,8 +30,7 @@ Functional changes
   It is possible to switch back via the `sharedkey_algorithm`.
   Note however that CBC is vulnerable to the Padding oracle attack.
 - All support for the Shibboleth 1.3 / SAML 1.1 protocol has been removed.
-- Unsolicited responses are denied by default. If you need this functionality,
-  it can be enabled by setting `enable.saml20-unsolicited` to `true`.
+- Unsolicited responses can denied by disabling it by setting `enable.saml20-unsolicited` to `false`.
 
 Configuration changes
 ---------------------
diff --git a/modules/saml/lib/Auth/Source/SP.php b/modules/saml/lib/Auth/Source/SP.php
@@ -1139,7 +1139,7 @@ public static function onProcessingCompleted(array $authProcState): void
         $state['Attributes'] = $authProcState['Attributes'];
 
         $config = Configuration::getInstance();
-        $allowUnsolicited = $config->getBoolean('enable.saml20-unsolicited', false);
+        $allowUnsolicited = $config->getBoolean('enable.saml20-unsolicited', true);
 
         Assert::true(
             $allowUnsolicited,
diff --git a/modules/saml/www/sp/saml2-acs.php b/modules/saml/www/sp/saml2-acs.php
@@ -105,7 +105,7 @@
 }
 
 $config = Configuration::getInstance();
-$allowUnsolicited = $config->getBoolean('enable.saml20-unsolicited', false);
+$allowUnsolicited = $config->getBoolean('enable.saml20-unsolicited', true);
 
 Assert::true(
     $allowUnsolicited,

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`$config = Configuration::getInstance();`
`108`		`-$allowUnsolicited = $config->getBoolean('enable.saml20-unsolicited', false);`
	`108`	`+$allowUnsolicited = $config->getBoolean('enable.saml20-unsolicited', true);`
`109`	`109`
`110`	`110`	`Assert::true(`
`111`	`111`	`$allowUnsolicited,`