Skip to content

Commit a6458f5

Browse files
tvdijentvdijen
authored
Propagate Symfony responses throughout the code (simplesamlphp#1760)
* Migrate HTTP::redirect * Migrate HTTP::redirectTrustedURL * Migrate HTTP::redirectUntrustedURL * Migrate HTTP::submitPOSTData * Temporarily revert to make phpunit work * Migrate logout handlers * Remove unnecessary assertion & simplify logics * Remove unnecessary assertion & add new one to check response type * Remove unnecessary assertion & rationalize code * Migrate IdPDisco * Migrate ProcessingChain * Fix return-type & drop unnecessary use-statement * Address review comments * Do not add caching headers at all * Fix type-confusions * Migrate saml2 bindings * Migrate completeAuth * Migrate handleLogout * Migrate some more * Migrate a whole lot more (messy) * Migrate logout * Migrate a whole lot more (also messy) * Many fixes * Raise coverage * Psalm: Ignore exteranl adfs-module * Replace use of _GET globals * Migrate bindings (send) * Migrate bindings (receive) * Fix psalm-dev * Fix assertion * s/subclassOf/isInstanceOf * Fix type-confusion in logout handlers * Update container * Bump saml2 + adfs * Rename namespace
1 parent 7204202 commit a6458f5

123 files changed

Lines changed: 2026 additions & 1514 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/php.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
tools: composer, composer-require-checker, composer-unused, phpcs, psalm
5050
# optional performance gain for psalm: opcache
5151
extensions: ctype, date, dom, fileinfo, filter, hash, intl, json, mbstring, mysql, \
52-
opcache, openssl, pcre, pdo, pdo_sqlite, posix, spl, xml
52+
opcache, openssl, pcre, pdo, pdo_sqlite, posix, soap, spl, xml
5353
coverage: none
5454

5555
- name: Setup problem matchers for PHP
@@ -116,7 +116,7 @@ jobs:
116116
# Should be the lowest supported version
117117
php-version: '8.0'
118118
extensions: ctype, date, dom, hash, fileinfo, filter, intl, json, mbstring, mysql, \
119-
openssl, pcre, pdo, pdo_sqlite, posix, spl, xml
119+
openssl, pcre, pdo, pdo_sqlite, posix, soap, spl, xml
120120
tools: composer
121121
coverage: none
122122

@@ -164,7 +164,7 @@ jobs:
164164
with:
165165
php-version: ${{ matrix.php-versions }}
166166
extensions: ctype, date, dom, fileinfo, filter, hash, intl, json, mbstring, mysql, openssl, pcre,\
167-
pdo, pdo_sqlite, posix, spl, xdebug, xml
167+
pdo, pdo_sqlite, posix, soap, spl, xdebug, xml
168168
tools: composer
169169
ini-values: error_reporting=E_ALL, pcov.directory=.
170170
coverage: pcov
@@ -227,7 +227,7 @@ jobs:
227227
with:
228228
php-version: ${{ matrix.php-versions }}
229229
extensions: ctype, dom, date, fileinfo, filter, hash, intl, json, mbstring, mysql, openssl, pcre, \
230-
pdo, pdo_sqlite, posix, spl, xdebug, xml
230+
pdo, pdo_sqlite, posix, soap, spl, xdebug, xml
231231
tools: composer
232232
ini-values: error_reporting=E_ALL
233233
coverage: none

‎composer.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@
6666
"psr/log": "^2.0 || ^3.0",
6767
"robrichards/xmlseclibs": "^3.1.1",
6868
"simplesamlphp/assert": "^1.0.0",
69-
"simplesamlphp/saml2": "^4.6",
70-
"simplesamlphp/simplesamlphp-assets-base": "^2.0",
71-
"simplesamlphp/simplesamlphp-module-adfs": "dev-master#62f4d6367c184a30c35b2ba91511f2303c5bd4f1",
69+
"simplesamlphp/saml2": "^5.0.0-alpha.1",
70+
"simplesamlphp/simplesamlphp-assets-base": "^2.0.0",
71+
"simplesamlphp/simplesamlphp-module-adfs": "dev-master",
7272
"symfony/cache": "^5.4||^6",
7373
"symfony/config": "^5.4||^6",
7474
"symfony/console": "^5.4||^6",
@@ -79,6 +79,7 @@
7979
"symfony/http-foundation": "^5.4||^6",
8080
"symfony/http-kernel": "^5.4||^6",
8181
"symfony/intl": "^5.4||^6",
82+
"symfony/psr-http-message-bridge": "^2.1",
8283
"symfony/routing": "^5.4||^6",
8384
"symfony/translation-contracts": "^2.5||^3",
8485
"symfony/twig-bridge": "^5.4||^6",

0 commit comments

Comments
 (0)