docs: Add notes after reading PHP 8.4 changelog

tvdijen · tvdijen · commit 9823b289b2e0 · 2024-11-18T21:55:36.000+01:00
diff --git a/src/SimpleSAML/Error/ErrorHandler.php b/src/SimpleSAML/Error/ErrorHandler.php
@@ -46,6 +46,7 @@ public function customErrorHandler(
             E_USER_DEPRECATED => 'User Deprecated',
             E_NOTICE => 'Notice',
             E_USER_NOTICE => 'User Notice',
+            // E_STRICT has become deprecated in PHP 8.4
             E_STRICT => 'Runtime Notice',
             E_WARNING => 'Warning',
             E_USER_WARNING => 'User Warning',
diff --git a/src/SimpleSAML/Locale/Translate.php b/src/SimpleSAML/Locale/Translate.php
@@ -102,6 +102,7 @@ public static function translateSingularGettext(?string $original): string
 
                     // try attributes.po
                     if ($text === $original) {
+                        // @TODO: Fix this to be compatible with PHP 8.4 - domain cannot be an empty string
                         $text = TranslatorFunctions::getTranslator()->dgettext("", $original);
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ public static function translateSingularGettext(?string $original): string`
`102`	`102`
`103`	`103`	`// try attributes.po`
`104`	`104`	`if ($text === $original) {`
	`105`	`+ // @TODO: Fix this to be compatible with PHP 8.4 - domain cannot be an empty string`
`105`	`106`	`$text = TranslatorFunctions::getTranslator()->dgettext("", $original);`
`106`	`107`	`}`
`107`	`108`	`}`