Skip to content

Commit 8f418b3

Browse files
tvdijentvdijen
committed
Revert "Remove meaningless @test annotation"
This reverts commit 6bcea51.
1 parent 6bcea51 commit 8f418b3

12 files changed

Lines changed: 83 additions & 0 deletions

File tree

‎tests/lib/AutoloadModulesTest.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ protected function setUp()
1818
}
1919

2020
/**
21+
* @test
2122
* @runInSeparateProcess
2223
* @return void
2324
*/
@@ -27,6 +28,7 @@ public function autoloaderDoesNotRecurseInfinitely()
2728
}
2829

2930
/**
31+
* @test
3032
* @return void
3133
*/
3234
public function autoloaderSubstitutesNamespacedXmlSecClassesWhereNonNamespacedClassWasUsed()

‎tests/lib/SimpleSAML/Auth/SimpleTest.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
class SimpleTest extends \SimpleSAML\Test\Utils\ClearStateTestCase
1010
{
1111
/**
12+
* @test
1213
* @return void
1314
*/
1415
public function testGetProcessedURL()

‎tests/lib/SimpleSAML/DatabaseTest.php‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ public function setUp()
8080
* @covers SimpleSAML\Database::generateInstanceId
8181
* @covers SimpleSAML\Database::__construct
8282
* @covers SimpleSAML\Database::connect
83+
* @test
8384
* @return void
8485
*/
8586
public function connectionFailure()
@@ -104,6 +105,7 @@ public function connectionFailure()
104105
* @covers SimpleSAML\Database::generateInstanceId
105106
* @covers SimpleSAML\Database::__construct
106107
* @covers SimpleSAML\Database::connect
108+
* @test
107109
* @return void
108110
*/
109111
public function instances()
@@ -173,6 +175,7 @@ public function instances()
173175
* @covers SimpleSAML\Database::__construct
174176
* @covers SimpleSAML\Database::connect
175177
* @covers SimpleSAML\Database::getSlave
178+
* @test
176179
* @return void
177180
*/
178181
public function slaves()
@@ -215,6 +218,7 @@ public function slaves()
215218

216219
/**
217220
* @covers SimpleSAML\Database::applyPrefix
221+
* @test
218222
* @return void
219223
*/
220224
public function prefix()
@@ -232,6 +236,7 @@ public function prefix()
232236
* @covers SimpleSAML\Database::read
233237
* @covers SimpleSAML\Database::exec
234238
* @covers SimpleSAML\Database::query
239+
* @test
235240
* @return void
236241
*/
237242
public function querying()
@@ -264,6 +269,7 @@ public function querying()
264269
/**
265270
* @covers SimpleSAML\Database::read
266271
* @covers SimpleSAML\Database::query
272+
* @test
267273
* @return void
268274
*/
269275
public function readFailure()
@@ -279,6 +285,7 @@ public function readFailure()
279285
/**
280286
* @covers SimpleSAML\Database::write
281287
* @covers SimpleSAML\Database::exec
288+
* @test
282289
* @return void
283290
*/
284291
public function noSuchTable()

‎tests/lib/SimpleSAML/Store/RedisTest.php‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ public function delMocked($key)
9898
/**
9999
* @covers \SimpleSAML\Store::getInstance
100100
* @covers \SimpleSAML\Store\Redis::__construct
101+
* @test
101102
* @return void
102103
*/
103104
public function testRedisInstance()
@@ -119,6 +120,7 @@ public function testRedisInstance()
119120
/**
120121
* @covers \SimpleSAML\Store::getInstance
121122
* @covers \SimpleSAML\Store\Redis::__construct
123+
* @test
122124
* @return void
123125
*/
124126
public function testRedisInstanceWithPassword()
@@ -141,6 +143,7 @@ public function testRedisInstanceWithPassword()
141143
/**
142144
* @covers \SimpleSAML\Store\Redis::get
143145
* @covers \SimpleSAML\Store\Redis::set
146+
* @test
144147
* @return void
145148
*/
146149
public function testInsertData()
@@ -158,6 +161,7 @@ public function testInsertData()
158161
/**
159162
* @covers \SimpleSAML\Store\Redis::get
160163
* @covers \SimpleSAML\Store\Redis::set
164+
* @test
161165
* @return void
162166
*/
163167
public function testInsertExpiringData()
@@ -174,6 +178,7 @@ public function testInsertExpiringData()
174178

175179
/**
176180
* @covers \SimpleSAML\Store\Redis::get
181+
* @test
177182
* @return void
178183
*/
179184
public function testGetEmptyData()
@@ -187,6 +192,7 @@ public function testGetEmptyData()
187192
/**
188193
* @covers \SimpleSAML\Store\Redis::get
189194
* @covers \SimpleSAML\Store\Redis::set
195+
* @test
190196
* @return void
191197
*/
192198
public function testOverwriteData()
@@ -207,6 +213,7 @@ public function testOverwriteData()
207213
* @covers \SimpleSAML\Store\Redis::get
208214
* @covers \SimpleSAML\Store\Redis::set
209215
* @covers \SimpleSAML\Store\Redis::delete
216+
* @test
210217
* @return void
211218
*/
212219
public function testDeleteData()

‎tests/lib/SimpleSAML/Store/SQLTest.php‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ protected function setUp()
3333
/**
3434
* @covers \SimpleSAML\Store::getInstance
3535
* @covers \SimpleSAML\Store\SQL::__construct
36+
* @test
3637
* @return void
3738
*/
3839
public function SQLInstance()
@@ -46,6 +47,7 @@ public function SQLInstance()
4647
/**
4748
* @covers \SimpleSAML\Store\SQL::initTableVersionTable
4849
* @covers \SimpleSAML\Store\SQL::initKVTable
50+
* @test
4951
* @return void
5052
*/
5153
public function kvstoreTableVersion()
@@ -61,6 +63,7 @@ public function kvstoreTableVersion()
6163

6264
/**
6365
* @covers \SimpleSAML\Store\SQL::getTableVersion
66+
* @test
6467
* @return void
6568
*/
6669
public function newTableVersion()
@@ -77,6 +80,7 @@ public function newTableVersion()
7780
/**
7881
* @covers \SimpleSAML\Store\SQL::setTableVersion
7982
* @covers \SimpleSAML\Store\SQL::insertOrUpdate
83+
* @test
8084
* @return void
8185
*/
8286
public function testSetTableVersion()
@@ -93,6 +97,7 @@ public function testSetTableVersion()
9397

9498
/**
9599
* @covers \SimpleSAML\Store\SQL::get
100+
* @test
96101
* @return void
97102
*/
98103
public function testGetEmptyData()
@@ -110,6 +115,7 @@ public function testGetEmptyData()
110115
* @covers \SimpleSAML\Store\SQL::get
111116
* @covers \SimpleSAML\Store\SQL::set
112117
* @covers \SimpleSAML\Store\SQL::insertOrUpdate
118+
* @test
113119
* @return void
114120
*/
115121
public function testInsertData()
@@ -128,6 +134,7 @@ public function testInsertData()
128134
* @covers \SimpleSAML\Store\SQL::get
129135
* @covers \SimpleSAML\Store\SQL::set
130136
* @covers \SimpleSAML\Store\SQL::insertOrUpdate
137+
* @test
131138
* @return void
132139
*/
133140
public function testOverwriteData()
@@ -148,6 +155,7 @@ public function testOverwriteData()
148155
* @covers \SimpleSAML\Store\SQL::set
149156
* @covers \SimpleSAML\Store\SQL::insertOrUpdate
150157
* @covers \SimpleSAML\Store\SQL::delete
158+
* @test
151159
* @return void
152160
*/
153161
public function testDeleteData()
@@ -168,6 +176,7 @@ public function testDeleteData()
168176
* @covers \SimpleSAML\Store\SQL::set
169177
* @covers \SimpleSAML\Store\SQL::insertOrUpdate
170178
* @covers \SimpleSAML\Store\SQL::delete
179+
* @test
171180
* @return void
172181
*/
173182
public function testVeryLongKey()

‎tests/lib/SimpleSAML/StoreTest.php‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class StoreTest extends TestCase
2121
{
2222
/**
2323
* @covers \SimpleSAML\Store::getInstance
24+
* @test
2425
* @return void
2526
*/
2627
public function defaultStore()
@@ -36,6 +37,7 @@ public function defaultStore()
3637

3738
/**
3839
* @covers \SimpleSAML\Store::getInstance
40+
* @test
3941
* @return void
4042
*/
4143
public function phpSessionStore()
@@ -51,6 +53,7 @@ public function phpSessionStore()
5153

5254
/**
5355
* @covers \SimpleSAML\Store::getInstance
56+
* @test
5457
* @return void
5558
*/
5659
public function memcacheStore()
@@ -67,6 +70,7 @@ public function memcacheStore()
6770

6871
/**
6972
* @covers \SimpleSAML\Store::getInstance
73+
* @test
7074
* @return void
7175
*/
7276
public function sqlStore()
@@ -85,6 +89,7 @@ public function sqlStore()
8589

8690
/**
8791
* @covers \SimpleSAML\Store::getInstance
92+
* @test
8893
* @return void
8994
*/
9095
public function pathStore()
@@ -103,6 +108,7 @@ public function pathStore()
103108

104109
/**
105110
* @covers \SimpleSAML\Store::getInstance
111+
* @test
106112
* @return void
107113
*/
108114
public function notFoundStoreException()

‎tests/lib/SimpleSAML/Utils/SystemTest.php‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ public function setUp()
3636

3737
/**
3838
* @covers \SimpleSAML\Utils\System::getOS
39+
* @test
3940
* @return void
4041
*/
4142
public function testGetOSBasic()
@@ -48,6 +49,7 @@ public function testGetOSBasic()
4849

4950
/**
5051
* @covers \SimpleSAML\Utils\System::resolvePath
52+
* @test
5153
* @return void
5254
*/
5355
public function testResolvePathRemoveTrailingSlashes()
@@ -64,6 +66,7 @@ public function testResolvePathRemoveTrailingSlashes()
6466

6567
/**
6668
* @covers \SimpleSAML\Utils\System::resolvePath
69+
* @test
6770
* @return void
6871
*/
6972
public function testResolvePathPreferAbsolutePathToBase()
@@ -80,6 +83,7 @@ public function testResolvePathPreferAbsolutePathToBase()
8083

8184
/**
8285
* @covers \SimpleSAML\Utils\System::resolvePath
86+
* @test
8387
* @return void
8488
*/
8589
public function testResolvePathCurDirPath()
@@ -96,6 +100,7 @@ public function testResolvePathCurDirPath()
96100

97101
/**
98102
* @covers \SimpleSAML\Utils\System::resolvePath
103+
* @test
99104
* @return void
100105
*/
101106
public function testResolvePathParentPath()
@@ -112,6 +117,7 @@ public function testResolvePathParentPath()
112117

113118
/**
114119
* @covers \SimpleSAML\Utils\System::resolvePath
120+
* @test
115121
* @return void
116122
*/
117123
public function testResolvePathAllowsStreamWrappers()
@@ -128,6 +134,7 @@ public function testResolvePathAllowsStreamWrappers()
128134

129135
/**
130136
* @covers \SimpleSAML\Utils\System::resolvePath
137+
* @test
131138
* @return void
132139
*/
133140
public function testResolvePathAllowsAwsS3StreamWrappers()
@@ -144,6 +151,7 @@ public function testResolvePathAllowsAwsS3StreamWrappers()
144151

145152
/**
146153
* @covers \SimpleSAML\Utils\System::writeFile
154+
* @test
147155
* @deprecated Test becomes obsolete as soon as the codebase is fully type hinted
148156
* @return void
149157
*/
@@ -157,6 +165,7 @@ public function testWriteFileInvalidArguments()
157165

158166
/**
159167
* @covers \SimpleSAML\Utils\System::writeFile
168+
* @test
160169
* @return void
161170
*/
162171
public function testWriteFileBasic()
@@ -176,6 +185,7 @@ public function testWriteFileBasic()
176185

177186
/**
178187
* @covers \SimpleSAML\Utils\System::writeFile
188+
* @test
179189
* @return void
180190
*/
181191
public function testWriteFileContents()
@@ -199,6 +209,7 @@ public function testWriteFileContents()
199209

200210
/**
201211
* @covers \SimpleSAML\Utils\System::writeFile
212+
* @test
202213
* @return void
203214
*/
204215
public function testWriteFileMode()
@@ -222,6 +233,7 @@ public function testWriteFileMode()
222233

223234
/**
224235
* @covers \SimpleSAML\Utils\System::getTempDir
236+
* @test
225237
* @return void
226238
*/
227239
public function testGetTempDirBasic()
@@ -241,6 +253,7 @@ public function testGetTempDirBasic()
241253

242254
/**
243255
* @covers \SimpleSAML\Utils\System::getTempDir
256+
* @test
244257
* @return void
245258
*/
246259
public function testGetTempDirNonExistant()
@@ -261,6 +274,7 @@ public function testGetTempDirNonExistant()
261274
/**
262275
* @requires OS Linux
263276
* @covers \SimpleSAML\Utils\System::getTempDir
277+
* @test
264278
* @return void
265279
*/
266280
public function testGetTempDirBadOwner()

0 commit comments

Comments
 (0)