Skip to content

Commit 466139f

Browse files
farahInTheZonefarahInTheZone
authored
Remove debugger banner (microsoft#19849)
### Problem #### Issue Link microsoft#19714 #### Summary Remove debugger banner #### Description It was reported in the issue 19714 that we display a prompt to get feedback on a separate survey for the debugger, but given we get a lot of feedback for the debugger in our "general" survey, it should be fine to remove it. ### Solution #### Implementation The current implementation of the debugger survey is defined in a banner class. This class pops up a banner to ask if the user wants to fill out the survey or not. If selected yes, a browser with the survey link is opened. After discussing with the team, we decided to remove the banner completely, and if it is needed in the future the team will restore it. #### Testing ##### Unit test [debugging-output.txt](https://github.com/microsoft/vscode-python/files/9586036/debugging-output.txt)
1 parent 38d8d9c commit 466139f

6 files changed

Lines changed: 1 addition & 568 deletions

File tree

‎src/client/debugger/extension/banner.ts‎

Lines changed: 0 additions & 193 deletions
This file was deleted.

‎src/client/debugger/extension/serviceRegistry.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { DebugSessionLoggingFactory } from './adapter/logging';
1212
import { OutdatedDebuggerPromptFactory } from './adapter/outdatedDebuggerPrompt';
1313
import { AttachProcessProviderFactory } from './attachQuickPick/factory';
1414
import { IAttachProcessProviderFactory } from './attachQuickPick/types';
15-
import { DebuggerBanner } from './banner';
1615
import { PythonDebugConfigurationService } from './configuration/debugConfigurationService';
1716
import { DynamicPythonDebugConfigurationService } from './configuration/dynamicdebugConfigurationService';
1817
import { LaunchJsonCompletionProvider } from './configuration/launch.json/completionProvider';
@@ -30,7 +29,6 @@ import { IChildProcessAttachService, IDebugSessionEventHandlers } from './hooks/
3029
import {
3130
IDebugAdapterDescriptorFactory,
3231
IDebugConfigurationService,
33-
IDebuggerBanner,
3432
IDebugSessionLoggingFactory,
3533
IDynamicDebugConfigurationService,
3634
IOutdatedDebuggerPromptFactory,
@@ -57,7 +55,6 @@ export function registerTypes(serviceManager: IServiceManager) {
5755
IDynamicDebugConfigurationService,
5856
DynamicPythonDebugConfigurationService,
5957
);
60-
serviceManager.addSingleton<IDebuggerBanner>(IDebuggerBanner, DebuggerBanner);
6158
serviceManager.addSingleton<IChildProcessAttachService>(IChildProcessAttachService, ChildProcessAttachService);
6259
serviceManager.addSingleton<IDebugSessionEventHandlers>(IDebugSessionEventHandlers, ChildProcessAttachEventHandler);
6360
serviceManager.addSingleton<IDebugConfigurationResolver<LaunchRequestArguments>>(

‎src/client/debugger/extension/types.ts‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ export interface IDebugConfigurationService extends DebugConfigurationProvider {
2121
export const IDynamicDebugConfigurationService = Symbol('IDynamicDebugConfigurationService');
2222
export interface IDynamicDebugConfigurationService extends DebugConfigurationProvider {}
2323

24-
export const IDebuggerBanner = Symbol('IDebuggerBanner');
25-
export interface IDebuggerBanner {
26-
initialize(): void;
27-
}
28-
2924
export type DebugConfigurationState = {
3025
config: Partial<DebugConfigurationArguments>;
3126
folder?: WorkspaceFolder;

‎src/client/extensionActivation.ts‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,7 @@ import {
3131
import { noop } from './common/utils/misc';
3232
import { DebuggerTypeName } from './debugger/constants';
3333
import { registerTypes as debugConfigurationRegisterTypes } from './debugger/extension/serviceRegistry';
34-
import {
35-
IDebugConfigurationService,
36-
IDebuggerBanner,
37-
IDynamicDebugConfigurationService,
38-
} from './debugger/extension/types';
34+
import { IDebugConfigurationService, IDynamicDebugConfigurationService } from './debugger/extension/types';
3935
import { registerTypes as formattersRegisterTypes } from './formatters/serviceRegistry';
4036
import { IInterpreterService } from './interpreter/contracts';
4137
import { getLanguageConfiguration } from './language/languageConfiguration';
@@ -229,8 +225,6 @@ async function activateLegacy(ext: ExtensionState): Promise<ActivationResult> {
229225
DebugConfigurationProviderTriggerKind.Dynamic,
230226
),
231227
);
232-
233-
serviceContainer.get<IDebuggerBanner>(IDebuggerBanner).initialize();
234228
}
235229
}
236230

0 commit comments

Comments
 (0)