Fix SizedRotatingLogger file format bug (hardbyte#1793)

zariiii9003 · web-flow · commit 8ea242593ea3 · 2024-06-18T13:20:33.000+02:00
diff --git a/can/io/logger.py b/can/io/logger.py
@@ -259,17 +259,19 @@ def _get_new_writer(self, filename: StringPathLike) -> FileIOMessageWriter:
         :return:
             An instance of a writer class.
         """
-        suffix = "".join(pathlib.Path(filename).suffixes[-2:]).lower()
-
-        if suffix in self._supported_formats:
+        suffixes = pathlib.Path(filename).suffixes
+        for suffix_length in range(len(suffixes), 0, -1):
+            suffix = "".join(suffixes[-suffix_length:]).lower()
+            if suffix not in self._supported_formats:
+                continue
             logger = Logger(filename=filename, **self.writer_kwargs)
             if isinstance(logger, FileIOMessageWriter):
                 return logger
             elif isinstance(logger, Printer) and logger.file is not None:
                 return cast(FileIOMessageWriter, logger)
 
         raise ValueError(
-            f'The log format "{suffix}" '
+            f'The log format of "{pathlib.Path(filename).name}" '
             f"is not supported by {self.__class__.__name__}. "
             f"{self.__class__.__name__} supports the following formats: "
             f"{', '.join(self._supported_formats)}"
diff --git a/test/test_rotating_loggers.py b/test/test_rotating_loggers.py
@@ -180,6 +180,14 @@ def test_on_message_received(self, tmp_path):
             do_rollover.assert_called()
             writers_on_message_received.assert_called_with(msg)
 
+    def test_issue_1792(self, tmp_path):
+        with self._get_instance(tmp_path / "__unused.log") as logger_instance:
+            writer = logger_instance._get_new_writer(
+                tmp_path / "2017_Jeep_Grand_Cherokee_3.6L_V6.log"
+            )
+            assert isinstance(writer, can.CanutilsLogWriter)
+            writer.stop()
+
 
 class TestSizedRotatingLogger:
     def test_import(self):
