[[CID 16816]] libfoundation: Fix release of incorrect variable.

peter-b · peter-b · commit 1f202344b4b3 · 2015-01-27T09:03:43.000Z
On failing to allocate storage in __MCSetClone(), the value being
cloned (`self`) was being released instead of the newly created clone
value (`t_new_set`).
diff --git a/libfoundation/src/foundation-set.cpp b/libfoundation/src/foundation-set.cpp
@@ -276,7 +276,7 @@ static bool __MCSetClone(MCSetRef self, bool p_as_mutable, MCSetRef& r_new_self)
 
 	if (!MCMemoryNewArray(self -> limb_count, t_new_set -> limbs, t_new_set -> limb_count))
 	{
-		MCValueRelease(self);
+		MCValueRelease(t_new_set);
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ static bool __MCSetClone(MCSetRef self, bool p_as_mutable, MCSetRef& r_new_self)`
`276`	`276`
`277`	`277`	`if (!MCMemoryNewArray(self -> limb_count, t_new_set -> limbs, t_new_set -> limb_count))`
`278`	`278`	`{`
`279`		`- MCValueRelease(self);`
	`279`	`+ MCValueRelease(t_new_set);`
`280`	`280`	`return false;`
`281`	`281`	`}`
`282`	`282`