engine: Fix Boolean stored in single bit

peter-b · peter-b · commit 038f2c9c818f · 2017-02-24T09:41:47.000Z
The `Boolean` type used in the engine is actually a tristate, which
permits a `Mixed` value (value 2).  This patch replaces all instances
of `Boolean` that are explicitly stored in a single bit with `bool`.
diff --git a/engine/src/chunk.h b/engine/src/chunk.h
@@ -71,7 +71,7 @@ class MCChunk : public MCExpression
 	MCObject *destobj;
 	Dest_type desttype;
 	Functions function;
-	Boolean marked : 1;
+	bool marked : 1;
     
     // MW-2014-05-28: [[ Bug 11928 ]] This is set to true after 'destvar' has been evaluated
     //   as a chunk. This stops stale chunk information being used in MCChunk::del.
diff --git a/engine/src/cmds.h b/engine/src/cmds.h
@@ -93,7 +93,7 @@ class MCDo : public MCStatement
 	MCChunk *widget;
 protected:
 	bool browser : 1;
-	Boolean debug : 1;
+	bool debug : 1;
 	bool caller : 1;
 public:
 	MCDo()
@@ -500,11 +500,11 @@ class MCCreate : public MCStatement
 	MCExpression *file;
     MCExpression *kind;
     MCChunk *container;
-    Boolean directory: 1;
-    Boolean visible: 1;
-    Boolean alias: 1;
+    bool directory: 1;
+    bool visible: 1;
+    bool alias: 1;
     // MW-2014-09-30: [[ ScriptOnlyStack ]] For 'create script only stack ...' form.
-    Boolean script_only_stack : 1;
+    bool script_only_stack : 1;
 public:
 	MCCreate()
 	{
@@ -1517,16 +1517,16 @@ class MCOpen : public MCStatement
 	MCStringRef destination;
 	Open_argument arg : 4;
 	Open_mode mode : 4;
-	Boolean dialog : 1;
-	Boolean datagram : 1;
-	Boolean sheet : 1;
-	Boolean secure : 1;
-	Boolean secureverify : 1;
-    Boolean textmode : 1;
+	bool dialog : 1;
+	bool datagram : 1;
+	bool sheet : 1;
+	bool secure : 1;
+	bool secureverify : 1;
+    bool textmode : 1;
 
 	// MW-2010-05-09: Indicates that the process should be opened with elevated
 	//   (admin) permissions
-	Boolean elevated : 1;
+	bool elevated : 1;
 	
 	// MM-2014-06-13: [[ Bug 12567 ]] Added new "open socket <socket> with verification for <host>" variant.
 	MCExpression *verifyhostname;
@@ -1768,7 +1768,7 @@ class MCSetOp : public MCStatement
 	MCVarref *destvar;
 	MCExpression *source;
 protected:
-	Boolean intersect : 1;
+	bool intersect : 1;
 	bool overlap : 1;
     // MERG-2013-08-26: [[ RecursiveArrayOp ]] Support nested arrays in union and intersect
     bool recursive : 1;
@@ -2197,7 +2197,7 @@ class MCSecure : public MCStatement
 	
 private:
 	MCExpression *m_sock_name;
-	Boolean secureverify : 1;
+	bool secureverify : 1;
 	
 	// MM-2014-06-13: [[ Bug 12567 ]] Added new host name variant for use with verification.
 	MCExpression *m_verify_host_name;
diff --git a/engine/src/variable.h b/engine/src/variable.h
@@ -338,11 +338,11 @@ class MCVarref : public MCExpression
 	};
 	unsigned index : 16;
 	unsigned dimensions : 8;
-	Boolean isparam : 1;
+	bool isparam : 1;
 
 	// MW-2008-10-28: [[ ParentScripts ]] This boolean flag is True if this
 	//   varref refers to a script local.
-	Boolean isscriptlocal : 1;
+	bool isscriptlocal : 1;
 	
 	// MW-2012-03-15: [[ Bug ]] This boolean flag is true if this varref is
 	//   a plain var and doesn't require synching.
