Revert "work around python/mypy#11852"

asottile · asottile · commit bba6cf4296c7 · 2022-01-10T15:35:33.000-05:00
This reverts commit 83675fe.
diff --git a/pre_commit/xargs.py b/pre_commit/xargs.py
@@ -159,8 +159,7 @@ def run_cmd_partition(
         )
 
     threads = min(len(partitions), target_concurrency)
-    # https://github.com/python/mypy/issues/11852
-    with _thread_mapper(threads) as thread_map:  # type: ignore
+    with _thread_mapper(threads) as thread_map:
         results = thread_map(run_cmd_partition, partitions)
 
         for proc_retcode, proc_out, _ in results:
diff --git a/tests/xargs_test.py b/tests/xargs_test.py
@@ -166,15 +166,13 @@ def test_xargs_concurrency():
 
 
 def test_thread_mapper_concurrency_uses_threadpoolexecutor_map():
-    # https://github.com/python/mypy/issues/11852
-    with xargs._thread_mapper(10) as thread_map:  # type: ignore
+    with xargs._thread_mapper(10) as thread_map:
         _self = thread_map.__self__  # type: ignore
         assert isinstance(_self, concurrent.futures.ThreadPoolExecutor)
 
 
 def test_thread_mapper_concurrency_uses_regular_map():
-    # https://github.com/python/mypy/issues/11852
-    with xargs._thread_mapper(1) as thread_map:  # type: ignore
+    with xargs._thread_mapper(1) as thread_map:
         assert thread_map is map
 
 

Original file line number	Diff line number	Diff line change
`@@ -159,8 +159,7 @@ def run_cmd_partition(`
`159`	`159`	`)`
`160`	`160`
`161`	`161`	`threads = min(len(partitions), target_concurrency)`
`162`		`- # https://github.com/python/mypy/issues/11852`
`163`		`- with _thread_mapper(threads) as thread_map: # type: ignore`
	`162`	`+ with _thread_mapper(threads) as thread_map:`
`164`	`163`	`results = thread_map(run_cmd_partition, partitions)`
`165`	`164`
`166`	`165`	`for proc_retcode, proc_out, _ in results:`