Skip to content

Commit 4f2f173

Browse files
committed
Add language_version to the manifest loader.
1 parent 914a74f commit 4f2f173

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

pre_commit/clientlib/validate_manifest.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class InvalidManifestError(ValueError):
2020
'description': {'type': 'string', 'default': ''},
2121
'entry': {'type': 'string'},
2222
'language': {'type': 'string'},
23+
'language_version': {'type': 'string', 'default': 'default'},
2324
'expected_return_value': {'type': 'number', 'default': 0},
2425
},
2526
'required': ['id', 'name', 'entry', 'language'],

tests/languages/ruby_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
import os.path
22

33
from pre_commit.languages.ruby import _install_rbenv
4+
from testing.util import skipif_slowtests_false
45

56

7+
@skipif_slowtests_false
68
def test_install_rbenv(cmd_runner):
79
_install_rbenv(cmd_runner)
810
# Should have created rbenv directory

tests/manifest_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ def test_manifest_contents(manifest):
1919
'expected_return_value': 0,
2020
'id': 'bash_hook',
2121
'language': 'script',
22+
'language_version': 'default',
2223
'name': 'Bash hook',
2324
}]
2425

@@ -30,5 +31,6 @@ def test_hooks(manifest):
3031
'expected_return_value': 0,
3132
'id': 'bash_hook',
3233
'language': 'script',
34+
'language_version': 'default',
3335
'name': 'Bash hook',
3436
}

0 commit comments

Comments
 (0)