Skip to content

Commit 95e0260

Browse files
jmgaoGerrit Code Review
authored andcommitted
Merge "adb: update tests for push/pull directory change."
2 parents 95f81b0 + 7fe79d6 commit 95e0260

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

python-packages/adb/test_device.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -690,10 +690,7 @@ def test_push_dir(self):
690690

691691
for temp_file in temp_files:
692692
remote_path = posixpath.join(self.DEVICE_TEMP_DIR,
693-
# BROKEN: http://b/25394682
694-
# posixpath.dirname(
695-
# posixpath.dirname(
696-
# temp_file.full_path)),
693+
os.path.basename(host_dir),
697694
temp_file.base_name)
698695
self._verify_remote(temp_file.checksum, remote_path)
699696
self.device.shell(['rm', '-rf', self.DEVICE_TEMP_DIR])
@@ -838,7 +835,7 @@ def test_pull_empty(self):
838835
self.device.shell(['rm', '-rf', self.DEVICE_TEMP_DIR])
839836
self.device.shell(['mkdir', '-p', remote_empty_path])
840837

841-
self.device.pull(remote=self.DEVICE_TEMP_DIR, local=host_dir)
838+
self.device.pull(remote=remote_empty_path, local=host_dir)
842839
self.assertTrue(os.path.isdir(os.path.join(host_dir, 'empty')))
843840
finally:
844841
if host_dir is not None:
@@ -871,8 +868,7 @@ def test_multiple_pull(self):
871868

872869
for subdir_temp_file in subdir_temp_files:
873870
local_path = os.path.join(host_dir,
874-
# BROKEN: http://b/25394682
875-
# "subdir",
871+
"subdir",
876872
subdir_temp_file.base_name)
877873
self._verify_local(subdir_temp_file.checksum, local_path)
878874

0 commit comments

Comments
 (0)