Skip to content

Commit 8793800

Browse files
author
Everett Toews
committed
Rename messaging module to message
Looking at the project names [1] it's clear that the official names don't end in 'ing' (the only exception being Networking). The SDK follows the official names as our module naming convention. Hence we should not append 'ing' to module names whether they have an official name in that list or not. We need to rename the messaging module to message. [1] https://wiki.openstack.org/wiki/Documentation/Conventions Change-Id: I2a433cb72341e2660e33cd3f946e2f22eed19622
1 parent 9a02c1d commit 8793800

13 files changed

Lines changed: 24 additions & 24 deletions

File tree

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
from openstack.auth import service_filter
1414

1515

16-
class MessagingService(service_filter.ServiceFilter):
17-
"""The messaging service."""
16+
class MessageService(service_filter.ServiceFilter):
17+
"""The message service."""
1818

1919
valid_versions = [service_filter.ValidVersion('v1')]
2020

2121
def __init__(self, version=None):
22-
"""Create an messaging service."""
23-
super(MessagingService, self).__init__(
22+
"""Create a message service."""
23+
super(MessageService, self).__init__(
2424
service_type='messaging',
2525
version=version
2626
)
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# License for the specific language governing permissions and limitations
1111
# under the License.
1212

13-
from openstack.messaging.v1 import queue
13+
from openstack.message.v1 import queue
1414
from openstack import proxy
1515

1616

@@ -20,10 +20,10 @@ def create_queue(self, **attrs):
2020
"""Create a new queue from attributes
2121
2222
:param dict attrs: Keyword arguments which will be used to create
23-
a :class:`~openstack.messaging.v1.queue.Queue`,
23+
a :class:`~openstack.message.v1.queue.Queue`,
2424
comprised of the properties on the Queue class.
2525
2626
:returns: The results of queue creation
27-
:rtype: :class:`~openstack.messaging.v1.queue.Queue`
27+
:rtype: :class:`~openstack.message.v1.queue.Queue`
2828
"""
2929
return self._create(queue.Queue, **attrs)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
# License for the specific language governing permissions and limitations
1111
# under the License.
1212

13-
from openstack.messaging import messaging_service
13+
from openstack.message import message_service
1414
from openstack import resource
1515

1616

1717
class Queue(resource.Resource):
1818
id_attribute = 'name'
1919
resources_key = 'queues'
2020
base_path = '/queues'
21-
service = messaging_service.MessagingService()
21+
service = message_service.MessageService()
2222

2323
# capabilities
2424
allow_create = True
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@
1010
# License for the specific language governing permissions and limitations
1111
# under the License.
1212

13-
from openstack.messaging import messaging_service
13+
from openstack.message import message_service
1414
from openstack import resource
1515

1616

1717
class Version(resource.Resource):
1818
resource_key = 'version'
1919
resources_key = 'versions'
2020
base_path = '/'
21-
service = messaging_service.MessagingService(
22-
version=messaging_service.MessagingService.UNVERSIONED
21+
service = message_service.MessageService(
22+
version=message_service.MessageService.UNVERSIONED
2323
)
2424

2525
# capabilities

openstack/profile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
from openstack.identity import identity_service
6060
from openstack.image import image_service
6161
from openstack.keystore import keystore_service
62-
from openstack.messaging import messaging_service
62+
from openstack.message import message_service
6363
from openstack.metric import metric_service
6464
from openstack.network import network_service
6565
from openstack.object_store import object_store_service
@@ -121,7 +121,7 @@ def __init__(self):
121121
serv = volume_service.VolumeService()
122122
serv.set_visibility(None)
123123
self._services[serv.service_type] = serv
124-
serv = messaging_service.MessagingService()
124+
serv = message_service.MessageService()
125125
serv.set_visibility(None)
126126
self._services[serv.service_type] = serv
127127

File renamed without changes.

openstack/tests/unit/messaging/test_messaging_service.py renamed to openstack/tests/unit/message/test_message_service.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,13 @@
1212

1313
import testtools
1414

15-
from openstack.messaging import messaging_service
15+
from openstack.message import message_service
1616

1717

18-
class TestOrchestrationService(testtools.TestCase):
18+
class TestMessageService(testtools.TestCase):
1919

2020
def test_service(self):
21-
sot = messaging_service.MessagingService()
21+
sot = message_service.MessageService()
2222
self.assertEqual('messaging', sot.service_type)
2323
self.assertEqual('public', sot.visibility)
2424
self.assertIsNone(sot.region)

openstack/tests/unit/messaging/test_version.py renamed to openstack/tests/unit/message/test_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
import testtools
1414

15-
from openstack.messaging import version
15+
from openstack.message import version
1616

1717
IDENTIFIER = 'IDENTIFIER'
1818
EXAMPLE = {

0 commit comments

Comments
 (0)