optimization

ikovalyov · ikovalyov · commit 3af265ceb642 · 2017-12-12T16:32:50.000+01:00
diff --git a/src/Service/Factory/UserManagerFactory.php b/src/Service/Factory/UserManagerFactory.php
@@ -23,7 +23,7 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o
     {        
         $params = $this->getParams($container);
                         
-        return new UserManager(...$params);
+        return $this->createService($params, UserManager::class);
     }
 
     /**
@@ -42,4 +42,14 @@ protected function getParams(ContainerInterface $container)
 
         return [$entityManager, $bcrypt, $userEntityClassName, $roleEntityClassName];
     }
+
+    /**
+     * @param array $params
+     * @param string $requestedName
+     * @return UserManager
+     */
+    protected function createService(array $params, $requestedName)
+    {
+        return new $requestedName(...$params);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o`
`23`	`23`	`{`
`24`	`24`	`$params = $this->getParams($container);`
`25`	`25`
`26`		`- return new UserManager(...$params);`
	`26`	`+ return $this->createService($params, UserManager::class);`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`/**`
`@@ -42,4 +42,14 @@ protected function getParams(ContainerInterface $container)`
`42`	`42`
`43`	`43`	`return [$entityManager, $bcrypt, $userEntityClassName, $roleEntityClassName];`
`44`	`44`	`}`
	`45`	`+`
	`46`	`+ /**`
	`47`	`+ * @param array $params`
	`48`	`+ * @param string $requestedName`
	`49`	`+ * @return UserManager`
	`50`	`+ */`
	`51`	`+ protected function createService(array $params, $requestedName)`
	`52`	`+ {`
	`53`	`+ return new $requestedName(...$params);`
	`54`	`+ }`
`45`	`55`	`}`