fix gcc warnings

cdunn2001 · cdunn2001 · commit 2bc6137ada41 · 2015-01-24T13:42:37.000-06:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -85,10 +85,10 @@ endif( MSVC )
 
 if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
   # using regular Clang or AppleClang
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++11")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -Wall")
 elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
   # using GCC
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -std=c++0x")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x -Wall -Wextra -Wpedantic")
 endif()
 
 IF(JSONCPP_WITH_WARNING_AS_ERROR)
diff --git a/include/json/value.h b/include/json/value.h
@@ -505,10 +505,10 @@ Json::Value obj_value(Json::objectValue); // {}
 #endif
   } value_;
   ValueType type_ : 8;
-  int allocated_ : 1; // Notes: if declared as bool, bitfield is useless.
+  unsigned int allocated_ : 1; // Notes: if declared as bool, bitfield is useless.
 #ifdef JSON_VALUE_USE_INTERNAL_MAP
   unsigned int itemIsUsed_ : 1; // used by the ValueInternalMap container.
-  int memberNameIsStatic_ : 1;  // used by the ValueInternalMap container.
+  unsigned int memberNameIsStatic_ : 1;  // used by the ValueInternalMap container.
 #endif
   CommentInfo* comments_;
 
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -340,7 +340,7 @@ Value::Value(const Value& other)
   case stringValue:
     if (other.value_.string_) {
       value_.string_ = duplicateStringValue(other.value_.string_);
-      allocated_ |= true;
+      allocated_ = true;
     } else {
       value_.string_ = 0;
       allocated_ = false;
diff --git a/src/test_lib_json/jsontest.cpp b/src/test_lib_json/jsontest.cpp
@@ -323,7 +323,7 @@ void Runner::listTests() const {
 }
 
 int Runner::runCommandLine(int argc, const char* argv[]) const {
-  typedef std::deque<std::string> TestNames;
+  // typedef std::deque<std::string> TestNames;
   Runner subrunner;
   for (int index = 1; index < argc; ++index) {
     std::string opt = argv[index];
diff --git a/src/test_lib_json/jsontest.h b/src/test_lib_json/jsontest.h
@@ -214,7 +214,7 @@ TestResult& checkStringEqual(TestResult& result,
 #define JSONTEST_ASSERT_PRED(expr)                                             \
   {                                                                            \
     JsonTest::PredicateContext _minitest_Context = {                           \
-      result_->predicateId_, __FILE__, __LINE__, #expr                         \
+      result_->predicateId_, __FILE__, __LINE__, #expr, nullptr, nullptr       \
     };                                                                         \
     result_->predicateStackTail_->next_ = &_minitest_Context;                  \
     result_->predicateId_ += 1;                                                \

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ void Runner::listTests() const {`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`int Runner::runCommandLine(int argc, const char* argv[]) const {`
`326`		`- typedef std::deque<std::string> TestNames;`
	`326`	`+ // typedef std::deque<std::string> TestNames;`
`327`	`327`	`Runner subrunner;`
`328`	`328`	`for (int index = 1; index < argc; ++index) {`
`329`	`329`	`std::string opt = argv[index];`