Fixed cppcheck-opensource#7058 (Tokenizer::simplifyTypedef: wrong simplification of enum constant 'AB::A' if AB is a struct typedef)

danmar · danmar · commit fe4fac7eb228 · 2015-10-18T04:55:04.000+02:00
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -1201,7 +1201,7 @@ void Tokenizer::simplifyTypedef()
                                     tok2 = tok2->next();
                                 }
                             }
-                        } else if (tok2->tokAt(-2) && Token::Match(tok2->tokAt(-2), "%type% *|&")) {
+                        } else if (Token::Match(tok2->tokAt(-2), "%type% *|&")) {
                             // Ticket #5868: Don't substitute variable names
                         } else if (tok2->previous()->str() != ".") {
                             simplifyType = true;
@@ -1264,6 +1264,8 @@ void Tokenizer::simplifyTypedef()
                             structRemoved = true;
                         typeStart = typeStart->next();
                     }
+                    if (typeStart->str() == "struct" && Token::Match(tok2, "%name% ::"))
+                        typeStart = typeStart->next();
 
                     // start substituting at the typedef name by replacing it with the type
                     tok2->str(typeStart->str());
diff --git a/test/testsimplifytypedef.cpp b/test/testsimplifytypedef.cpp
@@ -150,6 +150,7 @@ class TestSimplifyTypedef : public TestFixture {
         TEST_CASE(simplifyTypedef111); // ticket #6345
         TEST_CASE(simplifyTypedef112); // ticket #6048
         TEST_CASE(simplifyTypedef113); // ticket #7030
+        TEST_CASE(simplifyTypedef114); // ticket #7058 - skip "struct", AB::..
 
         TEST_CASE(simplifyTypedefFunction1);
         TEST_CASE(simplifyTypedefFunction2); // ticket #1685
@@ -2414,6 +2415,13 @@ class TestSimplifyTypedef : public TestFixture {
         ASSERT_EQUALS(expected, tok(code));
     }
 
+    void simplifyTypedef114() {     // ticket #7058
+        const char code[] = "typedef struct { enum {A,B}; } AB;\n"
+                            "x=AB::B;";
+        const char expected[] = "struct AB { } ; x = 1 ;";
+        ASSERT_EQUALS(expected, tok(code));
+    }
+
     void simplifyTypedefFunction1() {
         {
             const char code[] = "typedef void (*my_func)();\n"

Original file line number	Diff line number	Diff line change
`@@ -1201,7 +1201,7 @@ void Tokenizer::simplifyTypedef()`
`1201`	`1201`	`tok2 = tok2->next();`
`1202`	`1202`	`}`
`1203`	`1203`	`}`
`1204`		`- } else if (tok2->tokAt(-2) && Token::Match(tok2->tokAt(-2), "%type% *\|&")) {`
	`1204`	`+ } else if (Token::Match(tok2->tokAt(-2), "%type% *\|&")) {`
`1205`	`1205`	`// Ticket #5868: Don't substitute variable names`
`1206`	`1206`	`} else if (tok2->previous()->str() != ".") {`
`1207`	`1207`	`simplifyType = true;`
`@@ -1264,6 +1264,8 @@ void Tokenizer::simplifyTypedef()`
`1264`	`1264`	`structRemoved = true;`
`1265`	`1265`	`typeStart = typeStart->next();`
`1266`	`1266`	`}`
	`1267`	`+ if (typeStart->str() == "struct" && Token::Match(tok2, "%name% ::"))`
	`1268`	`+ typeStart = typeStart->next();`
`1267`	`1269`
`1268`	`1270`	`// start substituting at the typedef name by replacing it with the type`
`1269`	`1271`	`tok2->str(typeStart->str());`