fix numeric locale

cdunn2001 · cdunn2001 · commit 496c6555239e · 2014-07-10T20:24:23.000-07:00
In some locales (e.g. de_DE) floats have commas instead of dots, but JSON requires dots. See: open-source-parsers#9 open-source-parsers#3
diff --git a/src/lib_json/json_tool.h b/src/lib_json/json_tool.h
@@ -68,6 +68,20 @@ static inline void uintToString(LargestUInt value, char *&current) {
   } while (value != 0);
 }
 
+/** Change ',' to '.' everywhere in buffer.
+ *
+ * We had a sophisticated way, but it did not work in WinCE.
+ * @see https://github.com/open-source-parsers/jsoncpp/pull/9
+ */
+static inline void fixNumericLocale(char* begin, char* end) {
+  while (begin < end) {
+    if (*begin == ',') {
+      *begin = '.';
+    }
+    ++begin;
+  }
+}
+
 } // namespace Json {
 
 #endif // LIB_JSONCPP_JSON_TOOL_H_INCLUDED
diff --git a/src/lib_json/json_writer.cpp b/src/lib_json/json_writer.cpp
@@ -77,7 +77,7 @@ std::string valueToString(double value) {
 #else
   snprintf(buffer, sizeof(buffer), "%.16g", value);
 #endif
-
+  fixNumericLocale(buffer, buffer + strlen(buffer));
   return buffer;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ std::string valueToString(double value) {`
`77`	`77`	`#else`
`78`	`78`	`snprintf(buffer, sizeof(buffer), "%.16g", value);`
`79`	`79`	`#endif`
`80`		`-`
	`80`	`+ fixNumericLocale(buffer, buffer + strlen(buffer));`
`81`	`81`	`return buffer;`
`82`	`82`	`}`
`83`	`83`