Refactor Seeder

pmPaulis · pmPaulis · commit fe089d29f03e · 2024-03-15T17:32:54.000-04:00
diff --git a/ProcessMaker/Models/Setting.php b/ProcessMaker/Models/Setting.php
@@ -425,8 +425,6 @@ function ($settings) use ($id) {
      * Update the group_id related to Settings
      * @param string $settingsGroup
      * @param null|int $id
-     *
-     * @return array
      */
     public static function updateAllSettingsGroupId()
     {
diff --git a/database/seeders/SettingsMenusSeeder.php b/database/seeders/SettingsMenusSeeder.php
@@ -15,32 +15,9 @@ class SettingsMenusSeeder extends Seeder
     public function run()
     {
         // Menu 1. Email SettingsMenus::EMAIL_GROUP_ID = 1
-        SettingsMenus::firstOrCreate([
-            'menu_group' => SettingsMenus::EMAIL_MENU_GROUP
-        ], [
-            'menu_group_order' => SettingsMenus::EMAIL_MENU_ORDER,
-            'ui' => json_encode(["icon" => SettingsMenus::EMAIL_MENU_ICON]),
-        ]);
         // Menu 2. Integrations SettingsMenus::INTEGRATIONS_GROUP_ID = 2
-        SettingsMenus::firstOrCreate([
-            'menu_group' => SettingsMenus::INTEGRATIONS_MENU_GROUP
-        ], [
-            'menu_group_order' => SettingsMenus::INTEGRATIONS_MENU_ORDER,
-            'ui' => json_encode(["icon" => SettingsMenus::INTEGRATIONS_MENU_ICON]),
-        ]);
         // Menu 3. Log-in & Auth SettingsMenus::LOG_IN_AUTH_GROUP_ID = 3
-        SettingsMenus::firstOrCreate([
-            'menu_group' => SettingsMenus::LOG_IN_AUTH_MENU_GROUP
-        ], [
-            'menu_group_order' => SettingsMenus::LOG_IN_AUTH_MENU_ORDER,
-            'ui' => json_encode(["icon" => SettingsMenus::LOG_IN_AUTH_MENU_ICON]),
-        ]);
         // Menu 4. Users Settings SettingsMenus::USER_SETTINGS_GROUP_ID = 4
-        SettingsMenus::firstOrCreate([
-            'menu_group' => SettingsMenus::USER_SETTINGS_MENU_GROUP
-        ], [
-            'menu_group_order' => SettingsMenus::USER_SETTINGS_MENU_ORDER,
-            'ui' => json_encode(["icon" => SettingsMenus::USER_SETTINGS_MENU_ICON]),
-        ]);
+        SettingsMenus::populateSettingMenus();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -425,8 +425,6 @@ function ($settings) use ($id) {`
`425`	`425`	`* Update the group_id related to Settings`
`426`	`426`	`* @param string $settingsGroup`
`427`	`427`	`* @param null\|int $id`
`428`		`- *`
`429`		`- * @return array`
`430`	`428`	`*/`
`431`	`429`	`public static function updateAllSettingsGroupId()`
`432`	`430`	`{`