FOUR-14155 Sonarqube This method has 4 returns, which is more than the 3 allowed.

gproly · gproly · commit f9596bddbd00 · 2024-03-21T18:00:13.000-04:00
diff --git a/ProcessMaker/Filters/Filter.php b/ProcessMaker/Filters/Filter.php
@@ -186,11 +186,7 @@ private function value()
             return $this->value . '%';
         }
 
-        if (is_numeric($this->value)) {
-            return (float) $this->value;
-        }
-
-        return $this->value;
+        return is_numeric($this->value) ? (float) $this->value : $this->value;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -186,11 +186,7 @@ private function value()`
`186`	`186`	`return $this->value . '%';`
`187`	`187`	`}`
`188`	`188`
`189`		`- if (is_numeric($this->value)) {`
`190`		`- return (float) $this->value;`
`191`		`- }`
`192`		`-`
`193`		`- return $this->value;`
	`189`	`+ return is_numeric($this->value) ? (float) $this->value : $this->value;`
`194`	`190`	`}`
`195`	`191`
`196`	`192`	`/**`