fix CR notes

rodriquelca · rodriquelca · commit 6ea80751e3eb · 2025-10-27T21:44:35.000-04:00
diff --git a/ProcessMaker/Providers/PermissionServiceProvider.php b/ProcessMaker/Providers/PermissionServiceProvider.php
@@ -28,15 +28,4 @@ public function register(): void
             );
         });
     }
-
-    /**
-     * Bootstrap services.
-     */
-    public function boot(): void
-    {
-        // Publish configuration if needed
-        // $this->publishes([
-        //     __DIR__.'/../config/permissions.php' => config_path('permissions.php'),
-        // ], 'permissions');
-    }
 }
diff --git a/ProcessMaker/Repositories/PermissionRepository.php b/ProcessMaker/Repositories/PermissionRepository.php
@@ -180,31 +180,6 @@ public function getNestedGroupPermissions(int $groupId): array
         return array_unique($permissions);
     }
 
-    /**
-     * Add category view permissions based on create/edit permissions
-     */
-    private function addCategoryViewPermissions(array $permissions): array
-    {
-        $addFor = [
-            'processes' => 'view-process-categories',
-            'scripts' => 'view-script-categories',
-            'screens' => 'view-screen-categories',
-        ];
-
-        foreach ($addFor as $resource => $categoryPermission) {
-            if (
-                in_array('create-' . $resource, $permissions) ||
-                in_array('edit-' . $resource, $permissions)
-            ) {
-                if (!in_array($categoryPermission, $permissions)) {
-                    $permissions[] = $categoryPermission;
-                }
-            }
-        }
-
-        return $permissions;
-    }
-
     /**
      * Get nested group permissions recursively with protection against infinite loops
      */
diff --git a/ProcessMaker/Traits/HasAuthorization.php b/ProcessMaker/Traits/HasAuthorization.php
@@ -26,11 +26,6 @@ private function getPermissionService(): PermissionServiceManager
 
     public function loadPermissions()
     {
-        // return array_merge(
-        //     $this->loadUserPermissions(),
-        //     $this->loadGroupPermissions()
-        // );
-
         // Use the new optimized service
         return $this->getPermissionService()->getUserPermissions($this->id);
     }
@@ -92,36 +87,10 @@ public function loadPermissionOfGroups(Group $group, array $permissions = [], ar
 
     public function hasPermission($permissionString)
     {
-        // $permissionStrings = $this->loadPermissions();
-        // return in_array($permissionString, $permissionStrings);
         // Use the new optimized service for permission checking
         return $this->getPermissionService()->userHasPermission($this->id, $permissionString);
     }
 
-    /**
-     * Check if user has any of the given permissions
-     */
-    // public function hasAnyPermission(array $permissions): bool
-    // {
-    //     return $this->getPermissionService()->userHasAnyPermission($this->id, $permissions);
-    // }
-
-    /**
-     * Check if user has all of the given permissions
-     */
-    // public function hasAllPermissions(array $permissions): bool
-    // {
-    //     return $this->getPermissionService()->userHasAllPermissions($this->id, $permissions);
-    // }
-
-    /**
-     * Warm up permission cache for this user
-     */
-    // public function warmUpPermissionCache(): void
-    // {
-    //     $this->getPermissionService()->warmUpUserCache($this->id);
-    // }
-
     /**
      * Invalidate permission cache for this user
      */
