Skip to content

Commit fce0036

Browse files
committed
esp8266: mac() function belongs to network module per the latest API.
1 parent 1aa4599 commit fce0036

3 files changed

Lines changed: 22 additions & 22 deletions

File tree

esp8266/modesp.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -538,26 +538,6 @@ STATIC mp_obj_t esp_sleep_type(mp_uint_t n_args, const mp_obj_t *args) {
538538
}
539539
STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(esp_sleep_type_obj, 0, 1, esp_sleep_type);
540540

541-
STATIC mp_obj_t esp_mac(mp_uint_t n_args, const mp_obj_t *args) {
542-
uint8_t mac[6];
543-
if (n_args == 0) {
544-
wifi_get_macaddr(STATION_IF, mac);
545-
return mp_obj_new_bytes(mac, sizeof(mac));
546-
} else {
547-
mp_buffer_info_t bufinfo;
548-
mp_get_buffer_raise(args[0], &bufinfo, MP_BUFFER_READ);
549-
550-
if (bufinfo.len != 6) {
551-
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError,
552-
"invalid buffer length"));
553-
}
554-
555-
wifi_set_macaddr(STATION_IF, bufinfo.buf);
556-
return mp_const_none;
557-
}
558-
}
559-
STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(esp_mac_obj, 0, 1, esp_mac);
560-
561541
STATIC mp_obj_t esp_deepsleep(mp_uint_t n_args, const mp_obj_t *args) {
562542
system_deep_sleep(n_args > 0 ? mp_obj_get_int(args[0]) : 0);
563543
return mp_const_none;
@@ -586,7 +566,6 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_2(esp_flash_read_obj, esp_flash_read);
586566
STATIC const mp_map_elem_t esp_module_globals_table[] = {
587567
{ MP_OBJ_NEW_QSTR(MP_QSTR___name__), MP_OBJ_NEW_QSTR(MP_QSTR_esp) },
588568

589-
{ MP_OBJ_NEW_QSTR(MP_QSTR_mac), (mp_obj_t)&esp_mac_obj },
590569
{ MP_OBJ_NEW_QSTR(MP_QSTR_getaddrinfo), (mp_obj_t)&esp_getaddrinfo_obj },
591570
{ MP_OBJ_NEW_QSTR(MP_QSTR_wifi_mode), (mp_obj_t)&esp_wifi_mode_obj },
592571
{ MP_OBJ_NEW_QSTR(MP_QSTR_phy_mode), (mp_obj_t)&esp_phy_mode_obj },

esp8266/modnetwork.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,26 @@ STATIC mp_obj_t esp_isconnected() {
116116

117117
STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_isconnected_obj, esp_isconnected);
118118

119+
STATIC mp_obj_t esp_mac(mp_uint_t n_args, const mp_obj_t *args) {
120+
uint8_t mac[6];
121+
if (n_args == 0) {
122+
wifi_get_macaddr(STATION_IF, mac);
123+
return mp_obj_new_bytes(mac, sizeof(mac));
124+
} else {
125+
mp_buffer_info_t bufinfo;
126+
mp_get_buffer_raise(args[0], &bufinfo, MP_BUFFER_READ);
127+
128+
if (bufinfo.len != 6) {
129+
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError,
130+
"invalid buffer length"));
131+
}
132+
133+
wifi_set_macaddr(STATION_IF, bufinfo.buf);
134+
return mp_const_none;
135+
}
136+
}
137+
STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(esp_mac_obj, 0, 1, esp_mac);
138+
119139
STATIC const mp_map_elem_t mp_module_network_globals_table[] = {
120140
{ MP_OBJ_NEW_QSTR(MP_QSTR___name__), MP_OBJ_NEW_QSTR(MP_QSTR_network) },
121141
// MicroPython "network" module interface requires it to contains classes
@@ -128,6 +148,7 @@ STATIC const mp_map_elem_t mp_module_network_globals_table[] = {
128148
{ MP_OBJ_NEW_QSTR(MP_QSTR_status), (mp_obj_t)&esp_status_obj },
129149
{ MP_OBJ_NEW_QSTR(MP_QSTR_scan), (mp_obj_t)&esp_scan_obj },
130150
{ MP_OBJ_NEW_QSTR(MP_QSTR_isconnected), (mp_obj_t)&esp_isconnected_obj },
151+
{ MP_OBJ_NEW_QSTR(MP_QSTR_mac), (mp_obj_t)&esp_mac_obj },
131152

132153
#if MODNETWORK_INCLUDE_CONSTANTS
133154
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_IDLE),

esp8266/qstrdefsport.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ Q(chip_id)
6666
Q(flash_id)
6767
Q(flash_read)
6868
Q(sdk_version)
69-
Q(mac)
7069
Q(getaddrinfo)
7170
Q(send)
7271
Q(sendto)
@@ -101,6 +100,7 @@ Q(WLAN)
101100
Q(scan)
102101
Q(status)
103102
Q(isconnected)
103+
Q(mac)
104104
Q(STAT_IDLE)
105105
Q(STAT_CONNECTING)
106106
Q(STAT_WRONG_PASSWORD)

0 commit comments

Comments
 (0)