Skip to content

Commit d29ca28

Browse files
deshipudpgeorge
authored andcommitted
esp8266/modous: Add os.umount method to unmount a filesystem.
This is an object-oriented approach, where uos is only a proxy for the methods on the vfs object. Some internals had to be exposed (the STATIC keyword removed) for this to work. Fixes adafruit#2338.
1 parent b0e2106 commit d29ca28

4 files changed

Lines changed: 15 additions & 1 deletion

File tree

esp8266/moduos.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@ STATIC mp_obj_t os_rename(mp_obj_t path_old, mp_obj_t path_new) {
123123
}
124124
STATIC MP_DEFINE_CONST_FUN_OBJ_2(os_rename_obj, os_rename);
125125

126+
STATIC mp_obj_t os_umount(void) {
127+
return vfs_proxy_call(MP_QSTR_umount, 0, NULL);
128+
}
129+
STATIC MP_DEFINE_CONST_FUN_OBJ_0(os_umount_obj, os_umount);
126130
#endif
127131

128132
STATIC mp_obj_t os_urandom(mp_obj_t num) {
@@ -166,6 +170,7 @@ STATIC const mp_rom_map_elem_t os_module_globals_table[] = {
166170
{ MP_ROM_QSTR(MP_QSTR_remove), MP_ROM_PTR(&os_remove_obj) },
167171
{ MP_ROM_QSTR(MP_QSTR_rename), MP_ROM_PTR(&os_rename_obj) },
168172
{ MP_ROM_QSTR(MP_QSTR_stat), MP_ROM_PTR(&os_stat_obj) },
173+
{ MP_ROM_QSTR(MP_QSTR_umount), MP_ROM_PTR(&os_umount_obj) },
169174
#endif
170175
};
171176

extmod/fsusermount.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ STATIC mp_obj_t fatfs_mount(size_t n_args, const mp_obj_t *pos_args, mp_map_t *k
162162
}
163163
MP_DEFINE_CONST_FUN_OBJ_KW(fsuser_mount_obj, 2, fatfs_mount);
164164

165-
STATIC mp_obj_t fatfs_umount(mp_obj_t bdev_or_path_in) {
165+
mp_obj_t fatfs_umount(mp_obj_t bdev_or_path_in) {
166166
size_t i = 0;
167167
if (MP_OBJ_IS_STR(bdev_or_path_in)) {
168168
mp_uint_t mnt_len;

extmod/fsusermount.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ typedef struct _fs_user_mount_t {
5555
} fs_user_mount_t;
5656

5757
fs_user_mount_t *fatfs_mount_mkfs(mp_uint_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args, bool mkfs);
58+
mp_obj_t fatfs_umount(mp_obj_t bdev_or_path_in);
5859

5960
MP_DECLARE_CONST_FUN_OBJ(fsuser_mount_obj);
6061
MP_DECLARE_CONST_FUN_OBJ(fsuser_umount_obj);

extmod/vfs_fat.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,13 @@ STATIC mp_obj_t fat_vfs_stat(mp_obj_t vfs_in, mp_obj_t path_in) {
250250
}
251251
STATIC MP_DEFINE_CONST_FUN_OBJ_2(fat_vfs_stat_obj, fat_vfs_stat);
252252

253+
// Unmount the filesystem
254+
STATIC mp_obj_t fat_vfs_umount(mp_obj_t vfs_in) {
255+
fatfs_umount(((fs_user_mount_t *)vfs_in)->readblocks[1]);
256+
return mp_const_none;
257+
}
258+
STATIC MP_DEFINE_CONST_FUN_OBJ_1(fat_vfs_umount_obj, fat_vfs_umount);
259+
253260
STATIC const mp_rom_map_elem_t fat_vfs_locals_dict_table[] = {
254261
{ MP_ROM_QSTR(MP_QSTR_mkfs), MP_ROM_PTR(&fat_vfs_mkfs_obj) },
255262
{ MP_ROM_QSTR(MP_QSTR_open), MP_ROM_PTR(&fat_vfs_open_obj) },
@@ -261,6 +268,7 @@ STATIC const mp_rom_map_elem_t fat_vfs_locals_dict_table[] = {
261268
{ MP_ROM_QSTR(MP_QSTR_remove), MP_ROM_PTR(&fat_vfs_remove_obj) },
262269
{ MP_ROM_QSTR(MP_QSTR_rename), MP_ROM_PTR(&fat_vfs_rename_obj) },
263270
{ MP_ROM_QSTR(MP_QSTR_stat), MP_ROM_PTR(&fat_vfs_stat_obj) },
271+
{ MP_ROM_QSTR(MP_QSTR_umount), MP_ROM_PTR(&fat_vfs_umount_obj) },
264272
};
265273
STATIC MP_DEFINE_CONST_DICT(fat_vfs_locals_dict, fat_vfs_locals_dict_table);
266274

0 commit comments

Comments
 (0)