objstr: Add TODO-optimize for using .join with arbitrary iterable.

pfalcon · pfalcon · commit 881d9af05e7a · 2014-04-10T01:42:40.000+03:00
diff --git a/py/objstr.c b/py/objstr.c
@@ -330,6 +330,7 @@ STATIC mp_obj_t str_join(mp_obj_t self_in, mp_obj_t arg) {
     } else {
         if (!MP_OBJ_IS_TYPE(arg, &mp_type_list)) {
             // arg is not a list, try to convert it to one
+            // TODO: Try to optimize?
             arg = mp_type_list.make_new((mp_obj_t)&mp_type_list, 1, 0, &arg);
         }
         mp_obj_list_get(arg, &seq_len, &seq_items);

Original file line number	Diff line number	Diff line change
`@@ -330,6 +330,7 @@ STATIC mp_obj_t str_join(mp_obj_t self_in, mp_obj_t arg) {`
`330`	`330`	`} else {`
`331`	`331`	`if (!MP_OBJ_IS_TYPE(arg, &mp_type_list)) {`
`332`	`332`	`// arg is not a list, try to convert it to one`
	`333`	`+ // TODO: Try to optimize?`
`333`	`334`	`arg = mp_type_list.make_new((mp_obj_t)&mp_type_list, 1, 0, &arg);`
`334`	`335`	`}`
`335`	`336`	`mp_obj_list_get(arg, &seq_len, &seq_items);`