protomatter: more memory allocation fixes

jepler · jepler · commit 3a94412cd35c · 2020-04-14T18:24:58.000-05:00
- bump supervisor alloc count by 4 (we actually use 5)
 - move reconstruct to after gc heap is reset
 - destroy protomatter object entirely if not used by a FramebufferDisplay
 - ensure previous supervisor allocations are released
 - zero out pointers so GC can collect them
diff --git a/shared-module/_protomatter/Protomatter.c b/shared-module/_protomatter/Protomatter.c
@@ -78,6 +78,11 @@ void common_hal_protomatter_protomatter_reconstruct(protomatter_protomatter_obj_
         // verify that the matrix is big enough
         mp_get_index(mp_obj_get_type(self->framebuffer), self->bufinfo.len, MP_OBJ_NEW_SMALL_INT(self->bufsize-1), false);
     } else {
+        _PM_FREE(self->bufinfo.buf);
+        _PM_FREE(self->core.rgbPins);
+        _PM_FREE(self->core.addr);
+        _PM_FREE(self->core.screenData);
+
         self->framebuffer = NULL;
         self->bufinfo.buf = _PM_allocator_impl(self->bufsize);
         self->bufinfo.len = self->bufsize;
@@ -156,6 +161,7 @@ void common_hal_protomatter_protomatter_deinit(protomatter_protomatter_obj_t* se
     if (self->core.rgbPins) {
         _PM_free(&self->core);
     }
+    memset(&self->core, 0, sizeof(self->core));
 
     self->base.type = NULL;
 }
diff --git a/shared-module/_protomatter/allocator.h b/shared-module/_protomatter/allocator.h
@@ -6,7 +6,7 @@
 #include "supervisor/memory.h"
 
 #define _PM_ALLOCATOR _PM_allocator_impl
-#define _PM_FREE _PM_free_impl
+#define _PM_FREE(x) (_PM_free_impl((x)), (x)=NULL, (void)0)
 
 static inline void *_PM_allocator_impl(size_t sz) {
     supervisor_allocation *allocation = allocate_memory(align32_size(sz), true);    
@@ -22,8 +22,6 @@ static inline void _PM_free_impl(void *ptr_in) {
     
     if (allocation) {
         free_memory(allocation);
-    } else {
-        m_free(ptr_in);
     }
 }
 
diff --git a/shared-module/displayio/__init__.c b/shared-module/displayio/__init__.c
@@ -21,6 +21,18 @@
 
 primary_display_t displays[CIRCUITPY_DISPLAY_LIMIT];
 
+STATIC bool any_display_uses_this_protomatter(protomatter_protomatter_obj_t* pm) {
+    for (uint8_t i = 0; i < CIRCUITPY_DISPLAY_LIMIT; i++) {
+        if (displays[i].framebuffer_display.base.type == &framebufferio_framebufferdisplay_type) {
+            framebufferio_framebufferdisplay_obj_t* display = &displays[i].framebuffer_display;
+            if (display->framebuffer == pm) {
+                return true;
+            }
+        }
+    }
+    return false;
+}
+
 // Check for recursive calls to displayio_background.
 bool displayio_background_in_progress = false;
 
@@ -152,7 +164,9 @@ void reset_displays(void) {
 #if CIRCUITPY_PROTOMATTER
         } else if (displays[i].protomatter.base.type == &protomatter_Protomatter_type) {
             protomatter_protomatter_obj_t * pm = &displays[i].protomatter;
-            common_hal_protomatter_protomatter_reconstruct(pm, NULL);
+            if(!any_display_uses_this_protomatter(pm)) {
+                common_hal_protomatter_protomatter_deinit(pm);
+            }
 #endif
         } else {
             // Not an active display bus.
diff --git a/supervisor/shared/display.c b/supervisor/shared/display.c
@@ -29,6 +29,7 @@
 #include <string.h>
 
 #include "py/mpstate.h"
+#include "shared-module/displayio/__init__.h"
 #include "shared-bindings/displayio/Group.h"
 #include "shared-bindings/displayio/Palette.h"
 #include "shared-bindings/displayio/TileGrid.h"
@@ -112,6 +113,14 @@ void supervisor_display_move_memory(void) {
         grid->inline_tiles = false;
     }
     MP_STATE_VM(terminal_tilegrid_tiles) = NULL;
+    #if CIRCUITPY_PROTOMATTER
+    for (uint8_t i = 0; i < CIRCUITPY_DISPLAY_LIMIT; i++) {
+        if (displays[i].protomatter.base.type == &protomatter_Protomatter_type) {
+            protomatter_protomatter_obj_t * pm = &displays[i].protomatter;
+                common_hal_protomatter_protomatter_reconstruct(pm, NULL);
+        }
+    }
+    #endif
     #endif
 }
 
diff --git a/supervisor/shared/memory.c b/supervisor/shared/memory.c
@@ -31,7 +31,7 @@
 
 #include "supervisor/shared/display.h"
 
-#define CIRCUITPY_SUPERVISOR_ALLOC_COUNT 8
+#define CIRCUITPY_SUPERVISOR_ALLOC_COUNT (12)
 
 static supervisor_allocation allocations[CIRCUITPY_SUPERVISOR_ALLOC_COUNT];
 // We use uint32_t* to ensure word (4 byte) alignment.

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`#include "supervisor/memory.h"`
`7`	`7`
`8`	`8`	`#define _PM_ALLOCATOR _PM_allocator_impl`
`9`		`-#define _PM_FREE _PM_free_impl`
	`9`	`+#define _PM_FREE(x) (_PM_free_impl((x)), (x)=NULL, (void)0)`
`10`	`10`
`11`	`11`	`static inline void *_PM_allocator_impl(size_t sz) {`
`12`	`12`	`supervisor_allocation *allocation = allocate_memory(align32_size(sz), true);`
`@@ -22,8 +22,6 @@ static inline void _PM_free_impl(void *ptr_in) {`
`22`	`22`
`23`	`23`	`if (allocation) {`
`24`	`24`	`free_memory(allocation);`
`25`		`- } else {`
`26`		`- m_free(ptr_in);`
`27`	`25`	`}`
`28`	`26`	`}`
`29`	`27`