Repository navigation
Fix: hook extra content issues with multi shipment - #41298
Merged
Quetzacoalt91 merged 1 commit intoJun 15, 2026
Merged
Quetzacoalt91 merged 1 commit into
Quetzacoalt91 merged 1 commit into
Conversation
|
Hi, thanks for this contribution! Please consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
Nakahiru
marked this pull request as ready for review
May 4, 2026 13:41
Hlavtox
reviewed
May 4, 2026
Quetzacoalt91
approved these changes
Jun 10, 2026
ingridusta
approved these changes
Jun 15, 2026
ingridusta
left a comment
There was a problem hiding this comment.
Hi @Nakahiru,
With your PR, the optional fields using displaycarrierExtraContent are displayed :
And no problem to place orders :
With 1 carrier :
Enregistrement.de.l.ecran.2026-06-15.a.13.08.13.mov
With several carriers :
Enregistrement.de.l.ecran.2026-06-15.a.13.08.59.mov
displaycarrierExtraContent as my shop ain't exposed
It's QA approved ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carrierExtraContentwas call. Firstly, the filter on if the carrier belongs to a module was not present. Secondly, the second argument in the exec() method of the hook was wrong. Finally there was also a typing issue. This was causing error in front office from all shipping modules that use the hookcarrierExtraContent. @Progi1984 This should fix the issue on ui tests with the modulepsshipping😌