From 081f3d5ed4de4f47dde15f2a0b07cba7f337a285 Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Sat, 12 Aug 2017 12:50:26 -0700 Subject: [PATCH 1/5] Initial draft of codeowners based on --- .github/CODEOWNERS | 77 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 77 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 00000000000..1331c460504 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,77 @@ +# https://help.github.com/articles/about-codeowners/ + +# Areas are not limited to the filters defined in this file +# First Lets start with areas with no filters or paths + +# Area: Performance +# @lzybkr @steveL-MSFT @adityapatwardhan + +# Area: Portability +# @BrucePay @JamesWTruher @steveL-MSFT + +# Area: Security +# @travisez13 @leeholmes @steveL-MSFT @PaulHigin @chunqingchen + +# Now Areas that should have paths or filters, although we might not have them defined +# Order here must be by precedence of the filter +# Area: Documentation +*.md @joeyaiello @travisez13 @steveL-MSFT + +# Area: Test +test/ @JamesWTruher @travisez13 @steveL-MSFT @adityapatwardhan + +# Area: Cmdlets Core +# @JamesWTruher @steveL-MSFT @anmenaga @chunqingchen + +# Area: CmdLets Management +src/Microsoft.PowerShell.Commands.Management/ @daxian-dbw @steveL-MSFT @adityapatwardhan + +# Area: CmdLets Utility +src/Microsoft.PowerShell.Commands.Utility/ @JamesWTruher @dantraMSFT @PaulHigin + +# Area: Console +src/Microsoft.PowerShell.ConsoleHost/ @daxian-dbw @lzybkr @steveL-MSFT @anmenaga + +# Area: Demo +demos/ @joeyaiello @steveL-MSFT @HemantMahawar + +# Area: DSC +src/System.Management.Automation/DscSupport @travisez13 @steveL-MSFT + +# Area: engine +src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT + +# Area: Debugging +# Must be below engine to override +src/System.Management.Automation/engine/debugger/ @BrucePay @steveL-MSFT @dantraMSFT @PaulHigin + +# Area: help +src/System.Management.Automation/help @steveL-MSFT @Francisco-Gamino @adityapatwardhan + +# Area: Intellisense +# @daxian-dbw @lzybkr @steveL-MSFT @charub + +# Area: Language +# daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT + +# Area: Providers +src/System.Management.Automation/namespaces @BrucePay @steveL-MSFT @anmenaga + +# Area: PSReadLine +src/Microsoft.PowerShell.PSReadLine @lzybkr @steveL-MSFT @charub + +# Area: Remoting +src/System.Management.Automation/engine/remoting @steveL-MSFT @dantraMSFT @mirichmo @PaulHigin + +# Area: Side-By-Side +# @steveL-MSFT @mirichmo @charub + +# Areas: Build +# Must be last +*.config @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +*.props @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +*.yml @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +*.csproj @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +build.* @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +tools/ @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +docker/ @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan From 3d76267fed8fe21642324c7eb70a9dd4b0a0eecb Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Sun, 13 Aug 2017 07:50:50 -0700 Subject: [PATCH 2/5] Address PR feedback --- .github/CODEOWNERS | 52 +++++++++++++++++++++++----------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1331c460504..0f3395fbaa1 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,74 +4,74 @@ # First Lets start with areas with no filters or paths # Area: Performance -# @lzybkr @steveL-MSFT @adityapatwardhan +# @lzybkr @SteveL-MSFT @adityapatwardhan # Area: Portability -# @BrucePay @JamesWTruher @steveL-MSFT +# @BrucePay @JamesWTruher @SteveL-MSFT # Area: Security -# @travisez13 @leeholmes @steveL-MSFT @PaulHigin @chunqingchen +# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen # Now Areas that should have paths or filters, although we might not have them defined # Order here must be by precedence of the filter # Area: Documentation -*.md @joeyaiello @travisez13 @steveL-MSFT +*.md @joeyaiello @TravisEz13 @SteveL-MSFT # Area: Test -test/ @JamesWTruher @travisez13 @steveL-MSFT @adityapatwardhan +test/ @JamesWTruher @TravisEz13 @SteveL-MSFT @adityapatwardhan # Area: Cmdlets Core -# @JamesWTruher @steveL-MSFT @anmenaga @chunqingchen +# @JamesWTruher @SteveL-MSFT @anmenaga @chunqingchen # Area: CmdLets Management -src/Microsoft.PowerShell.Commands.Management/ @daxian-dbw @steveL-MSFT @adityapatwardhan +src/Microsoft.PowerShell.Commands.Management/ @daxian-dbw @SteveL-MSFT @adityapatwardhan # Area: CmdLets Utility src/Microsoft.PowerShell.Commands.Utility/ @JamesWTruher @dantraMSFT @PaulHigin # Area: Console -src/Microsoft.PowerShell.ConsoleHost/ @daxian-dbw @lzybkr @steveL-MSFT @anmenaga +src/Microsoft.PowerShell.ConsoleHost/ @daxian-dbw @lzybkr @SteveL-MSFT @anmenaga # Area: Demo -demos/ @joeyaiello @steveL-MSFT @HemantMahawar +demos/ @joeyaiello @SteveL-MSFT @HemantMahawar # Area: DSC -src/System.Management.Automation/DscSupport @travisez13 @steveL-MSFT +src/System.Management.Automation/DscSupport @TravisEz13 @SteveL-MSFT # Area: engine -src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT +src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @BrucePay @SteveL-MSFT # Area: Debugging # Must be below engine to override -src/System.Management.Automation/engine/debugger/ @BrucePay @steveL-MSFT @dantraMSFT @PaulHigin +src/System.Management.Automation/engine/debugger/ @BrucePay @SteveL-MSFT @dantraMSFT @PaulHigin # Area: help -src/System.Management.Automation/help @steveL-MSFT @Francisco-Gamino @adityapatwardhan +src/System.Management.Automation/help @SteveL-MSFT @Francisco-Gamino @adityapatwardhan # Area: Intellisense -# @daxian-dbw @lzybkr @steveL-MSFT @charub +# @daxian-dbw @lzybkr @SteveL-MSFT @charub # Area: Language -# daxian-dbw @vors @lzybkr @BrucePay @steveL-MSFT +# @daxian-dbw @vors @lzybkr @BrucePay @SteveL-MSFT # Area: Providers -src/System.Management.Automation/namespaces @BrucePay @steveL-MSFT @anmenaga +src/System.Management.Automation/namespaces @BrucePay @SteveL-MSFT @anmenaga # Area: PSReadLine -src/Microsoft.PowerShell.PSReadLine @lzybkr @steveL-MSFT @charub +src/Microsoft.PowerShell.PSReadLine @lzybkr @SteveL-MSFT @charub # Area: Remoting -src/System.Management.Automation/engine/remoting @steveL-MSFT @dantraMSFT @mirichmo @PaulHigin +src/System.Management.Automation/engine/remoting @SteveL-MSFT @dantraMSFT @mirichmo @PaulHigin # Area: Side-By-Side -# @steveL-MSFT @mirichmo @charub +# @SteveL-MSFT @mirichmo @charub # Areas: Build # Must be last -*.config @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan -*.props @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan -*.yml @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan -*.csproj @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan -build.* @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan -tools/ @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan -docker/ @daxian-dbw @travisez13 @steveL-MSFT @adityapatwardhan +*.config @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +*.props @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +*.yml @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +*.csproj @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +build.* @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +tools/ @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +docker/ @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan From 82a05b7c0a593bd94e5141d8e82df7bf49c6e04a Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 14 Aug 2017 08:08:22 -0700 Subject: [PATCH 3/5] remove @SteveL-MSFT from everywhere except demos --- .github/CODEOWNERS | 58 +++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 0f3395fbaa1..f3615a8f941 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -4,74 +4,74 @@ # First Lets start with areas with no filters or paths # Area: Performance -# @lzybkr @SteveL-MSFT @adityapatwardhan +# @lzybkr @adityapatwardhan # Area: Portability -# @BrucePay @JamesWTruher @SteveL-MSFT +# @BrucePay @JamesWTruher # Area: Security -# @TravisEz13 @leeholmes @SteveL-MSFT @PaulHigin @chunqingchen +# @TravisEz13 @leeholmes @PaulHigin @chunqingchen # Now Areas that should have paths or filters, although we might not have them defined # Order here must be by precedence of the filter -# Area: Documentation -*.md @joeyaiello @TravisEz13 @SteveL-MSFT +# Area: Documentation +*.md @joeyaiello @TravisEz13 # Area: Test -test/ @JamesWTruher @TravisEz13 @SteveL-MSFT @adityapatwardhan +test/ @JamesWTruher @TravisEz13 @adityapatwardhan # Area: Cmdlets Core # @JamesWTruher @SteveL-MSFT @anmenaga @chunqingchen # Area: CmdLets Management -src/Microsoft.PowerShell.Commands.Management/ @daxian-dbw @SteveL-MSFT @adityapatwardhan - -# Area: CmdLets Utility +src/Microsoft.PowerShell.Commands.Management/ @daxian-dbw @adityapatwardhan + +# Area: CmdLets Utility src/Microsoft.PowerShell.Commands.Utility/ @JamesWTruher @dantraMSFT @PaulHigin - -# Area: Console -src/Microsoft.PowerShell.ConsoleHost/ @daxian-dbw @lzybkr @SteveL-MSFT @anmenaga + +# Area: Console +src/Microsoft.PowerShell.ConsoleHost/ @daxian-dbw @lzybkr @anmenaga # Area: Demo demos/ @joeyaiello @SteveL-MSFT @HemantMahawar # Area: DSC -src/System.Management.Automation/DscSupport @TravisEz13 @SteveL-MSFT +src/System.Management.Automation/DscSupport @TravisEz13 # Area: engine -src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @BrucePay @SteveL-MSFT +src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @BrucePay # Area: Debugging # Must be below engine to override -src/System.Management.Automation/engine/debugger/ @BrucePay @SteveL-MSFT @dantraMSFT @PaulHigin +src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin # Area: help -src/System.Management.Automation/help @SteveL-MSFT @Francisco-Gamino @adityapatwardhan +src/System.Management.Automation/help @@Francisco-Gamino @adityapatwardhan # Area: Intellisense -# @daxian-dbw @lzybkr @SteveL-MSFT @charub +# @daxian-dbw @lzybkr @charub # Area: Language -# @daxian-dbw @vors @lzybkr @BrucePay @SteveL-MSFT +# @daxian-dbw @vors @lzybkr @BrucePay # Area: Providers -src/System.Management.Automation/namespaces @BrucePay @SteveL-MSFT @anmenaga +src/System.Management.Automation/namespaces @BrucePay @anmenaga # Area: PSReadLine -src/Microsoft.PowerShell.PSReadLine @lzybkr @SteveL-MSFT @charub +src/Microsoft.PowerShell.PSReadLine @lzybkr @charub # Area: Remoting -src/System.Management.Automation/engine/remoting @SteveL-MSFT @dantraMSFT @mirichmo @PaulHigin +src/System.Management.Automation/engine/remoting @dantraMSFT @mirichmo @PaulHigin # Area: Side-By-Side -# @SteveL-MSFT @mirichmo @charub +# @mirichmo @charub # Areas: Build # Must be last -*.config @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan -*.props @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan -*.yml @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan -*.csproj @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan -build.* @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan -tools/ @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan -docker/ @daxian-dbw @TravisEz13 @SteveL-MSFT @adityapatwardhan +*.config @daxian-dbw @TravisEz13 @adityapatwardhan +*.props @daxian-dbw @TravisEz13 @adityapatwardhan +*.yml @daxian-dbw @TravisEz13 @adityapatwardhan +*.csproj @daxian-dbw @TravisEz13 @adityapatwardhan +build.* @daxian-dbw @TravisEz13 @adityapatwardhan +tools/ @daxian-dbw @TravisEz13 @adityapatwardhan +docker/ @daxian-dbw @TravisEz13 @adityapatwardhan From eb512d5d5dca272c4b9594e8ea80eb5310af811c Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 14 Aug 2017 15:46:35 -0700 Subject: [PATCH 4/5] Address PR Feedback --- .github/CODEOWNERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f3615a8f941..08e1bf0d726 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -10,7 +10,7 @@ # @BrucePay @JamesWTruher # Area: Security -# @TravisEz13 @leeholmes @PaulHigin @chunqingchen +# @TravisEz13 @PaulHigin @chunqingchen # Now Areas that should have paths or filters, although we might not have them defined # Order here must be by precedence of the filter @@ -43,10 +43,10 @@ src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @Br # Area: Debugging # Must be below engine to override -src/System.Management.Automation/engine/debugger/ @BrucePay@dantraMSFT @PaulHigin +src/System.Management.Automation/engine/debugger/ @BrucePay @dantraMSFT @PaulHigin # Area: help -src/System.Management.Automation/help @@Francisco-Gamino @adityapatwardhan +src/System.Management.Automation/help @Francisco-Gamino @adityapatwardhan # Area: Intellisense # @daxian-dbw @lzybkr @charub From 74ab03d93fc7078719293cb5afd582ec2b64068b Mon Sep 17 00:00:00 2001 From: Travis Plunk Date: Mon, 14 Aug 2017 17:32:09 -0700 Subject: [PATCH 5/5] Add dantraMSFT to DSC --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 08e1bf0d726..9726107fb9a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -36,7 +36,7 @@ src/Microsoft.PowerShell.ConsoleHost/ @daxian-dbw @lzybkr @anmenaga demos/ @joeyaiello @SteveL-MSFT @HemantMahawar # Area: DSC -src/System.Management.Automation/DscSupport @TravisEz13 +src/System.Management.Automation/DscSupport @TravisEz13 @dantraMSFT # Area: engine src/System.Management.Automation/engine @daxian-dbw @vors @lzybkr @BrucePay