Skip to content

Respect explicit false for CSV UseCulture #27514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KirtiRamchandani wants to merge 2 commits into
base: master
Choose a base branch
from
+92 −6
Open

Respect explicit false for CSV UseCulture #27514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aee3c92
Respect explicit false for CSV UseCulture
KirtiRamchandani May 24, 2026
f3acfeb
Use non-comma culture in CSV UseCulture tests
KirtiRamchandani May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/CsvCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1787,12 +1787,9 @@ internal static char SetDelimiter(PSCmdlet cmdlet, string parameterSetName, char
case "UseCulture":
case "CulturePath":
case "CultureLiteralPath":
if (useCulture)
{
// ListSeparator is apparently always a character even though the property returns a string, checked via:
// [CultureInfo]::GetCultures("AllCultures") | % { ([CultureInfo]($_.Name)).TextInfo.ListSeparator } | ? Length -ne 1
delimiter = CultureInfo.CurrentCulture.TextInfo.ListSeparator[0];
}
// ListSeparator is apparently always a character even though the property returns a string, checked via:
// [CultureInfo]::GetCultures("AllCultures") | % { ([CultureInfo]($_.Name)).TextInfo.ListSeparator } | ? Length -ne 1
delimiter = useCulture ? CultureInfo.CurrentCulture.TextInfo.ListSeparator[0] : ImportExportCSVHelper.CSVDelimiter;

break;
default:
Expand Down
21 changes: 21 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertFrom-Csv.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,27 @@ a,b,c
$actualLength | Should -Be 3
}

It "Uses the default delimiter when -UseCulture is explicitly false" {
$originalCulture = [System.Threading.Thread]::CurrentThread.CurrentCulture
$originalUICulture = [System.Threading.Thread]::CurrentThread.CurrentUICulture

try {
[System.Threading.Thread]::CurrentThread.CurrentCulture = [CultureInfo]'de-DE'
[System.Threading.Thread]::CurrentThread.CurrentUICulture = [CultureInfo]'de-DE'
[CultureInfo]::CurrentCulture.TextInfo.ListSeparator | Should -Not -BeExactly ','

$actualData = $testColumns | ConvertFrom-Csv -UseCulture:$false

$actualData.a | Should -Be 1
$actualData.b | Should -Be 2
$actualData.c | Should -Be 3
}
finally {
[System.Threading.Thread]::CurrentThread.CurrentCulture = $originalCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $originalUICulture
}
}

It "Should Contain the Imported Type data" {
$actualData = $testTypeData | ConvertFrom-Csv
$actualData.PSObject.TypeNames.Count | Should -Be 2
Expand Down
21 changes: 21 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/ConvertTo-Csv.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,27 @@ Describe "ConvertTo-Csv DRT Unit Tests" -Tags "CI" {
$returnObject[2] | Should -BeExactly "`"1`"$($delimiter)`"2`""
}

It "Uses the default delimiter when -UseCulture is explicitly false" {
$originalCulture = [System.Threading.Thread]::CurrentThread.CurrentCulture
$originalUICulture = [System.Threading.Thread]::CurrentThread.CurrentUICulture

try {
[System.Threading.Thread]::CurrentThread.CurrentCulture = [CultureInfo]'de-DE'
[System.Threading.Thread]::CurrentThread.CurrentUICulture = [CultureInfo]'de-DE'
[CultureInfo]::CurrentCulture.TextInfo.ListSeparator | Should -Not -BeExactly ','

$returnObject = $inputObject | ConvertTo-Csv -UseCulture:$false -IncludeTypeInformation
$returnObject.Count | Should -Be 3
$returnObject[0] | Should -BeExactly "#TYPE System.Management.Automation.PSCustomObject"
$returnObject[1] | Should -BeExactly "`"First`",`"Second`""
$returnObject[2] | Should -BeExactly "`"1`",`"2`""
}
finally {
[System.Threading.Thread]::CurrentThread.CurrentCulture = $originalCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $originalUICulture
}
}

It "Test convertto-csv with Delimiter" {
$returnObject = $inputObject | ConvertTo-Csv -Delimiter ";" -IncludeTypeInformation
$returnObject.Count | Should -Be 3
Expand Down
27 changes: 27 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,33 @@ Describe "Export-Csv" -Tags "CI" {
$results[0] | Should -BeExactly "#TYPE System.String"
}

It "Uses the default delimiter when -UseCulture is explicitly false" {
$originalCulture = [System.Threading.Thread]::CurrentThread.CurrentCulture
$originalUICulture = [System.Threading.Thread]::CurrentThread.CurrentUICulture

try {
[System.Threading.Thread]::CurrentThread.CurrentCulture = [CultureInfo]'de-DE'
[System.Threading.Thread]::CurrentThread.CurrentUICulture = [CultureInfo]'de-DE'
[CultureInfo]::CurrentCulture.TextInfo.ListSeparator | Should -Not -BeExactly ','

$P1 | Export-Csv -Path $testCsv -UseCulture:$false
$results = Get-Content -Path $testCsv

$results[0] | Should -BeExactly '"P1"'
$results[1] | Should -BeExactly '"first"'

[pscustomobject]@{ H1 = 'V1'; H2 = 'V2' } | Export-Csv -Path $testCsv -UseCulture:$false
$results = Get-Content -Path $testCsv

$results[0] | Should -BeExactly '"H1","H2"'
$results[1] | Should -BeExactly '"V1","V2"'
}
finally {
[System.Threading.Thread]::CurrentThread.CurrentCulture = $originalCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $originalUICulture
}
}

It "Should support -LiteralPath parameter" {
$testObject | Export-Csv -LiteralPath $testCsv
$results = Import-Csv -Path $testCsv
Expand Down
20 changes: 20 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Import-Csv.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,26 @@ Describe "Import-Csv DRT Unit Tests" -Tags "CI" {
$returnObject.First | Should -Be 1
$returnObject.Second | Should -Be 2
}

It "Uses the default delimiter when -UseCulture is explicitly false" {
$originalCulture = [System.Threading.Thread]::CurrentThread.CurrentCulture
$originalUICulture = [System.Threading.Thread]::CurrentThread.CurrentUICulture

try {
[System.Threading.Thread]::CurrentThread.CurrentCulture = [CultureInfo]'de-DE'
[System.Threading.Thread]::CurrentThread.CurrentUICulture = [CultureInfo]'de-DE'
[CultureInfo]::CurrentCulture.TextInfo.ListSeparator | Should -Not -BeExactly ','

$psObject | Export-Csv -Path $fileToGenerate
$returnObject = Import-Csv -Path $fileToGenerate -UseCulture:$false
$returnObject.First | Should -Be 1
$returnObject.Second | Should -Be 2
}
finally {
[System.Threading.Thread]::CurrentThread.CurrentCulture = $originalCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $originalUICulture
}
}
}

Describe "Import-Csv Double Quote Delimiter" -Tags "CI" {
Expand Down