Avoid mutable ChildJobs enumeration in PSTaskJob#27510
Closed
KirtiRamchandani wants to merge 1 commit into
Closed
Conversation
Author
|
Closing in favor of replacement draft PR from neutral branch: #27512 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Avoids an unhandled process-terminating exception when
PSTaskJob.ChildJobsis mutated while aForEach-Object -Parallel -AsJobjob is starting.PR Context
Fix #26160.
PSTaskJob.Start()currently enumerates the publicChildJobslist on a ThreadPool callback. That list is externally mutable, so removing an item can invalidate the enumerator and let the exception escape the ThreadPool callback. This change keeps an internal list ofPSTaskChildJobobjects for scheduler/state enumeration while preserving the existing publicChildJobslist for compatibility.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerValidation
Start-PSBuild -Clean -PSModuleRestore -UseNuGetOrgbuiltpwsh.exe. The Windows PowerShell 5.1 build wrapper emitted post-buildConvertFrom-Json -Depthcompatibility warnings after build output was produced.Start-PSPester -Path test/powershell/Modules/Microsoft.PowerShell.Utility/Foreach-Object-Parallel.Tests.ps1 -UseNuGetOrg -ThrowOnFailure -Terse -SkipTestToolBuildpassed: 62 passed, 0 failed.