[release/v7.6.2] Externalize findMissingNotices target framework selection with ordered Windows fallback#27424
Merged
daxian-dbw merged 2 commits intoMay 13, 2026
Conversation
…red Windows fallback (PowerShell#27269) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports the config-driven target framework selection for findMissingNotices.ps1 into the release branch, replacing hard-coded TFMs with a repo-tracked JSON config and adding Windows target fallback logic.
Changes:
- Adds
tools/findMissingNotices.targets.jsonwith the release branch base TFM. - Loads and validates the target framework config at script startup.
- Updates Windows target selection to inspect restored assets and choose configured candidates before falling back.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tools/findMissingNotices.targets.json |
Adds external TFM configuration for notice-generation tooling. |
tools/findMissingNotices.ps1 |
Replaces hard-coded TFMs with config-driven target selection and Windows fallback behavior. |
daxian-dbw
commented
May 13, 2026
SeeminglyScience
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27269 to release/v7.6.2
Triggered by @daxian-dbw on behalf of @app/copilot-swe-agent
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Externalizes the target framework selection in findMissingNotices.ps1 from hardcoded values to a JSON config file (findMissingNotices.targets.json). Improves maintainability and makes TFM updates easier without script changes.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Validated by the original PR. The conflict was resolved by correctly setting the dotnetTargetName in findMissingNotices.targets.json to net10.0 (matching the release branch TFM) rather than net11.0 (from main). Functionality is equivalent to the original hardcoded approach.
Risk
REQUIRED: Check exactly one box.
Tooling-only change to findMissingNotices.ps1. Moves hardcoded TFM values to a JSON config file, improving maintainability. Behavior is equivalent — the dotnetTargetName in the config is set to net10.0 matching the release branch. No product code changes.
Merge Conflicts
Conflict in tools/findMissingNotices.ps1: the release branch had net10.0 hardcoded while the PR was based on main's net11.0. Resolution: applied the config-driven approach ($baseTargetName = $script:dotnetTargetName) and set dotnetTargetName in the new findMissingNotices.targets.json to net10.0 to match the release branch's TFM.