Skip to content

[release/v7.4.15] Update the PhoneProductId to be the official LTS id used by Store #27169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
Apr 3, 2026
Merged

[release/v7.4.15] Update the PhoneProductId to be the official LTS id used by Store #27169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
512bcc1
Update the `PhoneProductId` to be the official LTS id used by Store (…
daxian-dbw Mar 20, 2026
794062e
Merge branch 'release/v7.4.15' into backport/release/v7.4.15/27077-1e…
adityapatwardhan Apr 3, 2026
af11b83
Merge branch 'release/v7.4.15' into backport/release/v7.4.15/27077-1e…
adityapatwardhan Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/packaging/packaging.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4300,7 +4300,7 @@ function New-MSIXPackage
Write-Verbose "Using Preview assets" -Verbose
} elseif ($LTS) {
# This is the PhoneProductId for the "Microsoft.PowerShell-LTS" package.
$PhoneProductId = "a9af273a-c636-47ac-bc2a-775edf80b2b9"
$PhoneProductId = "b7a4b003-3704-47a9-b018-cfcc9801f4fc"
Write-Verbose "Using LTS assets" -Verbose
}
Comment on lines 4301 to 4305
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PhoneProductId is assigned in the LTS branch, but it is never referenced anywhere else in New-MSIXPackage (or the module). As a result, changing this GUID appears to be a no-op and won’t affect the generated MSIX/manifest, which conflicts with the PR goal of updating Store publishing metadata. Either wire PhoneProductId into the generated AppxManifest (or whatever Store metadata consumes it) or remove this unused variable/comment to avoid misleading future changes.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch. It seems lots of changes in this function is missing, such as the '$PHONEPRODUCTID$' placeholder in the AppxManifest file.

Copy link
Copy Markdown
Member Author

@adityapatwardhan adityapatwardhan Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot check if this still applies


Expand Down
Loading