Skip to content

Delay update notification for one week to ensure all packages become available #27095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Apr 3, 2026
+14 −2
Merged

Delay update notification for one week to ensure all packages become available #27095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fbf285
Delay update notification for 1 week
daxian-dbw Mar 3, 2026
76c33cc
Address Copilot comments
daxian-dbw Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ internal static class UpdatesNotification
private const string StableBuildInfoURL = "https://aka.ms/pwsh-buildinfo-stable";
private const string PreviewBuildInfoURL = "https://aka.ms/pwsh-buildinfo-preview";

private const int NotificationDelayDays = 7;
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 days is the practical minimum for Microsoft Update. Maybe we should go to 14 days?

Copy link
Copy Markdown
Member Author

@daxian-dbw daxian-dbw Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mainly for users who manually run WinGet for updates. Not being available on WinGet is what usually reported in issues. For folks depending on MU, they probably already disabled the update notification.

In the long run, we want to deprecate this feature all together. Jason opened a discussion thread about it: #27060

private const int UpdateCheckBackoffDays = 7;

/// <summary>
/// The version of new update is persisted using a file, not as the file content, but instead baked in the file name in the following template:
/// `update{notification-type}_{version}_{publish-date}` -- held by 's_updateFileNameTemplate',
Expand Down Expand Up @@ -89,9 +92,18 @@ internal static void ShowUpdateNotification(PSHostUserInterface hostUI)
if (TryParseUpdateFile(
updateFilePath: out _,
out SemanticVersion lastUpdateVersion,
lastUpdateDate: out _)
out DateTime lastUpdateDate)
&& lastUpdateVersion != null)
{
DateTime today = DateTime.UtcNow;
if ((today - lastUpdateDate).TotalDays < NotificationDelayDays)
{
// The update was out less than 1 week ago and it's possible the packages are still rolling out.
// We only show the notification when the update is at least 1 week old, to reduce the chance that
// users see the notification but cannot get the new update when they try to install it.
return;
}

string releaseTag = lastUpdateVersion.ToString();
string notificationMsgTemplate = s_notificationType == NotificationType.LTS
? ManagedEntranceStrings.LTSUpdateNotificationMessage
Expand Down Expand Up @@ -169,7 +181,7 @@ internal static async Task CheckForUpdates()
out DateTime lastUpdateDate);

DateTime today = DateTime.UtcNow;
if (parseSuccess && updateFilePath != null && (today - lastUpdateDate).TotalDays < 7)
if (parseSuccess && updateFilePath != null && (today - lastUpdateDate).TotalDays < UpdateCheckBackoffDays)
{
// There is an existing update file, and the last update was less than 1 week ago.
// It's unlikely a new version is released within 1 week, so we can skip this check.
Expand Down
Loading