Skip to content

[release/v7.6] Create infrastructure to create two msixs and msixbundles for LTS and Stable #27071

Merged
daxian-dbw merged 1 commit into
PowerShell:release/v7.6.0from
daxian-dbw:v760
Mar 19, 2026
Merged

[release/v7.6] Create infrastructure to create two msixs and msixbundles for LTS and Stable #27071
daxian-dbw merged 1 commit into
PowerShell:release/v7.6.0from
daxian-dbw:v760

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

PR Summary

Backport of #27056 to release/v7.6.0

@daxian-dbw daxian-dbw requested a review from jshigetomi as a code owner March 19, 2026 21:32
Copilot AI review requested due to automatic review settings March 19, 2026 21:32
@daxian-dbw daxian-dbw requested a review from a team as a code owner March 19, 2026 21:32
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport to release/v7.6.0 that updates Windows packaging/pipeline logic to support producing both Stable and LTS MSIX/MSIXBundle outputs in the same run, and to ensure store packaging uses the correct bundle for the selected channel.

Changes:

  • Adjust MSIX package naming composition in New-MSIXPackage to build the base package name after channel-specific name mutations (Stable/Preview/LTS/Private).
  • Update the Windows packaging pipeline to optionally build an additional Stable MSIX when both LTS and Stable packaging are requested.
  • Update the MSIX bundling pipeline to create separate LTS vs Stable/Preview .msixbundle files and select the correct one for StoreBroker packaging.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tools/packaging/packaging.psm1 Refactors MSIX package name/display name construction to support side-by-side channel outputs more cleanly.
.pipelines/templates/packaging/windows/package.yml Adds Stable packaging flag handling and triggers an extra Stable MSIX build when LTS+Stable are both enabled.
.pipelines/templates/package-create-msix.yml Splits MSIX inputs into LTS vs non-LTS sets, builds two bundles, uploads both, and selects the right bundle for store packaging by channel.
Comments suppressed due to low confidence (1)

.pipelines/templates/package-create-msix.yml:121

  • Same issue for the LTS bundle creation: if makeappx bundle fails, this script can still continue successfully. Add explicit exit-code handling (or use the standard native execution wrapper) so the job stops on bundling errors.
            $file = $ltsMsix | Select-Object -First 1
            $prefix = ($file.BaseName -split "-win")[0]
            $ltsBundleName = "$prefix.msixbundle"
            Write-Verbose -Verbose "Creating LTS bundle: $ltsBundleName"
            & $makeappx bundle /d $ltsDir /p "$outputDir\$ltsBundleName"
        }

Comment on lines +104 to +109
$file = $stableMsix | Select-Object -First 1
$prefix = ($file.BaseName -split "-win")[0]
$stableBundleName = "$prefix.msixbundle"
Write-Verbose -Verbose "Creating Stable/Preview bundle: $stableBundleName"
& $makeappx bundle /d $stableDir /p "$outputDir\$stableBundleName"
}
Copy link

Copilot AI Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makeappx bundle is invoked via the call operator, which won’t fail the step on a non-zero native exit code by default. Please ensure the pipeline fails when bundling fails (e.g., check $LASTEXITCODE after the call and throw, or use the repo’s native-execution helper) so we don’t publish missing/invalid bundles.

This issue also appears on line 116 of the same file.

Copilot uses AI. Check for mistakes.
@daxian-dbw daxian-dbw merged commit 031e7c9 into PowerShell:release/v7.6.0 Mar 19, 2026
42 checks passed
@daxian-dbw daxian-dbw deleted the v760 branch March 19, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants