Separate Official and NonOfficial templates for ADO pipelines#26897
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures ADO pipeline configurations to comply with 1ES Pipeline Drift Management requirements by eliminating toggle-based OfficialBuild parameters that dynamically switched between Official and NonOfficial OneBranch templates. Instead, it creates dedicated NonOfficial pipeline YAML files, extracts shared variables and stages into reusable templates, and hard-codes the appropriate template reference in each pipeline file.
Changes:
- Creates new NonOfficial pipeline YAML files under
.pipelines/NonOfficial/for all five pipeline types (Packages, Coordinated Packages, Release, Release-Azure, vPack). - Extracts shared pipeline variables and stages into dedicated template files under
.pipelines/templates/variables/and.pipelines/templates/stages/. - Refactors Official pipelines to remove the
OfficialBuildtoggle parameter and replace inline variables/stages sections with template references.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.pipelines/templates/variables/release-shared.yml |
New shared variable template for release jobs; fixes path from variable/ to variables/ |
.pipelines/templates/variables/PowerShell-*-Variables.yml |
New shared variable templates extracted from each Official pipeline |
.pipelines/templates/stages/PowerShell-*-Stages.yml |
New shared stage templates extracted from each Official pipeline |
.pipelines/templates/release-githubNuget.yml |
Path fix: ./variable/ → ./variables/ for release-shared.yml reference |
.pipelines/templates/release-MSIX-Publish.yml |
Path fix: ./variable/ → ./variables/ for release-shared.yml reference |
.pipelines/PowerShell-*-Official.yml |
Removes OfficialBuild param, replaces inline variables/stages with template references, hard-codes Official template |
.pipelines/NonOfficial/PowerShell-*-NonOfficial.yml |
New NonOfficial pipeline files using shared templates with NonOfficial extends template |
.github/agents/SplitADOPipelines.agent.md |
Agent specification documenting the pipeline split process |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rShell into fixTemplateIssue
12 tasks
TravisEz13
reviewed
Mar 24, 2026
| tsaOptionsFile: .config\tsaoptions.json | ||
|
|
||
| stages: | ||
| - template: ../templates/stages/PowerShell-Release-Stages.yml |
Member
There was a problem hiding this comment.
in general its better to use absolute paths with @self
adityapatwardhan
approved these changes
Mar 24, 2026
TravisEz13
approved these changes
Mar 24, 2026
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 1, 2026
…hell#26897) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9 tasks
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 2, 2026
…hell#26897) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
9 tasks
9 tasks
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 2, 2026
…hell#26897) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request restructures the ADO pipeline configuration to split existing pipelines into distinct Official and NonOfficial versions, following new repository standards. It introduces new NonOfficial pipeline YAML files, extracts shared variables and stages into templates, and updates the Official pipeline to remove toggle-based logic. These changes improve maintainability, clarity, and compliance with updated Azure DevOps practices.
Pipeline Restructuring and Standardization
.github/agents/SplitADOPipelines.agent.mddescribing the process for splitting pipelines, extracting shared templates, and ensuring correct artifact dependencies between Official and NonOfficial pipelines..pipelines/NonOfficial/forPowerShell-Packages,PowerShell-Coordinated_Packages,PowerShell-Release,PowerShell-Release-Azure, andPowerShell-vPack, each hardcoding the NonOfficial template reference and referencing shared variable and stage templates. [1] [2] [3] [4] [5]Official Pipeline Refactoring
.pipelines/PowerShell-Coordinated_Packages-Official.ymlto:OfficialBuildparameter and toggle-based template logic.extendssection.Dependency and Artifact Management
These changes collectively modernize the pipeline structure, reduce duplication, and enforce a clear separation between Official and NonOfficial build processes.
PR Context
This PR was written in an effort to comply with 1ES Pipeline's Drift Management.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header