Skip to content

Fix up default value for in parameters #26785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Feb 18, 2026
Merged

Fix up default value for in parameters #26785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbd4be
Fix up default value for in parameters
jborean93 Feb 12, 2026
1f53d85
Update src/System.Management.Automation/engine/runtime/Binding/Binder…
jborean93 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/System.Management.Automation/engine/runtime/Binding/Binders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7201,6 +7201,13 @@ internal static Expression InvokeMethod(MethodBase mi, DynamicMetaObject target,
var argValue = parameters[i].DefaultValue;
if (argValue == null)
{
if (parameterType.IsByRef)
{
// When the default value is null for a ByRef parameter (e.g. an optional `in` parameter
// using `default`), expression trees cannot create Expression.Default for the T& type.
// In that case we switch to the element type and use Default(TElement) instead.
parameterType = parameterType.GetElementType();
}
argExprs[i] = Expression.Default(parameterType);
}
else if (!parameters[i].HasDefaultValue && parameterType != typeof(object) && argValue == Type.Missing)
Expand Down
21 changes: 21 additions & 0 deletions test/powershell/engine/Basic/CLRBinding.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ public class TestClass
public static string StaticWithOptionalExpected() => StaticWithOptional();
public static string StaticWithOptional([Optional] string value) => value;

public static int PrimitiveTypeWithInDefault(in int value = default) => value;

public static Guid ValueTypeWithInDefault(in Guid value = default) => value;

public static string RefTypeWithInDefault(in string value = default) => value;

public object InstanceWithDefaultExpected() => InstanceWithDefault();
public object InstanceWithDefault(object value = null) => value;

Expand Down Expand Up @@ -101,6 +107,21 @@ public class TestClassCstorWithOptional
$actual | Should -Be $expected
}

It "Binds to static method with primitive type with in modifier and default argument" {
$actual = [CLRBindingTests.TestClass]::PrimitiveTypeWithInDefault()
$actual | Should -Be 0
}

It "Binds to static method with value type with in modifier and default argument" {
$actual = [CLRBindingTests.TestClass]::ValueTypeWithInDefault()
$actual | Should -Be ([Guid]::Empty)
}

It "Binds to static method with ref type with in modifier and default argument" {
$actual = [CLRBindingTests.TestClass]::RefTypeWithInDefault()
$null -eq $actual | Should -BeTrue
}

It "Binds to instance method with default argument" {
$c = [CLRBindingTests.TestClass]::new()

Expand Down
Loading