Fix up default value for in parameters#26785
Merged
Merged
Conversation
Fix up calling a method with an `in` parameter modifier and the `default` value. Currently this only works for primitive types and `default` whereas other types need special handling to be called.
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes PowerShell’s .NET method binder to correctly handle optional parameters declared with the in modifier when the default value is represented as null in metadata (e.g., in Guid x = default), avoiding expression tree construction errors for by-ref parameter types.
Changes:
- Adjust binder logic to use the element type when building
Expression.Default(...)for optionalByRefparameters. - Add CLR binding regression tests covering
in+defaultfor primitive, value, and reference types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/powershell/engine/Basic/CLRBinding.Tests.ps1 | Adds regression tests for invoking static methods with optional in parameters using default. |
| src/System.Management.Automation/engine/runtime/Binding/Binders.cs | Updates optional-argument expression generation to avoid calling Expression.Default with a ByRef type. |
…s.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix up calling a method with an
inparameter modifier and thedefaultvalue. Currently this only works for primitive types anddefaultwhereas other types need special handling to be called.PR Context
Fixes: #26784
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header