Improve error message from Start-NativeExecution#26500
Merged
daxian-dbw merged 2 commits intoJan 9, 2026
Merged
Conversation
… executing the script block and then include it in the error message if one happens.
daxian-dbw
reviewed
Nov 20, 2025
daxian-dbw
reviewed
Nov 21, 2025
kilasuit
approved these changes
Nov 23, 2025
Contributor
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update the
Start-NativeExecutioncmdlet that is part of the build infrastructure to report the directory in which the script block was executed, in the event of an error.PR Context
I ran
Start-PSBuild, and it failed with an error during the ResGen phase:This error message told me what went wrong:
dotnet runIt told me in general terms what was happening when it went wrong:
Run ResGenBut this information alone wasn't enough to diagnose the problem.
dotnet runin the root obviously doesn't do anything and isn't connected with the error at all. I had to open upbuild.psm1and find out what exactly was on line 2666:Ahh. It's doing it inside
./src/ResGen.So, this PR updates the error message so that obtaining this context doesn't require peeking into
build.psm1directly:PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header