Skip to content

Fix the fuzzy test#26402

Merged
TravisEz13 merged 3 commits into
PowerShell:masterfrom
daxian-dbw:fuzzy_test
Nov 7, 2025
Merged

Fix the fuzzy test#26402
TravisEz13 merged 3 commits into
PowerShell:masterfrom
daxian-dbw:fuzzy_test

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

PR Summary

  1. Update powershell-fuzz-tests.csproj to use Test.Common.props. So, it doesn't need to update the target framework separately in future.
  2. Update the runFuzzer.ps1 file to correct the instrumentation and remove unneeded code.

@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners November 6, 2025 23:49
@daxian-dbw daxian-dbw added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 6, 2025
@TravisEz13 TravisEz13 enabled auto-merge (squash) November 6, 2025 23:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the fuzzing test runner script to improve its usability and maintainability. The changes simplify the script by removing dynamic target discovery and providing better default values for paths.

Key Changes

  • Updated parameter defaults to use $PSScriptRoot for better portability and made $corpus parameter optional with a sensible default
  • Simplified instrumentation logic by targeting specific classes (FuzzTests.Target and System.Management.Automation.Remoting.RemoteSessionHyperVSocketClient) instead of using dynamic discovery
  • Modernized the .csproj file by importing Test.Common.props for consistent build configuration across test projects

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
test/fuzzing/runFuzzer.ps1 Added documentation header, updated parameter defaults with $PSScriptRoot, simplified instrumentation to target specific classes, and changed build configuration to Debug
test/fuzzing/FuzzingApp/powershell-fuzz-tests.csproj Added import of Test.Common.props and removed redundant property definitions for cleaner project configuration
test/fuzzing/FuzzingApp/Target.cs Removed trailing newline (whitespace cleanup)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/fuzzing/runFuzzer.ps1
Comment thread test/fuzzing/runFuzzer.ps1
Comment thread test/fuzzing/runFuzzer.ps1
Comment thread test/fuzzing/runFuzzer.ps1
@TravisEz13 TravisEz13 merged commit 3953976 into PowerShell:master Nov 7, 2025
35 checks passed
@daxian-dbw daxian-dbw deleted the fuzzy_test branch November 7, 2025 01:24
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
kilasuit pushed a commit to kilasuit/PowerShell that referenced this pull request Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants