From ad11eec2e41806505e7bebaaafd0e8c054eb9e1d Mon Sep 17 00:00:00 2001 From: xtqqczze <45661989+xtqqczze@users.noreply.github.com> Date: Tue, 2 Sep 2025 19:25:05 +0100 Subject: [PATCH] Fix `SA1028`: Code should not contain trailing whitespace https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md --- .../engine/remoting/client/Job.cs | 2 +- .../engine/remoting/client/Job2.cs | 2 +- .../engine/remoting/client/ThrottlingJob.cs | 2 +- .../engine/remoting/commands/InvokeCommandCommand.cs | 10 +++++----- .../engine/remoting/commands/PushRunspaceCommand.cs | 6 +++--- .../engine/remoting/commands/SuspendJob.cs | 2 +- .../engine/remoting/common/RunspaceConnectionInfo.cs | 2 +- .../engine/remoting/fanin/BaseTransportManager.cs | 2 +- .../engine/remoting/fanin/WSManTransportManager.cs | 2 +- .../engine/remoting/server/serverremotesession.cs | 2 +- 10 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/System.Management.Automation/engine/remoting/client/Job.cs b/src/System.Management.Automation/engine/remoting/client/Job.cs index adf47d04cab..56d45574387 100644 --- a/src/System.Management.Automation/engine/remoting/client/Job.cs +++ b/src/System.Management.Automation/engine/remoting/client/Job.cs @@ -190,7 +190,7 @@ internal InvalidJobStateException(JobState currentState) /// The that contains contextual information /// about the source or destination. /// - [Obsolete("Legacy serialization support is deprecated since .NET 8", DiagnosticId = "SYSLIB0051")] + [Obsolete("Legacy serialization support is deprecated since .NET 8", DiagnosticId = "SYSLIB0051")] protected InvalidJobStateException(SerializationInfo info, StreamingContext context) { diff --git a/src/System.Management.Automation/engine/remoting/client/Job2.cs b/src/System.Management.Automation/engine/remoting/client/Job2.cs index a5ac9e5ec0b..3342b81d0fd 100644 --- a/src/System.Management.Automation/engine/remoting/client/Job2.cs +++ b/src/System.Management.Automation/engine/remoting/client/Job2.cs @@ -2150,7 +2150,7 @@ public JobFailedException(Exception innerException, ScriptExtent displayScriptPo /// /// Serialization info. /// Streaming context. - [Obsolete("Legacy serialization support is deprecated since .NET 8", DiagnosticId = "SYSLIB0051")] + [Obsolete("Legacy serialization support is deprecated since .NET 8", DiagnosticId = "SYSLIB0051")] protected JobFailedException(SerializationInfo serializationInfo, StreamingContext streamingContext) { throw new NotSupportedException(); diff --git a/src/System.Management.Automation/engine/remoting/client/ThrottlingJob.cs b/src/System.Management.Automation/engine/remoting/client/ThrottlingJob.cs index 59f4fb5135d..93fdc6d0699 100644 --- a/src/System.Management.Automation/engine/remoting/client/ThrottlingJob.cs +++ b/src/System.Management.Automation/engine/remoting/client/ThrottlingJob.cs @@ -373,7 +373,7 @@ internal void AddChildJobWithoutBlocking(StartableJob childJob, ChildJobFlags fl { throw new ArgumentException(RemotingErrorIdStrings.ThrottlingJobChildAlreadyRunning, nameof(childJob)); } - + this.AssertNotDisposed(); JobStateInfo newJobStateInfo = null; diff --git a/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs b/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs index e340a1acbdb..561ccada7ab 100644 --- a/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs +++ b/src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs @@ -757,7 +757,7 @@ public override string Subsystem public override int ConnectingTimeout { get { return base.ConnectingTimeout; } - + set { base.ConnectingTimeout = value; } } @@ -800,12 +800,12 @@ public override Hashtable[] SSHConnection [ValidateNotNullOrEmpty] public override Hashtable Options { - get + get { return base.Options; } - set + set { base.Options = value; } @@ -1249,7 +1249,7 @@ protected override void EndProcessing() WriteJobResults(false); // Dispose job object if it is not returned to the user. - // The _asjob field can change dynamically and needs to be checked before the job + // The _asjob field can change dynamically and needs to be checked before the job // object is disposed. For example, if remote sessions are disconnected abruptly // via WinRM, a disconnected job object is created to facilitate a reconnect. // If the job object is disposed here, then a session reconnect cannot happen. @@ -1303,7 +1303,7 @@ protected override void EndProcessing() WriteJobResults(false); // Dispose job object if it is not returned to the user. - // The _asjob field can change dynamically and needs to be checked before the job + // The _asjob field can change dynamically and needs to be checked before the job // object is disposed. For example, if remote sessions are disconnected abruptly // via WinRM, a disconnected job object is created to facilitate a reconnect. // If the job object is disposed here, then a session reconnect cannot happen. diff --git a/src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs b/src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs index bf456e85db2..6ffbe3b798c 100644 --- a/src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs +++ b/src/System.Management.Automation/engine/remoting/commands/PushRunspaceCommand.cs @@ -63,9 +63,9 @@ public class EnterPSSessionCommand : PSRemotingBaseCmdlet /// [Parameter(ParameterSetName = PSRemotingBaseCmdlet.SSHHostParameterSet)] [ValidateNotNullOrEmpty] - public override Hashtable Options - { - get + public override Hashtable Options + { + get { return base.Options; } diff --git a/src/System.Management.Automation/engine/remoting/commands/SuspendJob.cs b/src/System.Management.Automation/engine/remoting/commands/SuspendJob.cs index e454247ae9a..53382e67adb 100644 --- a/src/System.Management.Automation/engine/remoting/commands/SuspendJob.cs +++ b/src/System.Management.Automation/engine/remoting/commands/SuspendJob.cs @@ -335,7 +335,7 @@ protected override void EndProcessing() _waitForJobs.WaitOne(); } - if (_warnInvalidState) + if (_warnInvalidState) { WriteWarning(RemotingErrorIdStrings.SuspendJobInvalidJobState); } diff --git a/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs b/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs index 475dc705674..9cbe9a2411a 100644 --- a/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs +++ b/src/System.Management.Automation/engine/remoting/common/RunspaceConnectionInfo.cs @@ -2245,7 +2245,7 @@ internal int StartSSHProcess( } } } - + if (string.IsNullOrEmpty(filePath)) { throw new CommandNotFoundException( diff --git a/src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs b/src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs index c3cf3b278aa..9440f3daa57 100644 --- a/src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs +++ b/src/System.Management.Automation/engine/remoting/fanin/BaseTransportManager.cs @@ -82,7 +82,7 @@ public enum TransportMethodEnum /// ReconnectShellEx /// ReconnectShellEx = 8, - + /// /// ConnectShellEx /// diff --git a/src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs b/src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs index d4ee779b5a2..dbffe124fff 100644 --- a/src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs +++ b/src/System.Management.Automation/engine/remoting/fanin/WSManTransportManager.cs @@ -2084,7 +2084,7 @@ private static void OnRemoteSessionDisconnectCompleted(IntPtr operationContext, sessionTM.EnqueueAndStartProcessingThread(null, null, new CompletionEventArgs(CompletionNotification.DisconnectCompleted)); - // Log ETW traces + // Log ETW traces PSEtwLog.LogAnalyticInformational( PSEventId.WSManCloseShellCallbackReceived, PSOpcode.Disconnect, diff --git a/src/System.Management.Automation/engine/remoting/server/serverremotesession.cs b/src/System.Management.Automation/engine/remoting/server/serverremotesession.cs index b1e05909d2c..ccb8944024d 100644 --- a/src/System.Management.Automation/engine/remoting/server/serverremotesession.cs +++ b/src/System.Management.Automation/engine/remoting/server/serverremotesession.cs @@ -775,7 +775,7 @@ private void HandleCreateRunspacePool(object sender, RemoteDataEventArgs createR // This parameter is only used by Out-Of-Proc transports (not WinRM transports). var discConfiguration = new Remoting.DISCPowerShellConfiguration( configFile: _configurationFile, - roleVerifier: null, + roleVerifier: null, validateFile: true); rsSessionStateToUse = discConfiguration.GetInitialSessionState(_senderInfo); }