Skip to content

Correct handling of explicit -Since:$false parameter value in Get-Uptime #26141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
Oct 9, 2025
Merged

Correct handling of explicit -Since:$false parameter value in Get-Uptime #26141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
452e78a
Added test of Get-Uptime -Since:$false to Get-Uptime.Tests.ps1, repro…
logiclrd Oct 3, 2025
9c91de9
Changed comments in GetUptime.cs from documenting what it's doing to …
logiclrd Oct 3, 2025
1d92799
Use implicit conversion of SwitchParameter instead of ToBool
logiclrd Oct 5, 2025
6f05175
Fine tuning of comments per PR feedback
logiclrd Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetUptime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,15 @@ protected override void ProcessRecord()
{
TimeSpan uptime = TimeSpan.FromSeconds(Stopwatch.GetTimestamp() / Stopwatch.Frequency);

switch (ParameterSetName)
if (Since)
{
case TimespanParameterSet:
// return TimeSpan of time since the system started up
WriteObject(uptime);
break;
case SinceParameterSet:
// return Datetime when the system started up
WriteObject(DateTime.Now.Subtract(uptime));
break;
// Output the time of the last system boot.
WriteObject(DateTime.Now.Subtract(uptime));
Comment thread
logiclrd marked this conversation as resolved.
}
else
{
// Output the time elapsed since the last system boot.
WriteObject(uptime);
Comment thread
logiclrd marked this conversation as resolved.
}
}
else
Expand Down
4 changes: 4 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Uptime.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ Describe "Get-Uptime" -Tags "CI" {
$upt = Get-Uptime -Since
$upt | Should -BeOfType DateTime
}
It "Get-Uptime -Since:`$false return TimeSpan" {
Comment thread
logiclrd marked this conversation as resolved.
$upt = Get-Uptime -Since:$false
$upt | Should -BeOfType TimeSpan
}
It "Get-Uptime throw if IsHighResolution == false" {
# Enable the test hook
[system.management.automation.internal.internaltesthooks]::SetTestHook('StopwatchIsNotHighResolution', $true)
Expand Down
Loading