From 3e2bf3c71c6ee90747c0591886aca4ea69c60ced Mon Sep 17 00:00:00 2001 From: Dongbo Wang Date: Fri, 12 Nov 2021 11:59:12 -0800 Subject: [PATCH 1/4] Fix comment in UpdateNotification.cs --- .../host/msh/UpdatesNotification.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs index dff3757259f..e9bc2d343b4 100644 --- a/src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs +++ b/src/Microsoft.PowerShell.ConsoleHost/host/msh/UpdatesNotification.cs @@ -108,7 +108,7 @@ internal static void ShowUpdateNotification(PSHostUserInterface hostUI) // We calculate how much whitespace we need to make it look nice if (hostUI.SupportsVirtualTerminal) { - // Use Warning Color + // Swaps foreground and background colors. notificationColor = "\x1B[7m"; resetColor = "\x1B[0m"; From 8beafee44fbf8aab0399011ad0d055b25daf2b32 Mon Sep 17 00:00:00 2001 From: Dongbo Wang Date: Mon, 6 Dec 2021 10:01:17 -0800 Subject: [PATCH 2/4] Fix another comment --- src/System.Management.Automation/engine/parser/Parser.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/System.Management.Automation/engine/parser/Parser.cs b/src/System.Management.Automation/engine/parser/Parser.cs index 8fbb262edad..e3d08ca38ab 100644 --- a/src/System.Management.Automation/engine/parser/Parser.cs +++ b/src/System.Management.Automation/engine/parser/Parser.cs @@ -6735,7 +6735,7 @@ private ExpressionAst ExpressionRule(bool endNumberOnTernaryOpChars = false) SkipToken(); SkipNewlines(); - // We have seen the ternary operator '?' and now expecting the 'IfFalse' expression. + // We have seen the ternary operator '?' and now expecting the 'IfTrue' expression. ExpressionAst ifTrue = ExpressionRule(endNumberOnTernaryOpChars: true); if (ifTrue == null) { From bf4296291c36d9b95d87824fb484cc2f00e975f2 Mon Sep 17 00:00:00 2001 From: Dongbo Wang Date: Mon, 6 Dec 2021 10:38:31 -0800 Subject: [PATCH 3/4] Avoid unnecessary verbose messages in Find-Dotnet --- build.psm1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build.psm1 b/build.psm1 index 2900e1bc4f8..fcc2e360169 100644 --- a/build.psm1 +++ b/build.psm1 @@ -2239,7 +2239,7 @@ function Start-ResGen } function Find-Dotnet() { - Write-Verbose -Verbose "In Find-DotNet" + Write-Verbose "In Find-DotNet" $originalPath = $env:PATH $dotnetPath = if ($environment.IsWindows) { "$env:LocalAppData\Microsoft\dotnet" } else { "$env:HOME/.dotnet" } @@ -2259,7 +2259,7 @@ function Find-Dotnet() { $dotnetCLIInstalledVersion = Get-LatestInstalledSDK Pop-Location - Write-Verbose -Verbose "dotnetCLIInstalledVersion = $dotnetCLIInstalledVersion`nchosenDotNetVersion = $chosenDotNetVersion" + Write-Verbose "dotnetCLIInstalledVersion = $dotnetCLIInstalledVersion; chosenDotNetVersion = $chosenDotNetVersion" if ($dotnetCLIInstalledVersion -ne $chosenDotNetVersion) { Write-Warning "The 'dotnet' in the current path can't find SDK version ${dotnetCLIRequiredVersion}, prepending $dotnetPath to PATH." From 65dbb1cb019101fe1a85563eb64329c8addfef9e Mon Sep 17 00:00:00 2001 From: Dongbo Wang Date: Wed, 15 Dec 2021 14:59:14 -0800 Subject: [PATCH 4/4] Fix DSC overview URL --- demos/DSC/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demos/DSC/readme.md b/demos/DSC/readme.md index 0ce83fb3efa..0dd98968d2f 100644 --- a/demos/DSC/readme.md +++ b/demos/DSC/readme.md @@ -1,6 +1,6 @@ # DSC MOF Compilation Demo -[PowerShell Desired State Configuration](https://docs.microsoft.com/powershell/scripting/dsc/overview/overview) is a declarative configuration platform for Windows and Linux. +[PowerShell Desired State Configuration](https://docs.microsoft.com/powershell/scripting/dsc/overview) is a declarative configuration platform for Windows and Linux. DSC configurations can be authored in PowerShell and compiled into the resultant MOF document. This demo shows use of PowerShell to author a DSC configuration to set the configuration of an Apache web server. PowerShell scripting is used to assess distribution and version-specific properties,