From 6c62de5b8195b94398c60ed7b4502252855ccdd3 Mon Sep 17 00:00:00 2001
From: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
Date: Wed, 5 Feb 2020 02:27:59 +0000
Subject: [PATCH] Fix RCS1102: Make class static
https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1102.md
---
.../WindowsTaskbarJumpList/PropVariant.cs | 2 +-
.../DotNetCode/Eventing/Reader/NativeWrapper.cs | 2 +-
src/System.Management.Automation/AssemblyInfo.cs | 2 +-
src/System.Management.Automation/engine/COM/ComUtil.cs | 2 +-
.../EnableDisableExperimentalFeatureCommand.cs | 2 +-
.../engine/InitialSessionState.cs | 2 +-
.../engine/Modules/AnalysisCache.cs | 2 +-
src/System.Management.Automation/engine/MshMemberInfo.cs | 2 +-
src/System.Management.Automation/engine/WinRT/IInspectable.cs | 2 +-
src/System.Management.Automation/engine/parser/PSType.cs | 2 +-
.../engine/parser/TypeResolver.cs | 2 +-
.../engine/remoting/commands/NewPSSessionConfigurationFile.cs | 2 +-
.../remoting/common/WireDataFormat/RemoteHostEncoder.cs | 2 +-
.../engine/runtime/Binding/Binders.cs | 2 +-
.../engine/runtime/CompiledScriptBlock.cs | 2 +-
src/System.Management.Automation/help/CabinetAPI.cs | 2 +-
.../help/DefaultCommandHelpObjectBuilder.cs | 2 +-
src/System.Management.Automation/help/HelpUtils.cs | 2 +-
src/System.Management.Automation/help/MamlUtil.cs | 2 +-
src/System.Management.Automation/security/SecuritySupport.cs | 4 ++--
.../security/wldpNativeMethods.cs | 4 ++--
src/System.Management.Automation/utils/PlatformInvokes.cs | 2 +-
src/System.Management.Automation/utils/PsUtils.cs | 2 +-
23 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs b/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
index 90148ca7e25..10db7912b4a 100644
--- a/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
+++ b/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
@@ -58,7 +58,7 @@ public void Dispose()
Dispose();
}
- private class PropVariantNativeMethods
+ private static class PropVariantNativeMethods
{
[DllImport("Ole32.dll", PreserveSig = false)]
internal static extern void PropVariantClear([In, Out] PropVariant pvar);
diff --git a/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/Reader/NativeWrapper.cs b/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/Reader/NativeWrapper.cs
index c9cd4d255eb..007cf74891e 100644
--- a/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/Reader/NativeWrapper.cs
+++ b/src/Microsoft.PowerShell.CoreCLR.Eventing/DotNetCode/Eventing/Reader/NativeWrapper.cs
@@ -22,7 +22,7 @@
namespace System.Diagnostics.Eventing.Reader
{
- internal class NativeWrapper
+ internal static class NativeWrapper
{
public class SystemProperties
{
diff --git a/src/System.Management.Automation/AssemblyInfo.cs b/src/System.Management.Automation/AssemblyInfo.cs
index 279feede65b..1963b331ef1 100644
--- a/src/System.Management.Automation/AssemblyInfo.cs
+++ b/src/System.Management.Automation/AssemblyInfo.cs
@@ -27,7 +27,7 @@
namespace System.Management.Automation
{
- internal class NTVerpVars
+ internal static class NTVerpVars
{
internal const int PRODUCTMAJORVERSION = 10;
internal const int PRODUCTMINORVERSION = 0;
diff --git a/src/System.Management.Automation/engine/COM/ComUtil.cs b/src/System.Management.Automation/engine/COM/ComUtil.cs
index bc7609b7336..e244e4cdf3f 100644
--- a/src/System.Management.Automation/engine/COM/ComUtil.cs
+++ b/src/System.Management.Automation/engine/COM/ComUtil.cs
@@ -16,7 +16,7 @@ namespace System.Management.Automation
///
/// Defines a utility class that is used by COM adapter.
///
- internal class ComUtil
+ internal static class ComUtil
{
// HResult error code '-2147352573' - Member not found.
internal const int DISP_E_MEMBERNOTFOUND = unchecked((int)0x80020003);
diff --git a/src/System.Management.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs b/src/System.Management.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs
index c15d8628cb9..7a76a18ddb9 100644
--- a/src/System.Management.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs
+++ b/src/System.Management.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs
@@ -70,7 +70,7 @@ protected override void ProcessRecord()
}
}
- internal class ExperimentalFeatureConfigHelper
+ internal static class ExperimentalFeatureConfigHelper
{
internal static void UpdateConfig(PSCmdlet cmdlet, string[] name, ConfigScope scope, bool enable)
{
diff --git a/src/System.Management.Automation/engine/InitialSessionState.cs b/src/System.Management.Automation/engine/InitialSessionState.cs
index 74fb6f87037..585b894bc6f 100644
--- a/src/System.Management.Automation/engine/InitialSessionState.cs
+++ b/src/System.Management.Automation/engine/InitialSessionState.cs
@@ -26,7 +26,7 @@
namespace System.Management.Automation.Runspaces
{
- internal class EarlyStartup
+ internal static class EarlyStartup
{
internal static void Init()
{
diff --git a/src/System.Management.Automation/engine/Modules/AnalysisCache.cs b/src/System.Management.Automation/engine/Modules/AnalysisCache.cs
index 8b055d8fb0f..0d80b976aa6 100644
--- a/src/System.Management.Automation/engine/Modules/AnalysisCache.cs
+++ b/src/System.Management.Automation/engine/Modules/AnalysisCache.cs
@@ -27,7 +27,7 @@ namespace System.Management.Automation
/// Changes to these type of modules will not be re-analyzed, unless the user re-imports the module,
/// or runs Get-Module -List.
///
- internal class AnalysisCache
+ internal static class AnalysisCache
{
private static readonly AnalysisCacheData s_cacheData = AnalysisCacheData.Get();
diff --git a/src/System.Management.Automation/engine/MshMemberInfo.cs b/src/System.Management.Automation/engine/MshMemberInfo.cs
index 9bbec9c4312..332482ea21c 100644
--- a/src/System.Management.Automation/engine/MshMemberInfo.cs
+++ b/src/System.Management.Automation/engine/MshMemberInfo.cs
@@ -3670,7 +3670,7 @@ public override PSMemberInfo Copy()
///
/// /// This class is used in PSMemberInfoInternalCollection and ReadOnlyPSMemberInfoCollection.
///
- internal class MemberMatch
+ internal static class MemberMatch
{
internal static WildcardPattern GetNamePattern(string name)
{
diff --git a/src/System.Management.Automation/engine/WinRT/IInspectable.cs b/src/System.Management.Automation/engine/WinRT/IInspectable.cs
index f6f4d9ee7d9..abc589b4875 100644
--- a/src/System.Management.Automation/engine/WinRT/IInspectable.cs
+++ b/src/System.Management.Automation/engine/WinRT/IInspectable.cs
@@ -26,7 +26,7 @@ internal interface IInspectable { }
///
/// Helper class for WinRT types.
///
- internal class WinRTHelper
+ internal static class WinRTHelper
{
internal static bool IsWinRTType(Type type)
{
diff --git a/src/System.Management.Automation/engine/parser/PSType.cs b/src/System.Management.Automation/engine/parser/PSType.cs
index 7ffc308369f..7a60d06a6be 100644
--- a/src/System.Management.Automation/engine/parser/PSType.cs
+++ b/src/System.Management.Automation/engine/parser/PSType.cs
@@ -14,7 +14,7 @@
namespace System.Management.Automation.Language
{
- internal class TypeDefiner
+ internal static class TypeDefiner
{
internal const string DynamicClassAssemblyName = "PowerShell Class Assembly";
internal const string DynamicClassAssemblyFullNamePrefix = "PowerShell Class Assembly,";
diff --git a/src/System.Management.Automation/engine/parser/TypeResolver.cs b/src/System.Management.Automation/engine/parser/TypeResolver.cs
index 85325b61305..8843ff5cd31 100644
--- a/src/System.Management.Automation/engine/parser/TypeResolver.cs
+++ b/src/System.Management.Automation/engine/parser/TypeResolver.cs
@@ -671,7 +671,7 @@ public override int GetHashCode()
}
}
- internal class TypeCache
+ internal static class TypeCache
{
private class KeyComparer : IEqualityComparer>
{
diff --git a/src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs b/src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs
index f306246e289..56bd72e90d8 100644
--- a/src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs
+++ b/src/System.Management.Automation/engine/remoting/commands/NewPSSessionConfigurationFile.cs
@@ -1855,7 +1855,7 @@ protected override void ProcessRecord()
///
/// Utility methods for configuration file commands.
///
- internal class SessionConfigurationUtils
+ internal static class SessionConfigurationUtils
{
///
/// This routine builds a fragment of the config file
diff --git a/src/System.Management.Automation/engine/remoting/common/WireDataFormat/RemoteHostEncoder.cs b/src/System.Management.Automation/engine/remoting/common/WireDataFormat/RemoteHostEncoder.cs
index 2c3a2c65b14..3ffc278a817 100644
--- a/src/System.Management.Automation/engine/remoting/common/WireDataFormat/RemoteHostEncoder.cs
+++ b/src/System.Management.Automation/engine/remoting/common/WireDataFormat/RemoteHostEncoder.cs
@@ -24,7 +24,7 @@ namespace System.Management.Automation.Remoting
/// guarantees that transmitting on the wire will not change the encoded
/// object's type.
///
- internal class RemoteHostEncoder
+ internal static class RemoteHostEncoder
{
///
/// Is known type.
diff --git a/src/System.Management.Automation/engine/runtime/Binding/Binders.cs b/src/System.Management.Automation/engine/runtime/Binding/Binders.cs
index b32e2e38733..b0568f3f2a5 100644
--- a/src/System.Management.Automation/engine/runtime/Binding/Binders.cs
+++ b/src/System.Management.Automation/engine/runtime/Binding/Binders.cs
@@ -444,7 +444,7 @@ internal static DynamicMetaObject UpdateComRestrictionsForPsObject(this DynamicM
}
}
- internal class BinderUtils
+ internal static class BinderUtils
{
internal static BindingRestrictions GetVersionCheck(DynamicMetaObjectBinder binder, int expectedVersionNumber)
{
diff --git a/src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs b/src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs
index 97625a9e46a..f9661df87c0 100644
--- a/src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs
+++ b/src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs
@@ -1789,7 +1789,7 @@ internal static string CheckSuspiciousContent(Ast scriptBlockAst)
return null;
}
- private class SuspiciousContentChecker
+ private static class SuspiciousContentChecker
{
// Based on a (bad) random number generator, but good enough
// for our simple needs.
diff --git a/src/System.Management.Automation/help/CabinetAPI.cs b/src/System.Management.Automation/help/CabinetAPI.cs
index b450cc0b870..9ccdc08baa6 100644
--- a/src/System.Management.Automation/help/CabinetAPI.cs
+++ b/src/System.Management.Automation/help/CabinetAPI.cs
@@ -78,7 +78,7 @@ internal abstract class ICabinetExtractorLoader
///
/// Used to create a CabinetExtractor class.
///
- internal class CabinetExtractorFactory
+ internal static class CabinetExtractorFactory
{
private static readonly ICabinetExtractorLoader s_cabinetLoader;
internal static readonly ICabinetExtractor EmptyExtractor = new EmptyCabinetExtractor();
diff --git a/src/System.Management.Automation/help/DefaultCommandHelpObjectBuilder.cs b/src/System.Management.Automation/help/DefaultCommandHelpObjectBuilder.cs
index 6b2a63f3754..34b1bd84cef 100644
--- a/src/System.Management.Automation/help/DefaultCommandHelpObjectBuilder.cs
+++ b/src/System.Management.Automation/help/DefaultCommandHelpObjectBuilder.cs
@@ -40,7 +40,7 @@ public int Compare(object x, object y)
/// is present in the box. This class mimics the exact same structure as that of a MAML
/// node, so that the default UX does not introduce regressions.
///
- internal class DefaultCommandHelpObjectBuilder
+ internal static class DefaultCommandHelpObjectBuilder
{
internal static readonly string TypeNameForDefaultHelp = "ExtendedCmdletHelpInfo";
///
diff --git a/src/System.Management.Automation/help/HelpUtils.cs b/src/System.Management.Automation/help/HelpUtils.cs
index 0c0770173be..d4f2abe255b 100644
--- a/src/System.Management.Automation/help/HelpUtils.cs
+++ b/src/System.Management.Automation/help/HelpUtils.cs
@@ -9,7 +9,7 @@
namespace System.Management.Automation
{
- internal class HelpUtils
+ internal static class HelpUtils
{
private static string userHomeHelpPath = null;
diff --git a/src/System.Management.Automation/help/MamlUtil.cs b/src/System.Management.Automation/help/MamlUtil.cs
index 3022d71f4a6..d809655f97f 100644
--- a/src/System.Management.Automation/help/MamlUtil.cs
+++ b/src/System.Management.Automation/help/MamlUtil.cs
@@ -9,7 +9,7 @@ namespace System.Management.Automation
///
/// The MamlUtil class.
///
- internal class MamlUtil
+ internal static class MamlUtil
{
///
/// Takes Name value from maml2 and overrides it in maml1.
diff --git a/src/System.Management.Automation/security/SecuritySupport.cs b/src/System.Management.Automation/security/SecuritySupport.cs
index 809c13efb3f..51162650238 100644
--- a/src/System.Management.Automation/security/SecuritySupport.cs
+++ b/src/System.Management.Automation/security/SecuritySupport.cs
@@ -1335,7 +1335,7 @@ public enum ResolutionPurpose
Decryption
}
- internal class AmsiUtils
+ internal static class AmsiUtils
{
private static string GetProcessHostName(string processName)
{
@@ -1581,7 +1581,7 @@ internal static void WinUninitialize()
public static bool AmsiInitialized = false;
public static bool AmsiCleanedUp = false;
- internal class AmsiNativeMethods
+ internal static class AmsiNativeMethods
{
internal enum AMSI_RESULT
{
diff --git a/src/System.Management.Automation/security/wldpNativeMethods.cs b/src/System.Management.Automation/security/wldpNativeMethods.cs
index 61023787457..d77207b8172 100644
--- a/src/System.Management.Automation/security/wldpNativeMethods.cs
+++ b/src/System.Management.Automation/security/wldpNativeMethods.cs
@@ -488,7 +488,7 @@ internal static string DumpLockdownState(uint pdwLockdownState)
///
/// Native constants for dealing with the lockdown policy.
///
- internal class WldpNativeConstants
+ internal static class WldpNativeConstants
{
internal const uint WLDP_HOST_INFORMATION_REVISION = 0x00000001;
@@ -538,7 +538,7 @@ internal struct WLDP_HOST_INFORMATION
///
/// Native methods for dealing with the lockdown policy.
///
- internal class WldpNativeMethods
+ internal static class WldpNativeMethods
{
/// Return Type: HRESULT->LONG->int
/// pHostInformation: PWLDP_HOST_INFORMATION->_WLDP_HOST_INFORMATION*
diff --git a/src/System.Management.Automation/utils/PlatformInvokes.cs b/src/System.Management.Automation/utils/PlatformInvokes.cs
index c8dc6290511..b6d919df82e 100644
--- a/src/System.Management.Automation/utils/PlatformInvokes.cs
+++ b/src/System.Management.Automation/utils/PlatformInvokes.cs
@@ -8,7 +8,7 @@
namespace System.Management.Automation
{
- internal class PlatformInvokes
+ internal static class PlatformInvokes
{
[StructLayout(LayoutKind.Sequential)]
internal class FILETIME
diff --git a/src/System.Management.Automation/utils/PsUtils.cs b/src/System.Management.Automation/utils/PsUtils.cs
index 187ed387bc8..e217a8f4788 100644
--- a/src/System.Management.Automation/utils/PsUtils.cs
+++ b/src/System.Management.Automation/utils/PsUtils.cs
@@ -560,7 +560,7 @@ internal static object[] Base64ToArgsConverter(string base64)
/// A simple implementation of CRC32.
/// See "CRC-32 algorithm" in https://en.wikipedia.org/wiki/Cyclic_redundancy_check.
///
- internal class CRC32Hash
+ internal static class CRC32Hash
{
// CRC-32C polynomial representations
private const uint polynomial = 0x1EDC6F41;