From b14d742b6cfe6fbe6dbf257dea3ed9827d86a557 Mon Sep 17 00:00:00 2001 From: Sydney Smith <43417619+SydneyhSmith@users.noreply.github.com> Date: Wed, 9 Oct 2019 14:20:43 -0700 Subject: [PATCH 1/5] Update Telemetry.cs Adding additional Microsoft-owned modules to be tracked at load time in the PowerShell 7 telemetry. --- .../utils/Telemetry.cs | 230 ++++++++++++++++++ 1 file changed, 230 insertions(+) diff --git a/src/System.Management.Automation/utils/Telemetry.cs b/src/System.Management.Automation/utils/Telemetry.cs index ecd1a126aee..f68e22189ba 100644 --- a/src/System.Management.Automation/utils/Telemetry.cs +++ b/src/System.Management.Automation/utils/Telemetry.cs @@ -112,17 +112,247 @@ static ApplicationInsightsTelemetry() // use a hashset when looking for module names, it should be quicker than a string comparison s_knownModules = new HashSet(StringComparer.OrdinalIgnoreCase) { + "AADRM", + "AMAG-SMSPowershell", + "AppxGet", + "AsBuiltReport.PureStorage.FlashArray", + "AtlassianPS.Configuration", + "AutomatiserarSE", + "Avanade.AzureStorage", + "AWS.Tools.ServerMigrationService", + "AWS.Tools.StorageGateway", + "Az", + "Az.DeviceProvisioningServices", + "Az.DeviceProvisioningServices", + "Az.ServiceFabric", + "Az.Storage", + "Az.StorageSync", + "Az.StorageTable", + "Azs.Azurebridge.Admin", + "Azs.Backup.Admin", + "Azs.Commerce.Admin", + "Azs.Compute.Admin", + "Azs.Fabric.Admin", + "Azs.Gallery.Admin", + "Azs.Infrastructureinsights.Admin", + "Azs.Keyvault.Admin", + "Azs.Network.Admin", + "Azs.Storage.Admin", + "Azs.Subscriptions", + "Azs.Subscriptions.Admin", + "Azs.Update.Admin", + "AzStorageTable", + "AzStorageTable.TravisEz13", + "AzStorageTable.TravisEz13", + "Azure", + "Azure.AnalysisServices", + "Azure.Storage", + "Azure.Storage", + "AzureAD", + "AzureBlobStorageProvider", + "AzureRM.*", + "AzureRM.ServiceFabric", + "AzureRmStorageTable", + "AzureStorageTools", + "Backup-BitlockerKeys", + "BetterTls", + "BitdefenderHealth", + "BitTitan.Runbooks.MicrosoftTeams", + "BitTitan.Runbooks.MicrosoftTeams.Beta", + "BitTitan.Runbooks.SkypeForBusinessOnline", + "BitTitan.Runbooks.SkypeForBusinessOnline", + "BitTitan.Runbooks.SkypeForBusinessOnline.Beta", + "BitTitan.Runbooks.SkypeForBusinessOnline.Beta", + "cAzureStorage", + "cDhcpServerDynamicUpdate", + "CentreonPS", + "ChefConfSamples", + "cHyper-V", + "ciSCSI", + "cMsmq", + "Cody.PureStorage.FlashArray.VMware", + "Cody.PureStorage.Pure1", + "CPolydorou.PSISE", + "cRemoteDesktopServices", + "CustomPKI", + "cWindowsErrorReporting", + "DataProtectionManagerCX", + "DefenderASR", + "DefenderMAPS", + "EnterpriseCommander", + "Find-SMBShare", + "GCWindowsUpdate", + "Get-CAzureRMStorageServicesAuthorizationHeader", + "GPRegistryPolicy", + "GreatDismal", + "GroupPolicyDsc", + "GroupPolicyHelper", + "HighriseCmdlets", + "HPC.ACM", + "HPC.ACM.API.PS", + "HPCCCmdlets", + "Hyper-VAdministration", + "IISAdministration", + "IntelliSearch", + "iSCSIDsc", + "ISE_Cew", + "ISEColorTheme.Cmdlets", + "ISEFontSmoothing", + "ISEGit", + "IseHg", + "IsElevated", + "ISEModuleBrowserAddon", + "IsePackV2", + "ISEPresenter", + "ISEPSProject", + "ISERemoteTab", + "ISEScriptAnalyzer", + "ISEScriptAnalyzerAddOn", + "ISEScriptAnalyzerAddOn", + "ISEScriptingGeek", + "ISESteroids", + "ISESteroids", + "ISEThemes", + "maniWebAdministration", + "MarkdownPS", + "Microsoft.AzureStack.ReadinessChecker", + "Microsoft.Crm.PowerShell", + "Microsoft.DiagnosticDataViewer", + "Microsoft.DirectoryServices.MetadirectoryServices.Config", + "Microsoft.Dynamics.Nav.Apps.Management", + "Microsoft.Dynamics.Nav.Apps.Tools", + "Microsoft.Dynamics.Nav.Ide", + "Microsoft.Dynamics.Nav.Management", + "Microsoft.Dynamics.Nav.Model.Tools", + "Microsoft.Dynamics.Nav.Model.Tools.Crm", + "Microsoft.EnterpriseManagement.Warehouse.Cmdlets", + "Microsoft.Medv.Administration.Commands.WorkspacePackager", + "Microsoft.PowerApps.Checker.PowerShell", "Microsoft.PowerShell.Archive", + "Microsoft.PowerShell.Core", + "Microsoft.PowerShell.Diagnostics", "Microsoft.PowerShell.Host", + "Microsoft.PowerShell.LocalAccounts", "Microsoft.PowerShell.Management", + "Microsoft.PowerShell.ODataUtils", + "Microsoft.PowerShell.Operation.Validation", "Microsoft.PowerShell.Security", "Microsoft.PowerShell.Utility", + "Microsoft.SharePoint.Powershell", + "Microsoft.SystemCenter.ServiceManagementAutomation", + "Microsoft.Windows.ServerManager.Migration", + "Microsoft.WSMan.Management", + "Microsoft.WsMan.Management", + "Microsoft.Xrm.OnlineManagementAPI", + "Microsoft.Xrm.Tooling.CrmConnector.PowerShell", + "Microsoft.Xrm.Tooling.PackageDeployment.Powershell", + "Microsoft.Xrm.Tooling.Testing", + "MicrosoftPowerBIMgmt", + "MicrosoftStaffHub", + "MicrosoftTeams", + "MicrosoftTeams", + "MicrosoftTeams", + "mlSqlPs", + "Mprise.Indigo.Nav.IACop", + "MSOnline", + "MSTeams", + "MSWindowsDefender", + "NickDarvey.ServiceFabric.ConnectionStrings", + "NonPSJob", + "nPSDesiredStateConfiguration", + "nPSDesiredStateConfiguration", + "OperationsManager", "PackageManagement", + "PartnerCenter", "Pester", + "PKITools", + "PoShGroupPolicy", + "PoshPctBar", + "PoshWSUS", + "PowerShell.PowerLibrary.ExtendedWebAdministration", "PowerShellGet", + "PowerShellISEModule", + "ProcessMitigations", + "ProductivityTools.PSBackupBitlockerKeys", + "ProvisioningTools", + "PSCrowdstrike", "PSDesiredStateConfiguration", + "PSISE_Addons", + "PsISEProjectExplorer", + "PSISEToggleOutliningAddon", + "psmsgraph", + "PSMSOAuth", + "PSPKI", "PSReadLine", + "PSTeams", + "PSWindowsUpdate", + "PSWsusSpringClean", + "PureStorage.FlashArray.VMware", + "PureStorage.FlashArray.VMware.Configuration", + "PureStorage.FlashArray.VMware.Pure1", + "PureStorage.FlashArray.VMware.RDM", + "PureStorage.FlashArray.VMware.VMFS", + "PureStorage.FlashArray.VMware.VVol", + "PureStorageDbaTools", + "PureStoragePowerShellSDK", + "PureStoragePowerShellToolkit", + "RegardsCitoyenPS", + "RemoteDesktop", + "ServiceFabricSdkContrib", + "ShowDscResourceModule", + "SkypeForBusinessHybridHealth", + "SkypeForBusinessHybridHealth", + "SkypeToolPack", + "SlackDSCResource", + "SMSBroardcast", + "SPMTools", + "SqlServer", + "SteamStorefront", + "StorageDsc", + "StorageGRID-Webscale", + "StoragePre2K12", + "TeamsAnalyzerNode", "ThreadJob", + "UniversalDashboard.Enterprise", + "UniversalDashboard.UDWhiteboard", + "UpdateServicesClientDSC", + "UpdateServicesClientDSC", + "UpdateServicesDsc", + "UpdateServicesDsc", + "VisualStudioTeamServices", + "VMware.VimAutomation.Storage", + "VMware.VimAutomation.Storage", + "VMware.VimAutomation.StorageUtility", + "VMware.VimAutomation.StorageUtility", + "WdsDsc", + "WebAdministrationDsc", + "WindowsBox.WindowsUpdates", + "WindowsDefender", + "WindowsDefenderDsc", + "windowsdiagnosticdata", + "WindowsUpdateSetting", + "xActiveDirectory", + "xBitLocker", + "xBitlocker", + "xDefender", + "xDhcpServer", + "xDismFeature", + "xDnsServer", + "xHyper-V", + "xHyper-V", + "xHyper-VBackup", + "xPSDesiredStateConfiguration", + "xPSDesiredStateConfiguration", + "xPSDesiredStateConfiguration1", + "xSmbShare", + "xSmbShare", + "xSqlPs", + "xSqlPs", + "xStorage", + "xWebAdministration", + "xWebAdministration", + "xWindowsUpdate", + "zWindowsUpdate", }; s_uniqueUserIdentifier = GetUniqueIdentifier().ToString(); From 805e59bf1b2abf39e691fbe99e9309c78ee8856b Mon Sep 17 00:00:00 2001 From: Sydney Smith <43417619+SydneyhSmith@users.noreply.github.com> Date: Thu, 10 Oct 2019 14:53:47 -0700 Subject: [PATCH 2/5] Update Telemetry.cs --- .../utils/Telemetry.cs | 144 +----------------- 1 file changed, 1 insertion(+), 143 deletions(-) diff --git a/src/System.Management.Automation/utils/Telemetry.cs b/src/System.Management.Automation/utils/Telemetry.cs index f68e22189ba..10d8d72314e 100644 --- a/src/System.Management.Automation/utils/Telemetry.cs +++ b/src/System.Management.Automation/utils/Telemetry.cs @@ -113,17 +113,7 @@ static ApplicationInsightsTelemetry() s_knownModules = new HashSet(StringComparer.OrdinalIgnoreCase) { "AADRM", - "AMAG-SMSPowershell", - "AppxGet", - "AsBuiltReport.PureStorage.FlashArray", - "AtlassianPS.Configuration", - "AutomatiserarSE", - "Avanade.AzureStorage", - "AWS.Tools.ServerMigrationService", - "AWS.Tools.StorageGateway", - "Az", - "Az.DeviceProvisioningServices", - "Az.DeviceProvisioningServices", + "Az", "Az.ServiceFabric", "Az.Storage", "Az.StorageSync", @@ -143,78 +133,20 @@ static ApplicationInsightsTelemetry() "Azs.Update.Admin", "AzStorageTable", "AzStorageTable.TravisEz13", - "AzStorageTable.TravisEz13", "Azure", "Azure.AnalysisServices", "Azure.Storage", - "Azure.Storage", "AzureAD", - "AzureBlobStorageProvider", "AzureRM.*", "AzureRM.ServiceFabric", "AzureRmStorageTable", "AzureStorageTools", - "Backup-BitlockerKeys", - "BetterTls", - "BitdefenderHealth", - "BitTitan.Runbooks.MicrosoftTeams", - "BitTitan.Runbooks.MicrosoftTeams.Beta", - "BitTitan.Runbooks.SkypeForBusinessOnline", - "BitTitan.Runbooks.SkypeForBusinessOnline", - "BitTitan.Runbooks.SkypeForBusinessOnline.Beta", - "BitTitan.Runbooks.SkypeForBusinessOnline.Beta", - "cAzureStorage", - "cDhcpServerDynamicUpdate", - "CentreonPS", - "ChefConfSamples", - "cHyper-V", - "ciSCSI", - "cMsmq", - "Cody.PureStorage.FlashArray.VMware", - "Cody.PureStorage.Pure1", - "CPolydorou.PSISE", - "cRemoteDesktopServices", - "CustomPKI", - "cWindowsErrorReporting", - "DataProtectionManagerCX", - "DefenderASR", - "DefenderMAPS", - "EnterpriseCommander", - "Find-SMBShare", - "GCWindowsUpdate", - "Get-CAzureRMStorageServicesAuthorizationHeader", "GPRegistryPolicy", - "GreatDismal", - "GroupPolicyDsc", - "GroupPolicyHelper", - "HighriseCmdlets", "HPC.ACM", "HPC.ACM.API.PS", - "HPCCCmdlets", - "Hyper-VAdministration", "IISAdministration", - "IntelliSearch", - "iSCSIDsc", - "ISE_Cew", - "ISEColorTheme.Cmdlets", - "ISEFontSmoothing", - "ISEGit", - "IseHg", - "IsElevated", "ISEModuleBrowserAddon", - "IsePackV2", - "ISEPresenter", - "ISEPSProject", - "ISERemoteTab", - "ISEScriptAnalyzer", - "ISEScriptAnalyzerAddOn", "ISEScriptAnalyzerAddOn", - "ISEScriptingGeek", - "ISESteroids", - "ISESteroids", - "ISEThemes", - "maniWebAdministration", - "MarkdownPS", "Microsoft.AzureStack.ReadinessChecker", "Microsoft.Crm.PowerShell", "Microsoft.DiagnosticDataViewer", @@ -242,7 +174,6 @@ static ApplicationInsightsTelemetry() "Microsoft.SystemCenter.ServiceManagementAutomation", "Microsoft.Windows.ServerManager.Migration", "Microsoft.WSMan.Management", - "Microsoft.WsMan.Management", "Microsoft.Xrm.OnlineManagementAPI", "Microsoft.Xrm.Tooling.CrmConnector.PowerShell", "Microsoft.Xrm.Tooling.PackageDeployment.Powershell", @@ -250,109 +181,36 @@ static ApplicationInsightsTelemetry() "MicrosoftPowerBIMgmt", "MicrosoftStaffHub", "MicrosoftTeams", - "MicrosoftTeams", - "MicrosoftTeams", "mlSqlPs", - "Mprise.Indigo.Nav.IACop", "MSOnline", - "MSTeams", - "MSWindowsDefender", - "NickDarvey.ServiceFabric.ConnectionStrings", - "NonPSJob", - "nPSDesiredStateConfiguration", - "nPSDesiredStateConfiguration", "OperationsManager", "PackageManagement", "PartnerCenter", "Pester", - "PKITools", - "PoShGroupPolicy", - "PoshPctBar", - "PoshWSUS", - "PowerShell.PowerLibrary.ExtendedWebAdministration", "PowerShellGet", - "PowerShellISEModule", "ProcessMitigations", - "ProductivityTools.PSBackupBitlockerKeys", - "ProvisioningTools", - "PSCrowdstrike", - "PSDesiredStateConfiguration", - "PSISE_Addons", - "PsISEProjectExplorer", - "PSISEToggleOutliningAddon", - "psmsgraph", - "PSMSOAuth", - "PSPKI", "PSReadLine", - "PSTeams", - "PSWindowsUpdate", - "PSWsusSpringClean", - "PureStorage.FlashArray.VMware", - "PureStorage.FlashArray.VMware.Configuration", - "PureStorage.FlashArray.VMware.Pure1", - "PureStorage.FlashArray.VMware.RDM", - "PureStorage.FlashArray.VMware.VMFS", - "PureStorage.FlashArray.VMware.VVol", - "PureStorageDbaTools", - "PureStoragePowerShellSDK", - "PureStoragePowerShellToolkit", - "RegardsCitoyenPS", - "RemoteDesktop", - "ServiceFabricSdkContrib", - "ShowDscResourceModule", - "SkypeForBusinessHybridHealth", "SkypeForBusinessHybridHealth", - "SkypeToolPack", - "SlackDSCResource", - "SMSBroardcast", - "SPMTools", "SqlServer", - "SteamStorefront", "StorageDsc", - "StorageGRID-Webscale", - "StoragePre2K12", - "TeamsAnalyzerNode", - "ThreadJob", - "UniversalDashboard.Enterprise", - "UniversalDashboard.UDWhiteboard", - "UpdateServicesClientDSC", - "UpdateServicesClientDSC", - "UpdateServicesDsc", - "UpdateServicesDsc", - "VisualStudioTeamServices", - "VMware.VimAutomation.Storage", - "VMware.VimAutomation.Storage", - "VMware.VimAutomation.StorageUtility", - "VMware.VimAutomation.StorageUtility", - "WdsDsc", "WebAdministrationDsc", - "WindowsBox.WindowsUpdates", "WindowsDefender", "WindowsDefenderDsc", "windowsdiagnosticdata", - "WindowsUpdateSetting", "xActiveDirectory", "xBitLocker", - "xBitlocker", "xDefender", "xDhcpServer", "xDismFeature", "xDnsServer", "xHyper-V", - "xHyper-V", "xHyper-VBackup", "xPSDesiredStateConfiguration", - "xPSDesiredStateConfiguration", - "xPSDesiredStateConfiguration1", - "xSmbShare", "xSmbShare", "xSqlPs", - "xSqlPs", "xStorage", "xWebAdministration", - "xWebAdministration", "xWindowsUpdate", - "zWindowsUpdate", }; s_uniqueUserIdentifier = GetUniqueIdentifier().ToString(); From d1096e145896b7a896b43026acb6ee535454108c Mon Sep 17 00:00:00 2001 From: Sydney Smith <43417619+SydneyhSmith@users.noreply.github.com> Date: Fri, 11 Oct 2019 10:42:40 -0700 Subject: [PATCH 3/5] Update Telemetry.cs Updating to include non-gallery modules queried from Microsoft Docs. --- .../utils/Telemetry.cs | 330 +++++++++++++++++- 1 file changed, 328 insertions(+), 2 deletions(-) diff --git a/src/System.Management.Automation/utils/Telemetry.cs b/src/System.Management.Automation/utils/Telemetry.cs index 10d8d72314e..e94fc9a1e5d 100644 --- a/src/System.Management.Automation/utils/Telemetry.cs +++ b/src/System.Management.Automation/utils/Telemetry.cs @@ -113,11 +113,99 @@ static ApplicationInsightsTelemetry() s_knownModules = new HashSet(StringComparer.OrdinalIgnoreCase) { "AADRM", - "Az", + "activedirectory", + "adcsadministration", + "adcsdeployment", + "addsadministration", + "addsdeployment", + "adfs", + "adrms", + "adrmsadmin", + "agpm", + "appbackgroundtask", + "applocker", + "appv", + "appvclient", + "appvsequencer", + "appvserver", + "appx", + "assignedaccess", + "Az", + "Az.Accounts", + "Az.Advisor", + "Az.Aks", + "Az.AlertsManagement", + "Az.AnalysisServices", + "Az.ApiManagement", + "Az.ApplicationInsights", + "Az.Attestation", + "Az.Automation", + "Az.Batch", + "Az.Billing", + "Az.Blueprint", + "Az.Cdn", + "Az.CognitiveServices", + "Az.Compute", + "Az.ContainerInstance", + "Az.ContainerRegistry", + "Az.DataBox", + "Az.DataFactory", + "Az.DataLakeAnalytics", + "Az.DataLakeStore", + "Az.DataMigration", + "Az.DataShare", + "Az.DeploymentManager", + "Az.DeviceProvisioningServices", + "Az.DevSpaces", + "Az.DevTestLabs", + "Az.Dns", + "Az.EventGrid", + "Az.EventHub", + "Az.FrontDoor", + "Az.GuestConfiguration", + "Az.HDInsight", + "Az.HealthcareApis", + "Az.IotCentral", + "Az.IotHub", + "Az.KeyVault", + "Az.Kusto", + "Az.LogicApp", + "Az.MachineLearning", + "Az.ManagedServiceIdentity", + "Az.ManagedServices", + "Az.ManagementPartner", + "Az.Maps", + "Az.MarketplaceOrdering", + "Az.Media", + "Az.MixedReality", + "Az.Monitor", + "Az.NetAppFiles", + "Az.Network", + "Az.NotificationHubs", + "Az.OperationalInsights", + "Az.Peering", + "Az.PolicyInsights", + "Az.PowerBIEmbedded", + "Az.PrivateDns", + "Az.RecoveryServices", + "Az.RedisCache", + "Az.Relay", + "Az.Reservations", + "Az.ResourceGraph", + "Az.Resources", + "Az.Search", + "Az.Security", + "Az.ServiceBus", "Az.ServiceFabric", + "Az.SignalR", + "Az.Sql", "Az.Storage", "Az.StorageSync", "Az.StorageTable", + "Az.StreamAnalytics", + "Az.Subscription", + "Az.TrafficManager", + "Az.Websites", "Azs.Azurebridge.Admin", "Azs.Backup.Admin", "Azs.Commerce.Admin", @@ -137,16 +225,143 @@ static ApplicationInsightsTelemetry() "Azure.AnalysisServices", "Azure.Storage", "AzureAD", - "AzureRM.*", + "AzureInformationProtection", + "AzureRM.Aks", + "AzureRM.AnalysisServices", + "AzureRM.ApiManagement", + "AzureRM.ApplicationInsights", + "AzureRM.Automation", + "AzureRM.Backup", + "AzureRM.Batch", + "AzureRM.Billing", + "AzureRM.Cdn", + "AzureRM.CognitiveServices", + "AzureRm.Compute", + "AzureRM.Compute.ManagedService", + "AzureRM.Consumption", + "AzureRM.ContainerInstance", + "AzureRM.ContainerRegistry", + "AzureRM.DataFactories", + "AzureRM.DataFactoryV2", + "AzureRM.DataLakeAnalytics", + "AzureRM.DataLakeStore", + "AzureRM.DataMigration", + "AzureRM.DeploymentManager", + "AzureRM.DeviceProvisioningServices", + "AzureRM.DevSpaces", + "AzureRM.DevTestLabs", + "AzureRm.Dns", + "AzureRM.EventGrid", + "AzureRM.EventHub", + "AzureRM.FrontDoor", + "AzureRM.HDInsight", + "AzureRm.Insights", + "AzureRM.IotCentral", + "AzureRM.IotHub", + "AzureRm.Keyvault", + "AzureRM.LocationBasedServices", + "AzureRM.LogicApp", + "AzureRM.MachineLearning", + "AzureRM.MachineLearningCompute", + "AzureRM.ManagedServiceIdentity", + "AzureRM.ManagementPartner", + "AzureRM.Maps", + "AzureRM.MarketplaceOrdering", + "AzureRM.Media", + "AzureRM.Network", + "AzureRM.NotificationHubs", + "AzureRM.OperationalInsights", + "AzureRM.PolicyInsights", + "AzureRM.PowerBIEmbedded", + "AzureRM.Profile", + "AzureRM.RecoveryServices", + "AzureRM.RecoveryServices.Backup", + "AzureRM.RecoveryServices.SiteRecovery", + "AzureRM.RedisCache", + "AzureRM.Relay", + "AzureRM.Reservations", + "AzureRM.ResourceGraph", + "AzureRM.Resources", + "AzureRM.Scheduler", + "AzureRM.Search", + "AzureRM.Security", + "AzureRM.ServerManagement", + "AzureRM.ServiceBus", "AzureRM.ServiceFabric", + "AzureRM.SignalR", + "AzureRM.SiteRecovery", + "AzureRM.Sql", + "AzureRm.Storage", + "AzureRM.StorageSync", + "AzureRM.StreamAnalytics", + "AzureRM.Subscription", + "AzureRM.Subscription.Preview", + "AzureRM.Tags", + "AzureRM.TrafficManager", + "AzureRm.UsageAggregates", + "AzureRm.Websites", "AzureRmStorageTable", "AzureStorageTools", + "bestpractices", + "bitlocker", + "bitstransfer", + "booteventcollector", + "branchcache", + "CimCmdlets", + "clusterawareupdating", + "configci", + "ConfigurationManager", + "DataProtectionManager", + "dcbqos", + "deduplication", + "defender", + "devicehealthattestation", + "dfsn", + "dfsr", + "dhcpserver", + "directaccessclient", + "directaccessclientcomponent", + "directaccessclientcomponents", + "dism", + "dnsclient", + "dnsserver", + "ElasticDatabaseJobs", + "eventtracmancmdlets", + "failoverclusters", + "fileserverresourcemanager", + "FIMAutomation", "GPRegistryPolicy", + "grouppolicy", + "hardwarecertification", + "hcs", + "hgsattestation", + "hgsclient", + "hgsdiagnostics", + "hgskeyprotection", + "hgsserver", + "hnvdiagnostics", + "hostcomputeservice", + "hpc", "HPC.ACM", "HPC.ACM.API.PS", + "HPCPack2016", + "hyper-v", "IISAdministration", + "international", + "internationalcmdlets", + "ipamserver", + "iscsi", + "iscsitarget", + "ISE", "ISEModuleBrowserAddon", "ISEScriptAnalyzerAddOn", + "kds", + "mbam", + "medv", + "MgmtSvcAdmin", + "MgmtSvcConfig", + "MgmtSvcMySql", + "MgmtSvcSqlServer", "Microsoft.AzureStack.ReadinessChecker", "Microsoft.Crm.PowerShell", "Microsoft.DiagnosticDataViewer", @@ -176,27 +391,138 @@ static ApplicationInsightsTelemetry() "Microsoft.WSMan.Management", "Microsoft.Xrm.OnlineManagementAPI", "Microsoft.Xrm.Tooling.CrmConnector.PowerShell", + "Microsoft.Xrm.Tooling.PackageDeployment", "Microsoft.Xrm.Tooling.PackageDeployment.Powershell", "Microsoft.Xrm.Tooling.Testing", "MicrosoftPowerBIMgmt", + "MicrosoftPowerBIMgmt.Data", + "MicrosoftPowerBIMgmt.Profile", + "MicrosoftPowerBIMgmt.Reports", + "MicrosoftPowerBIMgmt.Workspaces", "MicrosoftStaffHub", "MicrosoftTeams", + "MIMPAM", "mlSqlPs", + "mmagent", + "mpio", + "msdtc", + "msmq", "MSOnline", + "msonlinebackup", + "multipoint", + "multipointvdi", + "nanoserverimagegenerator", + "NAVWebClientManagement", + "netadapter", + "netconnection", + "neteventpacketcapture", + "netlbfo", + "netldpagent", + "netnat", + "netqos", + "netsecurity", + "netswitchteam", + "nettcpip", + "netwnv", + "networkconnectivity", + "networkconnectivitystatus", + "networkcontroller", + "networkcontrollerdiagnostics", + "networkloadbalancingclusters", + "networkswitchmanager", + "networktransition", + "nfs", + "nps", + "officewebapps", "OperationsManager", "PackageManagement", "PartnerCenter", + "pcsvdevice", + "pef", "Pester", + "pkiclient", + "platformidentifier", + "pnpdevice", "PowerShellGet", + "powershellwebaccess", + "printmanagement", "ProcessMitigations", + "provisioning", + "PSDesiredStateConfiguration", + "PSDiagnostics", "PSReadLine", + "PSScheduledJob", + "PSWorkflow", + "PSWorkflowUtility", + "remoteaccess", + "remotedesktop", + "remotedesktopservices", + "scheduledtasks", + "secureboot", + "servercore", + "servermanager", + "servermanagertasks", + "servermigration", + "servermigrationcmdlets", + "ServiceFabric", + "sharepoint-online", + "sharepoint-server", + "shieldedvmdatafile", + "shieldedvmprovisioning", + "shieldedvmtemplate", + "skype", "SkypeForBusinessHybridHealth", + "smbshare", + "smbwitness", + "smisconfig", + "softwareinventorylogging", + "SPFAdmin", + "spmt", + "sqlps", "SqlServer", + "staffhub", + "startlayout", + "startscreen", + "storage", "StorageDsc", + "storageqos", + "storagereplica", + "storagespaces", + "syncshare", + "System.Center.Service.Manager", + "teams", + "tls", + "troubleshootingpack", + "trustedplatformmodule", + "uev", + "updateservices", + "useraccesslogging", + "vamt", + "VirtualMachineManager", + "vpnclient", + "waspsext", + "wdac", + "wds", + "webadministration", "WebAdministrationDsc", + "webadminstration", + "webapplicationproxy", + "WebSites", + "whea", + "whiteboard", "WindowsDefender", "WindowsDefenderDsc", + "windowsdeveloperlicense", + "windowsdevlic", "windowsdiagnosticdata", + "windowserrorreporting", + "windowserverbackup", + "windowssearch", + "windowsserverbackup", + "windowsupdate", + "wsscmdlets", + "wsssetup", + "wsus", "xActiveDirectory", "xBitLocker", "xDefender", From b04b62def0495386eb747650713069c2df6e0d4b Mon Sep 17 00:00:00 2001 From: Sydney Smith <43417619+SydneyhSmith@users.noreply.github.com> Date: Wed, 4 Dec 2019 13:20:35 -0800 Subject: [PATCH 4/5] Apply suggestions from code review Co-Authored-By: Joey Aiello --- .../utils/Telemetry.cs | 39 +++++++------------ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/src/System.Management.Automation/utils/Telemetry.cs b/src/System.Management.Automation/utils/Telemetry.cs index e94fc9a1e5d..ebcc40afb51 100644 --- a/src/System.Management.Automation/utils/Telemetry.cs +++ b/src/System.Management.Automation/utils/Telemetry.cs @@ -220,7 +220,6 @@ static ApplicationInsightsTelemetry() "Azs.Subscriptions.Admin", "Azs.Update.Admin", "AzStorageTable", - "AzStorageTable.TravisEz13", "Azure", "Azure.AnalysisServices", "Azure.Storage", @@ -301,7 +300,6 @@ static ApplicationInsightsTelemetry() "AzureRm.UsageAggregates", "AzureRm.Websites", "AzureRmStorageTable", - "AzureStorageTools", "bestpractices", "bitlocker", "bitstransfer", @@ -348,16 +346,14 @@ static ApplicationInsightsTelemetry() "hyper-v", "IISAdministration", "international", - "internationalcmdlets", "ipamserver", "iscsi", "iscsitarget", "ISE", "ISEModuleBrowserAddon", - "ISEScriptAnalyzerAddOn", "kds", - "mbam", - "medv", + "Microsoft.MBAM", + "Microsoft.MEDV", "MgmtSvcAdmin", "MgmtSvcConfig", "MgmtSvcMySql", @@ -403,15 +399,15 @@ static ApplicationInsightsTelemetry() "MicrosoftTeams", "MIMPAM", "mlSqlPs", - "mmagent", - "mpio", - "msdtc", - "msmq", + "MMAgent", + "MPIO", + "MsDtc", + "MSMQ", "MSOnline", - "msonlinebackup", - "multipoint", - "multipointvdi", - "nanoserverimagegenerator", + "MSOnlineBackup", + "WmsCmdlets", + "WmsCmdlets3", + "NanoServerImageGenerator", "NAVWebClientManagement", "netadapter", "netconnection", @@ -462,25 +458,22 @@ static ApplicationInsightsTelemetry() "servercore", "servermanager", "servermanagertasks", - "servermigration", "servermigrationcmdlets", "ServiceFabric", - "sharepoint-online", - "sharepoint-server", + "Microsoft.Online.SharePoint.PowerShell", "shieldedvmdatafile", "shieldedvmprovisioning", "shieldedvmtemplate", - "skype", + "SkypeOnlineConnector", "SkypeForBusinessHybridHealth", "smbshare", "smbwitness", "smisconfig", "softwareinventorylogging", "SPFAdmin", - "spmt", + "Microsoft.SharePoint.MigrationTool.PowerShell", "sqlps", "SqlServer", - "staffhub", "startlayout", "startscreen", "storage", @@ -490,7 +483,6 @@ static ApplicationInsightsTelemetry() "storagespaces", "syncshare", "System.Center.Service.Manager", - "teams", "tls", "troubleshootingpack", "trustedplatformmodule", @@ -500,7 +492,7 @@ static ApplicationInsightsTelemetry() "vamt", "VirtualMachineManager", "vpnclient", - "waspsext", + "WasPSExt", "wdac", "wds", "webadministration", @@ -509,11 +501,10 @@ static ApplicationInsightsTelemetry() "webapplicationproxy", "WebSites", "whea", - "whiteboard", + "WhiteboardAdmin", "WindowsDefender", "WindowsDefenderDsc", "windowsdeveloperlicense", - "windowsdevlic", "windowsdiagnosticdata", "windowserrorreporting", "windowserverbackup", From 700b1d53776b96be0535f338ed67d0b874dec3e2 Mon Sep 17 00:00:00 2001 From: Sydney Smith <43417619+SydneyhSmith@users.noreply.github.com> Date: Wed, 4 Dec 2019 13:29:06 -0800 Subject: [PATCH 5/5] Update Telemetry.cs --- .../utils/Telemetry.cs | 112 +++++++++--------- 1 file changed, 55 insertions(+), 57 deletions(-) diff --git a/src/System.Management.Automation/utils/Telemetry.cs b/src/System.Management.Automation/utils/Telemetry.cs index ebcc40afb51..d6725d5757c 100644 --- a/src/System.Management.Automation/utils/Telemetry.cs +++ b/src/System.Management.Automation/utils/Telemetry.cs @@ -324,7 +324,7 @@ static ApplicationInsightsTelemetry() "dnsclient", "dnsserver", "ElasticDatabaseJobs", - "eventtracmancmdlets", + "EventTracingManagement", "failoverclusters", "fileserverresourcemanager", "FIMAutomation", @@ -350,7 +350,6 @@ static ApplicationInsightsTelemetry() "iscsi", "iscsitarget", "ISE", - "ISEModuleBrowserAddon", "kds", "Microsoft.MBAM", "Microsoft.MEDV", @@ -409,27 +408,27 @@ static ApplicationInsightsTelemetry() "WmsCmdlets3", "NanoServerImageGenerator", "NAVWebClientManagement", - "netadapter", - "netconnection", - "neteventpacketcapture", - "netlbfo", - "netldpagent", - "netnat", - "netqos", - "netsecurity", - "netswitchteam", - "nettcpip", - "netwnv", - "networkconnectivity", - "networkconnectivitystatus", - "networkcontroller", - "networkcontrollerdiagnostics", - "networkloadbalancingclusters", - "networkswitchmanager", - "networktransition", - "nfs", - "nps", - "officewebapps", + "NetAdapter", + "NetConnection", + "NetEventPacketCapture", + "Netlbfo", + "Netldpagent", + "NetNat", + "Netqos", + "NetSecurity", + "NetSwitchtTeam", + "Nettcpip", + "Netwnv", + "NetworkConnectivity", + "NetworkConnectivityStatus", + "NetworkController", + "NetworkControllerDiagnostics", + "NetworkloadBalancingClusters", + "NetworkSwitchManager", + "NetworkTransition", + "NFS", + "NPS", + "OfficeWebapps", "OperationsManager", "PackageManagement", "PartnerCenter", @@ -450,15 +449,15 @@ static ApplicationInsightsTelemetry() "PSScheduledJob", "PSWorkflow", "PSWorkflowUtility", - "remoteaccess", - "remotedesktop", - "remotedesktopservices", - "scheduledtasks", - "secureboot", - "servercore", - "servermanager", - "servermanagertasks", - "servermigrationcmdlets", + "RemoteAccess", + "RemoteDesktop", + "RemoteDesktopServices", + "ScheduledTasks", + "Secureboot", + "ServerCore", + "ServerManager", + "ServerManagerTasks", + "ServerMigrationcmdlets", "ServiceFabric", "Microsoft.Online.SharePoint.PowerShell", "shieldedvmdatafile", @@ -474,43 +473,42 @@ static ApplicationInsightsTelemetry() "Microsoft.SharePoint.MigrationTool.PowerShell", "sqlps", "SqlServer", - "startlayout", - "startscreen", - "storage", + "StartLayout", + "StartScreen", + "Storage", "StorageDsc", "storageqos", - "storagereplica", - "storagespaces", - "syncshare", + "Storagereplica", + "Storagespaces", + "Syncshare", "System.Center.Service.Manager", - "tls", - "troubleshootingpack", - "trustedplatformmodule", - "uev", - "updateservices", - "useraccesslogging", + "TLS", + "TroubleshootingPack", + "TrustedPlatformModule", + "UEV", + "UpdateServices", + "UserAccessLogging", "vamt", "VirtualMachineManager", "vpnclient", "WasPSExt", - "wdac", - "wds", - "webadministration", + "WDAC", + "WDS", + "WebAdministration", "WebAdministrationDsc", - "webadminstration", - "webapplicationproxy", + "WebApplicationProxy", "WebSites", - "whea", + "Whea", "WhiteboardAdmin", "WindowsDefender", "WindowsDefenderDsc", - "windowsdeveloperlicense", - "windowsdiagnosticdata", - "windowserrorreporting", - "windowserverbackup", - "windowssearch", - "windowsserverbackup", - "windowsupdate", + "WindowsDeveloperLicense", + "WindowsDiagnosticData", + "WindowsErrorReporting", + "WindowServerRackup", + "WindowsSearch", + "WindowsServerBackup", + "WindowsUpdate", "wsscmdlets", "wsssetup", "wsus",