Enable SA1507: Code should not contain multiple blank lines in a row (#14136)

xtqqczze · web-flow · commit d92984106a6b · 2020-11-20T16:17:45.000+05:00
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1507.md
diff --git a/.globalconfig b/.globalconfig
@@ -1374,7 +1374,7 @@ dotnet_diagnostic.SA1505.severity = none
 dotnet_diagnostic.SA1506.severity = none
 
 # SA1507: Code should not contain multiple blank lines in a row
-dotnet_diagnostic.SA1507.severity = none
+dotnet_diagnostic.SA1507.severity = warning
 
 # SA1508: Closing braces should not be preceded by blank line
 dotnet_diagnostic.SA1508.severity = none
diff --git a/src/System.Management.Automation/engine/TypeTable_Types_Ps1Xml.cs b/src/System.Management.Automation/engine/TypeTable_Types_Ps1Xml.cs
@@ -9227,7 +9227,6 @@ private void Process_Types_Ps1Xml(string filePath, ConcurrentBag<string> errors)
 #if UNIX
             #region UnixStat
 
-
             if (ExperimentalFeature.IsEnabled("PSUnixFileStat"))
             {
                 typeName = @"System.IO.FileSystemInfo";
diff --git a/src/powershell/Program.cs b/src/powershell/Program.cs
@@ -185,7 +185,6 @@ private static void AttemptExecPwshLogin(string[] args)
                     // We can reuse this value later to prevent needing to call a .NET API
                     // to generate our exec invocation.
 
-
                     // We don't care about argc's value, since argv[0] must always exist.
                     // Skip over argc, but remember where exec_path is for later
                     executablePathPtr = IntPtr.Add(procargs, sizeof(int));
diff --git a/test/tools/WebListener/Controllers/DosController.cs b/test/tools/WebListener/Controllers/DosController.cs
@@ -22,7 +22,6 @@ public string Index()
 
             Response.StatusCode = 200;
 
-
             StringValues dosType;
             if (Request.Query.TryGetValue("dosType", out dosType))
             {

Original file line number	Diff line number	Diff line change
`@@ -9227,7 +9227,6 @@ private void Process_Types_Ps1Xml(string filePath, ConcurrentBag<string> errors)`
`9227`	`9227`	`#if UNIX`
`9228`	`9228`	`#region UnixStat`
`9229`	`9229`
`9230`		`-`
`9231`	`9230`	`if (ExperimentalFeature.IsEnabled("PSUnixFileStat"))`
`9232`	`9231`	`{`
`9233`	`9232`	`typeName = @"System.IO.FileSystemInfo";`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ public string Index()`
`22`	`22`
`23`	`23`	`Response.StatusCode = 200;`
`24`	`24`
`25`		`-`
`26`	`25`	`StringValues dosType;`
`27`	`26`	`if (Request.Query.TryGetValue("dosType", out dosType))`
`28`	`27`	`{`