Skip to content

Commit b7a431a

Browse files
xtqqczzextqqczze
authored
Fix SA1504: All accessors should be single-line or multi-lin (#14241)
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
1 parent bb55515 commit b7a431a

File tree

88 files changed

+1049
-263
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+1049
-263
lines changed

‎.globalconfig‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1368,7 +1368,7 @@ dotnet_diagnostic.SA1502.severity = none
13681368
dotnet_diagnostic.SA1503.severity = none
13691369

13701370
# SA1504: All accessors should be single-line or multi-line
1371-
dotnet_diagnostic.SA1504.severity = none
1371+
dotnet_diagnostic.SA1504.severity = warning
13721372

13731373
# SA1505: Opening braces should not be followed by blank line
13741374
dotnet_diagnostic.SA1505.severity = none

‎src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimAssociatedInstanceCommand.cs‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ public GetCimAssociatedInstanceCommand()
7676
[Alias(CimBaseCommand.AliasCimInstance)]
7777
public CimInstance InputObject
7878
{
79-
get { return CimInstance; }
79+
get
80+
{
81+
return CimInstance;
82+
}
8083

8184
set
8285
{
@@ -118,7 +121,10 @@ public CimInstance InputObject
118121
[Parameter]
119122
public Uri ResourceUri
120123
{
121-
get { return resourceUri; }
124+
get
125+
{
126+
return resourceUri;
127+
}
122128

123129
set
124130
{
@@ -146,7 +152,10 @@ public Uri ResourceUri
146152
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
147153
public string[] ComputerName
148154
{
149-
get { return computerName; }
155+
get
156+
{
157+
return computerName;
158+
}
150159

151160
set
152161
{
@@ -168,7 +177,10 @@ public string[] ComputerName
168177
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
169178
public Microsoft.Management.Infrastructure.CimSession[] CimSession
170179
{
171-
get { return cimSession; }
180+
get
181+
{
182+
return cimSession;
183+
}
172184

173185
set
174186
{

‎src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimClassCommand.cs‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,10 @@ public GetCimClassCommand()
9292
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
9393
public CimSession[] CimSession
9494
{
95-
get { return cimSession; }
95+
get
96+
{
97+
return cimSession;
98+
}
9699

97100
set
98101
{
@@ -118,7 +121,10 @@ public CimSession[] CimSession
118121
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
119122
public string[] ComputerName
120123
{
121-
get { return computerName; }
124+
get
125+
{
126+
return computerName;
127+
}
122128

123129
set
124130
{

‎src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimInstanceCommand.cs‎

Lines changed: 48 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,10 @@ public GetCimInstanceCommand()
6363
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
6464
public CimSession[] CimSession
6565
{
66-
get { return cimSession; }
66+
get
67+
{
68+
return cimSession;
69+
}
6770

6871
set
6972
{
@@ -90,7 +93,10 @@ public CimSession[] CimSession
9093
ParameterSetName = CimBaseCommand.ClassNameComputerSet)]
9194
public string ClassName
9295
{
93-
get { return className; }
96+
get
97+
{
98+
return className;
99+
}
94100

95101
set
96102
{
@@ -125,7 +131,10 @@ public string ClassName
125131
ParameterSetName = CimBaseCommand.QuerySessionSet)]
126132
public Uri ResourceUri
127133
{
128-
get { return resourceUri; }
134+
get
135+
{
136+
return resourceUri;
137+
}
129138

130139
set
131140
{
@@ -161,7 +170,10 @@ public Uri ResourceUri
161170
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
162171
public string[] ComputerName
163172
{
164-
get { return computerName; }
173+
get
174+
{
175+
return computerName;
176+
}
165177

166178
set
167179
{
@@ -185,7 +197,10 @@ public string[] ComputerName
185197
[Parameter(ParameterSetName = CimBaseCommand.ResourceUriSessionSet)]
186198
public SwitchParameter KeyOnly
187199
{
188-
get { return keyOnly; }
200+
get
201+
{
202+
return keyOnly;
203+
}
189204

190205
set
191206
{
@@ -220,7 +235,10 @@ public SwitchParameter KeyOnly
220235
ParameterSetName = CimBaseCommand.QuerySessionSet)]
221236
public string Namespace
222237
{
223-
get { return nameSpace; }
238+
get
239+
{
240+
return nameSpace;
241+
}
224242

225243
set
226244
{
@@ -270,7 +288,10 @@ public string Namespace
270288
[Alias(CimBaseCommand.AliasCimInstance)]
271289
public CimInstance InputObject
272290
{
273-
get { return CimInstance; }
291+
get
292+
{
293+
return CimInstance;
294+
}
274295

275296
set
276297
{
@@ -297,7 +318,10 @@ public CimInstance InputObject
297318
ParameterSetName = CimBaseCommand.QuerySessionSet)]
298319
public string Query
299320
{
300-
get { return query; }
321+
get
322+
{
323+
return query;
324+
}
301325

302326
set
303327
{
@@ -326,7 +350,10 @@ public string Query
326350

327351
public string QueryDialect
328352
{
329-
get { return queryDialect; }
353+
get
354+
{
355+
return queryDialect;
356+
}
330357

331358
set
332359
{
@@ -354,7 +381,10 @@ public string QueryDialect
354381
[Parameter(ParameterSetName = CimBaseCommand.QuerySessionSet)]
355382
public SwitchParameter Shallow
356383
{
357-
get { return shallow; }
384+
get
385+
{
386+
return shallow;
387+
}
358388

359389
set
360390
{
@@ -381,7 +411,10 @@ public SwitchParameter Shallow
381411
ParameterSetName = CimBaseCommand.ResourceUriComputerSet)]
382412
public string Filter
383413
{
384-
get { return filter; }
414+
get
415+
{
416+
return filter;
417+
}
385418

386419
set
387420
{
@@ -410,7 +443,10 @@ public string Filter
410443
[Alias("SelectProperties")]
411444
public string[] Property
412445
{
413-
get { return SelectProperties; }
446+
get
447+
{
448+
return SelectProperties;
449+
}
414450

415451
set
416452
{

‎src/Microsoft.Management.Infrastructure.CimCmdlets/GetCimSessionCommand.cs‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,10 @@ public GetCimSessionCommand()
5858
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
5959
public string[] ComputerName
6060
{
61-
get { return computername; }
61+
get
62+
{
63+
return computername;
64+
}
6265

6366
set
6467
{
@@ -80,7 +83,10 @@ public string[] ComputerName
8083
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
8184
public UInt32[] Id
8285
{
83-
get { return id; }
86+
get
87+
{
88+
return id;
89+
}
8490

8591
set
8692
{
@@ -101,7 +107,10 @@ public UInt32[] Id
101107
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
102108
public Guid[] InstanceId
103109
{
104-
get { return instanceid; }
110+
get
111+
{
112+
return instanceid;
113+
}
105114

106115
set
107116
{
@@ -123,7 +132,10 @@ public Guid[] InstanceId
123132
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
124133
public string[] Name
125134
{
126-
get { return name; }
135+
get
136+
{
137+
return name;
138+
}
127139

128140
set
129141
{

‎src/Microsoft.Management.Infrastructure.CimCmdlets/InvokeCimMethodCommand.cs‎

Lines changed: 40 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,10 @@ public InvokeCimMethodCommand()
5454
[Alias("Class")]
5555
public string ClassName
5656
{
57-
get { return className; }
57+
get
58+
{
59+
return className;
60+
}
5861

5962
set
6063
{
@@ -83,7 +86,10 @@ public string ClassName
8386
ParameterSetName = CimBaseCommand.ResourceUriSessionSet)]
8487
public Uri ResourceUri
8588
{
86-
get { return resourceUri; }
89+
get
90+
{
91+
return resourceUri;
92+
}
8793

8894
set
8995
{
@@ -108,7 +114,10 @@ public Uri ResourceUri
108114
ParameterSetName = CimClassSessionSet)]
109115
public CimClass CimClass
110116
{
111-
get { return cimClass; }
117+
get
118+
{
119+
return cimClass;
120+
}
112121

113122
set
114123
{
@@ -131,7 +140,10 @@ public CimClass CimClass
131140
ParameterSetName = CimBaseCommand.QuerySessionSet)]
132141
public string Query
133142
{
134-
get { return query; }
143+
get
144+
{
145+
return query;
146+
}
135147

136148
set
137149
{
@@ -155,7 +167,10 @@ public string Query
155167
ParameterSetName = CimBaseCommand.QuerySessionSet)]
156168
public string QueryDialect
157169
{
158-
get { return queryDialect; }
170+
get
171+
{
172+
return queryDialect;
173+
}
159174

160175
set
161176
{
@@ -182,7 +197,10 @@ public string QueryDialect
182197
[Alias(CimBaseCommand.AliasCimInstance)]
183198
public CimInstance InputObject
184199
{
185-
get { return CimInstance; }
200+
get
201+
{
202+
return CimInstance;
203+
}
186204

187205
set
188206
{
@@ -224,7 +242,10 @@ public CimInstance InputObject
224242
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
225243
public string[] ComputerName
226244
{
227-
get { return computerName; }
245+
get
246+
{
247+
return computerName;
248+
}
228249

229250
set
230251
{
@@ -264,7 +285,10 @@ public string[] ComputerName
264285
[SuppressMessage("Microsoft.Performance", "CA1819:PropertiesShouldNotReturnArrays")]
265286
public CimSession[] CimSession
266287
{
267-
get { return cimSession; }
288+
get
289+
{
290+
return cimSession;
291+
}
268292

269293
set
270294
{
@@ -294,7 +318,10 @@ public CimSession[] CimSession
294318
[Alias("Name")]
295319
public string MethodName
296320
{
297-
get { return methodName; }
321+
get
322+
{
323+
return methodName;
324+
}
298325

299326
set
300327
{
@@ -325,7 +352,10 @@ public string MethodName
325352
ParameterSetName = CimBaseCommand.ResourceUriSessionSet)]
326353
public string Namespace
327354
{
328-
get { return nameSpace; }
355+
get
356+
{
357+
return nameSpace;
358+
}
329359

330360
set
331361
{

0 commit comments

Comments
 (0)