Fix CA1822: Mark members as static part 6 (#14229)

xtqqczze · web-flow · commit 8c8487cc7857 · 2020-11-24T12:28:19.000+05:00
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822
diff --git a/src/Microsoft.PowerShell.Security/security/AclCommands.cs b/src/Microsoft.PowerShell.Security/security/AclCommands.cs
@@ -1060,7 +1060,7 @@ public SwitchParameter Passthru
         /// Returns a newly allocated SACL with no ACEs in it.
         /// Free the returned SACL by calling Marshal.FreeHGlobal.
         /// </summary>
-        private IntPtr GetEmptySacl()
+        private static IntPtr GetEmptySacl()
         {
             IntPtr pSacl = IntPtr.Zero;
             bool ret = true;
@@ -1246,7 +1246,7 @@ private IntPtr GetSaclWithCapId(string capStr)
         /// and the previous state of this privilege. Free the returned token
         /// by calling NativeMethods.CloseHandle.
         /// </summary>
-        private IntPtr GetTokenWithEnabledPrivilege(
+        private static IntPtr GetTokenWithEnabledPrivilege(
             string privilege,
             NativeMethods.TOKEN_PRIVILEGE previousState)
         {
diff --git a/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs b/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
@@ -1374,7 +1374,7 @@ private void AttemptToImportPkiModule()
             _hasAttemptedToLoadPkiModule = true;
         }
 
-        private string MyGetChildName(string path)
+        private static string MyGetChildName(string path)
         {
             // Verify the parameters
 
@@ -1920,7 +1920,7 @@ private void DoRemove(X509Certificate2 cert, bool fDeleteKey, bool fMachine, str
         /// </summary>
         /// <param name="storeHandle">An IntPtr for store handle.</param>
         /// <returns>No return.</returns>
-        private void CommitUserDS(IntPtr storeHandle)
+        private static void CommitUserDS(IntPtr storeHandle)
         {
             if (!Security.NativeMethods.CertControlStore(
                                         storeHandle,

Original file line number	Diff line number	Diff line change
`@@ -1374,7 +1374,7 @@ private void AttemptToImportPkiModule()`
`1374`	`1374`	`_hasAttemptedToLoadPkiModule = true;`
`1375`	`1375`	`}`
`1376`	`1376`
`1377`		`- private string MyGetChildName(string path)`
	`1377`	`+ private static string MyGetChildName(string path)`
`1378`	`1378`	`{`
`1379`	`1379`	`// Verify the parameters`
`1380`	`1380`
`@@ -1920,7 +1920,7 @@ private void DoRemove(X509Certificate2 cert, bool fDeleteKey, bool fMachine, str`
`1920`	`1920`	`/// </summary>`
`1921`	`1921`	`/// <param name="storeHandle">An IntPtr for store handle.</param>`
`1922`	`1922`	`/// <returns>No return.</returns>`
`1923`		`- private void CommitUserDS(IntPtr storeHandle)`
	`1923`	`+ private static void CommitUserDS(IntPtr storeHandle)`
`1924`	`1924`	`{`
`1925`	`1925`	`if (!Security.NativeMethods.CertControlStore(`
`1926`	`1926`	`storeHandle,`