Fix RCS1215: Expression is always equal to true/false (#14356)

xtqqczze · web-flow · commit 68821932c5aa · 2021-01-19T16:03:59.000+05:00
* Fix RCS1215: Expression is always equal to true/false
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs
@@ -107,7 +107,7 @@ protected bool DoesProviderSupportShouldProcess(string[] paths)
             // may be getting piped in.
             bool result = true;
 
-            if (paths != null && paths.Length >= 0)
+            if (paths != null)
             {
                 foreach (string path in paths)
                 {
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfacePromptForChoice.cs
@@ -252,7 +252,7 @@ public Collection<int> PromptForChoice(string caption,
                         // choices to be picked.
 
                         // user did not pick up any choices..choose the default
-                        if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))
+                        if (result.Count == 0)
                         {
                             // if there's a default, pick that one.
                             foreach (int defaultChoice in defaultChoiceKeys.Keys)
diff --git a/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs b/src/Microsoft.PowerShell.Security/security/CertificateProvider.cs
@@ -2010,16 +2010,14 @@ private object GetItemAtPath(string path, bool test, out bool isContainer)
             //
             // Thus lengths 1 & 2 are container items.
             //
-            isContainer = (pathElements.Length >= 0) &&
-                (pathElements.Length <= 2);
+            isContainer = pathElements.Length <= 2;
 
             X509NativeStore store = null;
 
             //
             // handle invalid path depth
             //
-            if ((pathElements.Length > 3) ||
-                (pathElements.Length < 0))
+            if (pathElements.Length > 3)
             {
                 if (test)
                 {
diff --git a/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs b/src/System.Management.Automation/engine/hostifaces/InternalHostUserInterface.cs
@@ -993,7 +993,7 @@ private Collection<int> EmulatePromptForMultipleChoice(string caption,
                     // choices to be picked.
 
                     // user did not pick up any choices..choose the default
-                    if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))
+                    if (result.Count == 0)
                     {
                         // if there's a default, pick that one.
                         foreach (int defaultChoice in defaultChoiceKeys.Keys)

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ protected bool DoesProviderSupportShouldProcess(string[] paths)`
`107`	`107`	`// may be getting piped in.`
`108`	`108`	`bool result = true;`
`109`	`109`
`110`		`- if (paths != null && paths.Length >= 0)`
	`110`	`+ if (paths != null)`
`111`	`111`	`{`
`112`	`112`	`foreach (string path in paths)`
`113`	`113`	`{`
Original file line number	Diff line number	Diff line change
`@@ -252,7 +252,7 @@ public Collection<int> PromptForChoice(string caption,`
`252`	`252`	`// choices to be picked.`
`253`	`253`
`254`	`254`	`// user did not pick up any choices..choose the default`
`255`		`- if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))`
	`255`	`+ if (result.Count == 0)`
`256`	`256`	`{`
`257`	`257`	`// if there's a default, pick that one.`
`258`	`258`	`foreach (int defaultChoice in defaultChoiceKeys.Keys)`
Original file line number	Diff line number	Diff line change
`@@ -993,7 +993,7 @@ private Collection<int> EmulatePromptForMultipleChoice(string caption,`
`993`	`993`	`// choices to be picked.`
`994`	`994`
`995`	`995`	`// user did not pick up any choices..choose the default`
`996`		`- if ((result.Count == 0) && (defaultChoiceKeys.Keys.Count >= 0))`
	`996`	`+ if (result.Count == 0)`
`997`	`997`	`{`
`998`	`998`	`// if there's a default, pick that one.`
`999`	`999`	`foreach (int defaultChoice in defaultChoiceKeys.Keys)`