Remove unnecessary CS0618 suppressions from Variant APIs (#26006)

xtqqczze · web-flow · commit 43c2d983495c · 2025-09-07T14:44:14.000Z
diff --git a/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs b/src/Microsoft.PowerShell.ConsoleHost/WindowsTaskbarJumpList/PropVariant.cs
@@ -34,9 +34,7 @@ internal PropVariant(string value)
                 throw new ArgumentException("PropVariantNullString", nameof(value));
             }
 
-#pragma warning disable CS0618 // Type or member is obsolete (might get deprecated in future versions
             _valueType = (ushort)VarEnum.VT_LPWSTR;
-#pragma warning restore CS0618 // Type or member is obsolete (might get deprecated in future versions
             _ptr = Marshal.StringToCoTaskMemUni(value);
         }
 
diff --git a/src/System.Management.Automation/engine/COM/ComInvoker.cs b/src/System.Management.Automation/engine/COM/ComInvoker.cs
@@ -7,9 +7,6 @@
 
 using COM = System.Runtime.InteropServices.ComTypes;
 
-// Disable obsolete warnings about VarEnum and COM-marshaling APIs in CoreCLR
-#pragma warning disable 618
-
 namespace System.Management.Automation
 {
     internal static class ComInvoker
diff --git a/src/System.Management.Automation/engine/COM/ComUtil.cs b/src/System.Management.Automation/engine/COM/ComUtil.cs
@@ -141,9 +141,6 @@ private static string GetStringFromCustomType(COM.ITypeInfo typeinfo, IntPtr ref
             return "UnknownCustomtype";
         }
 
-        // Disable obsolete warning about VarEnum in CoreCLR
-#pragma warning disable 618
-
         /// <summary>
         /// This function gets a string representation of the Type Descriptor
         /// This is used in generating signature for Properties and Methods.
@@ -259,8 +256,6 @@ internal static Type GetTypeFromTypeDesc(COM.TYPEDESC typedesc)
             return VarEnumSelector.GetTypeForVarEnum(vt);
         }
 
-#pragma warning restore 618
-
         /// <summary>
         /// Converts a FuncDesc out of GetFuncDesc into a MethodInformation.
         /// </summary>

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,7 @@ internal PropVariant(string value)`
`34`	`34`	`throw new ArgumentException("PropVariantNullString", nameof(value));`
`35`	`35`	`}`
`36`	`36`
`37`		`-#pragma warning disable CS0618 // Type or member is obsolete (might get deprecated in future versions`
`38`	`37`	`_valueType = (ushort)VarEnum.VT_LPWSTR;`
`39`		`-#pragma warning restore CS0618 // Type or member is obsolete (might get deprecated in future versions`
`40`	`38`	`_ptr = Marshal.StringToCoTaskMemUni(value);`
`41`	`39`	`}`
`42`	`40`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,6 @@`
`7`	`7`
`8`	`8`	`using COM = System.Runtime.InteropServices.ComTypes;`
`9`	`9`
`10`		`-// Disable obsolete warnings about VarEnum and COM-marshaling APIs in CoreCLR`
`11`		`-#pragma warning disable 618`
`12`		`-`
`13`	`10`	`namespace System.Management.Automation`
`14`	`11`	`{`
`15`	`12`	`internal static class ComInvoker`