Update Language Version to 10 and fix related issues (#15886)

adityapatwardhan · web-flow · commit 2ebac33a784e · 2021-08-09T12:21:14.000-07:00
diff --git a/PowerShell.Common.props b/PowerShell.Common.props
@@ -136,14 +136,16 @@
     <Copyright>(c) Microsoft Corporation.</Copyright>
 
     <TargetFramework>net6.0</TargetFramework>
-    <LangVersion>9.0</LangVersion>
+    <LangVersion>10.0</LangVersion>
     <PublishReadyToRun Condition=" '$(Configuration)' != 'Debug' ">true</PublishReadyToRun>
 
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
     <NeutralLanguage>en-US</NeutralLanguage>
+    <DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports>
+    <DisableImplicitNamespaceImports_DotNet>true</DisableImplicitNamespaceImports_DotNet>
 
     <DelaySign>true</DelaySign>
     <AssemblyOriginatorKeyFile>../signing/visualstudiopublic.snk</AssemblyOriginatorKeyFile>
diff --git a/build.psm1 b/build.psm1
@@ -437,6 +437,14 @@ Fix steps:
         $Arguments += "--output", (Split-Path $Options.Output)
     }
 
+    # Add --self-contained due to "warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used."
+    if ($Options.Runtime -like 'fxdependent*') {
+        $Arguments += "--no-self-contained"
+    }
+    else {
+        $Arguments += "--self-contained"
+    }
+
     if ($Options.Runtime -like 'win*' -or ($Options.Runtime -like 'fxdependent*' -and $environment.IsWindows)) {
         $Arguments += "/property:IsWindows=true"
     }

Original file line number	Diff line number	Diff line change
`@@ -437,6 +437,14 @@ Fix steps:`
`437`	`437`	`$Arguments += "--output", (Split-Path $Options.Output)`
`438`	`438`	`}`
`439`	`439`
	`440`	`+ # Add --self-contained due to "warning NETSDK1179: One of '--self-contained' or '--no-self-contained' options are required when '--runtime' is used."`
	`441`	`+ if ($Options.Runtime -like 'fxdependent*') {`
	`442`	`+ $Arguments += "--no-self-contained"`
	`443`	`+ }`
	`444`	`+ else {`
	`445`	`+ $Arguments += "--self-contained"`
	`446`	`+ }`
	`447`	`+`
`440`	`448`	`if ($Options.Runtime -like 'win' -or ($Options.Runtime -like 'fxdependent' -and $environment.IsWindows)) {`
`441`	`449`	`$Arguments += "/property:IsWindows=true"`
`442`	`450`	`}`