Fix Start-Transcript error when $Transcript is a PSObject wrapped string (#24963)

kborowinski · web-flow · commit 0beb24e10fea · 2025-02-07T22:23:05.000+05:00
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs
@@ -177,7 +177,7 @@ protected override void BeginProcessing()
                 }
                 else
                 {
-                    _outFilename = (string)value;
+                    _outFilename = (string)PSObject.Base(value);
                 }
             }
 
diff --git a/test/powershell/Modules/Microsoft.Powershell.Host/Start-Transcript.Tests.ps1 b/test/powershell/Modules/Microsoft.Powershell.Host/Start-Transcript.Tests.ps1
@@ -86,6 +86,11 @@ Describe "Start-Transcript, Stop-Transcript tests" -tags "CI" {
         $outputFilePath = Join-Path $TestDrive "PowerShell_transcript*"
         ValidateTranscription -scriptToExecute $script -outputFilePath $outputFilePath
     }
+    It "Should create Transcript file with 'Transcript' preference variable" {
+        # Casting to PSObject is necessary because Set-Variable does not automatically wrap the value in a PSObject
+        $script = "Set-Variable -Scope Global -Name Transcript -Value ([PSObject]'$transcriptFilePath'); Start-Transcript"
+        ValidateTranscription -scriptToExecute $script -outputFilePath $transcriptFilePath
+    }
     It "Should Append Transcript data in existing file if 'Append' parameter is used with Path parameter" {
         $script = "Start-Transcript -path $transcriptFilePath -Append"
         ValidateTranscription -scriptToExecute $script -outputFilePath $transcriptFilePath -append

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ protected override void BeginProcessing()`
`177`	`177`	`}`
`178`	`178`	`else`
`179`	`179`	`{`
`180`		`- _outFilename = (string)value;`
	`180`	`+ _outFilename = (string)PSObject.Base(value);`
`181`	`181`	`}`
`182`	`182`	`}`
`183`	`183`